[pgadmin-hackers] Re: [pgAdmin III] #331: Add support for SECURITY LABEL on databases, tablespaces, and roles.

2011-07-24 Thread pgAdmin Trac
#331: Add support for SECURITY LABEL on databases, tablespaces, and roles. --+- Reporter: gleu | Owner: gleu Type: feature | Status: assigned Priority:

Re: [pgadmin-hackers] Patch to add support for security labels on local objects

2011-07-24 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 10:58 +0200, Guillaume Lelarge wrote: > Hi, > > This patch adds support to a PostgreSQL 9.1 feature called security > labels. It adds a new tab to tables, columns, aggregates, domains, > foreign tables, functions, languages, sequences, types, and views > dialogs, that allows

[pgadmin-hackers] pgAdmin III commit: Fix altering comments on an existing function

2011-07-24 Thread Guillaume Lelarge
Fix altering comments on an existing function Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f7ebe911e7bf02557fdad3bb57e1783a926439e7 Modified Files -- pgadmin/dlg/dlgFunction.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 del

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Dave Page
On Sun, Jul 24, 2011 at 2:23 PM, Guillaume Lelarge wrote: > On Sun, 2011-07-24 at 14:11 +0200, Guillaume Lelarge wrote: >> On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: >> > The former fix seems more appropriate. Operations in frmMain shouldn't >> > cause dialogues to close. >> > >> >> Fine

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Dave Page
On Sun, Jul 24, 2011 at 1:11 PM, Guillaume Lelarge wrote: > On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: >> The former fix seems more appropriate. Operations in frmMain shouldn't >> cause dialogues to close. >> > > Fine with me. That should be simpler to do. > >> Simple fix seems to be to s

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 14:11 +0200, Guillaume Lelarge wrote: > On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: > > The former fix seems more appropriate. Operations in frmMain shouldn't > > cause dialogues to close. > > > > Fine with me. That should be simpler to do. > > > Simple fix seems to

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: > The former fix seems more appropriate. Operations in frmMain shouldn't > cause dialogues to close. > Fine with me. That should be simpler to do. > Simple fix seems to be to store a pointer to the dialog in pgObject; > if not null, disallow dr

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Dave Page
The former fix seems more appropriate. Operations in frmMain shouldn't cause dialogues to close. Simple fix seems to be to store a pointer to the dialog in pgObject; if not null, disallow drop, or if trying to view properties, use the pointer to raise the existing dialogue. Clear the pointer when

[pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Guillaume Lelarge
Hi, There is at least one bug that I know since I started to use pgAdmin, and I've seen no work on it. When someone connects to a database, the treeview is built from informations gathered in the database. Not only do we fill the treeview, but we also create a lot of pgObject objects (pgTable, pg