Re: [pgadmin-hackers] Weird code in pgDomain.cpp

2012-04-09 Thread Ashesh Vashi
On Sun, Apr 8, 2012 at 3:24 PM, Dave Page wrote: > On Sun, Apr 8, 2012 at 4:44 AM, Guillaume Lelarge > wrote: > > Hi, > > > > I was trying to fix a bug on dlgDomain, and I found this code (in > > pgadmin/schema/pgDomain.cpp): > > > > wxString conname = set->GetVal(wxT("conname")); > > if (!conna

[pgadmin-hackers] PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

2012-04-09 Thread Ashesh Vashi
Hi Dave, During resolving a bug - "Error message is displayed when the packages is clicked", I found that: - We are not properly handling the default parameters for the functions & procedures properly, when the function is type of 'edbspl'. - We also do not handle the default parameters for the fu