Re: [pgadmin-hackers] pldebugger server-side plugin

2012-04-16 Thread Guillaume Lelarge
On Mon, 2012-04-16 at 18:58 +0300, Heikki Linnakangas wrote: > Hi, > > The PL/pgSQL debugger included in pgadmin needs a bunch of server-side > support functions to be installed in the server. The code for the > server-side functions is currently located in a pgfoundry CVS > repository, in the

Re: [pgadmin-hackers] pldebugger server-side plugin

2012-04-16 Thread Dave Page
Thanks Heikki. On Mon, Apr 16, 2012 at 3:58 PM, Heikki Linnakangas wrote: > Hi, > > The PL/pgSQL debugger included in pgadmin needs a bunch of server-side > support functions to be installed in the server. The code for the > server-side functions is currently located in a pgfoundry CVS repository

[pgadmin-hackers] pldebugger server-side plugin

2012-04-16 Thread Heikki Linnakangas
Hi, The PL/pgSQL debugger included in pgadmin needs a bunch of server-side support functions to be installed in the server. The code for the server-side functions is currently located in a pgfoundry CVS repository, in the edb-debugger project. It's time to give that code facelift. I have con

Re: [pgadmin-hackers] PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

2012-04-16 Thread Dave Page
Thanks, applied. On Mon, Apr 16, 2012 at 12:53 PM, Ashesh Vashi < [email protected]> wrote: > On Mon, Apr 16, 2012 at 5:36 PM, Dave Page wrote: > >> Thanks - I've applied and pushed the patch for master > > Thanks! > >> , but the REL-1_14 version doesn't apply. >> >> error: patch fai

[pgadmin-hackers] pgAdmin III commit: Fix handling of parameter handling for edbspl funct

2012-04-16 Thread Dave Page
Fix handling of parameter handling for edbspl functions and package procedures/functions. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=658b4378426fcdac8b03d3f4529f4ca3aad77209 Author: Ashesh Vashi Modified Files --

Re: [pgadmin-hackers] PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

2012-04-16 Thread Ashesh Vashi
On Mon, Apr 16, 2012 at 5:36 PM, Dave Page wrote: > Thanks - I've applied and pushed the patch for master Thanks! > , but the REL-1_14 version doesn't apply. > > error: patch failed: pgadmin/schema/pgFunction.cpp:808 > Applied patch pgadmin/schema/edbPackageFunction.cpp cleanly. > Applying patc

Re: [pgadmin-hackers] PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

2012-04-16 Thread Dave Page
Thanks - I've applied and pushed the patch for master, but the REL-1_14 version doesn't apply. error: patch failed: pgadmin/schema/pgFunction.cpp:808 Applied patch pgadmin/schema/edbPackageFunction.cpp cleanly. Applying patch pgadmin/schema/pgFunction.cpp with 2 rejects... Hunk #1 applied cleanly.

[pgadmin-hackers] pgAdmin III commit: Fix handling of parameter handling for edbspl funct

2012-04-16 Thread Dave Page
Fix handling of parameter handling for edbspl functions and package procedures/functions. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a448673d41dd5afa404c3a4d6429f3df81ad82af Author: Ashesh Vashi Modified Files -- CHANGELOG

Re: [pgadmin-hackers] PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

2012-04-16 Thread Ashesh Vashi
On Mon, Apr 16, 2012 at 3:03 PM, Sachin Srivastava < [email protected]> wrote: > > Ashesh, > > In this code block, > > 360 + > (function->GetArgModesArray()[index] == wxT("INOUT") && > 361 +lanname != wxT("edbsql")) || > 362 + > function->Ge

Re: [pgadmin-hackers] PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

2012-04-16 Thread Sachin Srivastava
Ashesh, In this code block, 360 + (function->GetArgModesArray()[index] == wxT("INOUT") && 361 +lanname != wxT("edbsql")) || 362 + function->GetArgModesArray()[index] == wxT("VARIADIC")) lanname should be comapred to 'edbspl'. Rest all looks good. On Mo