Re: [pgadmin-hackers] Debugger line numbering is off by one

2012-04-26 Thread Dave Page
On Thu, Apr 26, 2012 at 11:42 AM, Heikki Linnakangas wrote: > On 25.04.2012 14:22, Dave Page wrote: >> >> On Wed, Apr 25, 2012 at 11:24 AM, Heikki Linnakangas >>  wrote: >>> >>> >>> The hack that was removed skipped an initial newline when counting line >>> numbers. The PL/pgSQL debugger has a si

Re: [pgadmin-hackers] Fix debugging on EDB with latest pldebugger

2012-04-26 Thread Dave Page
Thanks, patch applied. On Thu, Apr 26, 2012 at 11:51 AM, Heikki Linnakangas wrote: > Thanks to recent changes I made to the pldebugger server-side functions, the > EDB-specific parts of pldebugger are now linked into the same > plugin_debugger.so library as the PL/pgSQL parts. It used to produce

[pgadmin-hackers] pgAdmin III commit: Before EDBAS92, there was a separate library for SP

2012-04-26 Thread Dave Page
Before EDBAS92, there was a separate library for SPL and PL/pgSQL. Starting with 9.2, EDB uses the community version of pldebugger, and support for both languages is built into plugin_debugger.so Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8

[pgadmin-hackers] pgAdmin III commit: Fix line offsets in the debugger when used with 9.1

2012-04-26 Thread Dave Page
Fix line offsets in the debugger when used with 9.1 servers. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7b037cd8c1bffa527635beab3c3324bbc3bb915c Author: Heikki Linnakangas Modified Files -- CHANGELOG

[pgadmin-hackers] pgAdmin III commit: Fix line offsets in the debugger when used with 9.1

2012-04-26 Thread Dave Page
Fix line offsets in the debugger when used with 9.1 servers. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=393c8ec510460e3dc56440c5aff907de304f Author: Heikki Linnakangas Modified Files -- CHANGELOG |

[pgadmin-hackers] Fix debugging on EDB with latest pldebugger

2012-04-26 Thread Heikki Linnakangas
Thanks to recent changes I made to the pldebugger server-side functions, the EDB-specific parts of pldebugger are now linked into the same plugin_debugger.so library as the PL/pgSQL parts. It used to produce a separate plugin_spl_debugger.so library, but that was inconvenient. For example if yo

Re: [pgadmin-hackers] Debugger line numbering is off by one

2012-04-26 Thread Heikki Linnakangas
On 25.04.2012 14:22, Dave Page wrote: On Wed, Apr 25, 2012 at 11:24 AM, Heikki Linnakangas wrote: The hack that was removed skipped an initial newline when counting line numbers. The PL/pgSQL debugger has a similar hack, but it didn't get the memo that it was removed in the backend, so the gr