Re: [pgadmin-hackers] More information about the selected objects

2012-07-17 Thread Vinicius Santos
I fixed the problems. I removed the implementation on EnterpriseDB items, because I don't have how to test it. Can you help to test it? I tested on Windows 7 and Ubuntu. 0001-More-information-about-the-selected-objects.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (p

Re: [pgadmin-hackers] More information about the selected objects

2012-07-17 Thread Vinicius Santos
> > Which is entirely expected as both public synonyms and casts are > database level objects and thus don't have pgSchema as a parent class. > > I forgot to check the pgCast. Sorry I'll fix it and resubmit.

Re: [pgadmin-hackers] More information about the selected objects

2012-07-17 Thread Dave Page
On Tue, Jul 17, 2012 at 5:24 PM, Vinicius Santos wrote: > Attached. > > I think the information "user@database ( server )" is important. > > I tested on Windows 7. > I'll test on Ubuntu tonight. I have no idea how you managed to get that to compile on Windows: ./schema/edbSynonym.cpp: In member

Re: [pgadmin-hackers] More information about the selected objects

2012-07-17 Thread Vinicius Santos
Attached. I think the information "user@database ( server )" is important. I tested on Windows 7. I'll test on Ubuntu tonight. 0001-More-information-about-the-selected-objects.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make chan

Re: [pgadmin-hackers] SSH Tunneling implementation

2012-07-17 Thread Akshay Joshi
Hi I am facing one problem while adding libssh2 source code in pgAdmin3. As there are two file with same name "misc.c" and "misc.cpp", so compiler is unable to create object file. On Windows I have changed the path of the object file, but not found any solution on Linux. Meanwhile I have changed t

Re: [pgadmin-hackers] SSH Tunneling implementation

2012-07-17 Thread Dave Page
On Tue, Jul 17, 2012 at 2:16 PM, Akshay Joshi wrote: > Hi > > I am facing one problem while adding libssh2 source code in pgAdmin3. As > there are two file with same name "misc.c" and "misc.cpp", so compiler is > unable to create object file. On Windows I have changed the path of the > object file

Re: [pgadmin-hackers] SSH Tunneling implementation

2012-07-17 Thread Dave Page
On Tue, Jul 17, 2012 at 9:20 AM, Dave Page wrote: > On Tue, Jul 17, 2012 at 8:56 AM, Guillaume Lelarge > wrote: >> On Tue, 2012-07-17 at 08:30 +0100, Dave Page wrote: >>> On Tue, Jul 17, 2012 at 8:17 AM, Guillaume Lelarge >>> wrote: >>> > On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: >>> >

Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent reports failure upon success - For Review

2012-07-17 Thread Martin French
HiDave Page wrote on 17/07/2012 12:04:40:> From: Dave Page > To: Martin French , > Cc: pgadmin-hackers@postgresql.org, pgadmin-hackers-ow...@postgresql.org> Date: 17/07/2012 12:04> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent > reports failure upon success - For Review> > Great, t

Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent reports failure upon success - For Review

2012-07-17 Thread Dave Page
Great, that got it :-). Thanks Martin - patch applied and push to the main repo. It'll be included in the next release. On Tue, Jul 17, 2012 at 10:52 AM, Martin French wrote: > Hi Dave. > > Dave Page wrote on 17/07/2012 10:45:28: > >> From: Dave Page > > >> To: Martin French , >> Cc: pgadmin-h

[pgadmin-hackers] pgAgent commit: Ensure that SQL steps have their success or failure rep

2012-07-17 Thread Dave Page
Ensure that SQL steps have their success or failure reported correctly. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=bee4e427c145def3694876304193873ec7747283 Author: Martin French Modified Files -- connection.cpp |1 + i

Re: [pgadmin-hackers] Fixed pgAdmin3 folder hierarchy

2012-07-17 Thread Dave Page
Thanks, patch applied. On Mon, Jul 16, 2012 at 11:03 AM, Akshay Joshi wrote: > Hi Dave > > Attached is the patch that fix the folder hierarchy of pgAdmin3. I have > found some .cpp files are lying under the include folder hierarchy. > If it looks OK then can you please apply the patch. > -- > Ak

[pgadmin-hackers] pgAdmin III commit: Fix the visual studio filters.

2012-07-17 Thread Dave Page
Fix the visual studio filters. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=73dba99ca3f4088ae69b7b1b546e63b0c673a52b Author: Akshay Joshi Modified Files -- pgadmin/pgAdmin3.vcxproj.filters | 850

[pgadmin-hackers] pgAdmin III commit: Fix the visual studio filters.

2012-07-17 Thread Dave Page
Fix the visual studio filters. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=df1cd78ab6cae42c25577ef765a3d051f8787f66 Author: Akshay Joshi Modified Files -- pgadmin/pgAdmin3.vcxproj.filters | 850 +---

Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent reports failure upon success - For Review

2012-07-17 Thread Martin French
Hi Dave.Dave Page wrote on 17/07/2012 10:45:28:> From: Dave Page > To: Martin French , > Cc: pgadmin-hackers@postgresql.org, pgadmin-hackers-ow...@postgresql.org> Date: 17/07/2012 10:45> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent > reports failure upon success - For Review> > Hi

Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent reports failure upon success - For Review

2012-07-17 Thread Dave Page
Hi This still seems to be malformed - I'm getting: raptor:pgagent dpage$ patch -p1 < ~/Downloads/pgagent.patch (Stripping trailing CRs from patch.) patching file connection.cpp patch: malformed patch at line 6: if (result) Looking at the patch itself, it looks like the indentation is missin

Re: [pgadmin-hackers] SSH Tunneling implementation

2012-07-17 Thread Dave Page
On Tue, Jul 17, 2012 at 8:56 AM, Guillaume Lelarge wrote: > On Tue, 2012-07-17 at 08:30 +0100, Dave Page wrote: >> On Tue, Jul 17, 2012 at 8:17 AM, Guillaume Lelarge >> wrote: >> > On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: >> >> On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge >> >>

Re: [pgadmin-hackers] SSH Tunneling implementation

2012-07-17 Thread Guillaume Lelarge
On Tue, 2012-07-17 at 08:30 +0100, Dave Page wrote: > On Tue, Jul 17, 2012 at 8:17 AM, Guillaume Lelarge > wrote: > > On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: > >> On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge > >> wrote: > >> > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote:

Re: [pgadmin-hackers] SSH Tunneling implementation

2012-07-17 Thread Dave Page
On Tue, Jul 17, 2012 at 8:17 AM, Guillaume Lelarge wrote: > On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: >> On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge >> wrote: >> > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote: >> >> >> >> Not for me - and I'd be the first to complain if I

Re: [pgadmin-hackers] SSH Tunneling implementation

2012-07-17 Thread Guillaume Lelarge
On Tue, 2012-07-17 at 08:10 +0100, Dave Page wrote: > On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge > wrote: > > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote: > >> > >> Not for me - and I'd be the first to complain if I saw it doing that. > >> What do you see? > >> > > > > These: > > >

Re: [pgadmin-hackers] More information about the selected objects

2012-07-17 Thread Dave Page
On Mon, Jul 16, 2012 at 10:22 PM, Guillaume Lelarge wrote: > On Sat, 2012-07-14 at 20:48 +0100, Dave Page wrote: >> >> >> On Saturday, July 14, 2012, Guillaume Lelarge wrote: >> On Sat, 2012-07-14 at 18:57 +0100, Dave Page wrote: >> > >> > >> > On Saturday, July 14,

Re: [pgadmin-hackers] SSH Tunneling implementation

2012-07-17 Thread Dave Page
On Mon, Jul 16, 2012 at 10:21 PM, Guillaume Lelarge wrote: > On Sun, 2012-07-15 at 12:02 +0100, Dave Page wrote: >> >> Not for me - and I'd be the first to complain if I saw it doing that. >> What do you see? >> > > These: > > ./ogl/drawn.cpp: In member function ‘virtual void wxOpSetGDI::Do(wxDC&,