Re: [pgadmin-hackers] Autosave in the SQL Editor

2012-08-28 Thread Vinicius Santos
Hello, I did several tests and seems to be working good. If you have any suggestion for improvement, please let me know. Thanks! 0031-Implemeting-auto-save-feature-in-the-SQL-Editor.patch Description: Binary data -- Sent via pgadmin-hackers mailing list ([email protected]) To ma

Re: [pgadmin-hackers] Autosave in the SQL Editor

2012-08-28 Thread Vinicius Santos
Hello! I finished the patch. I'm testing deeper, on W7 and Ubuntu. I will probably send it tonight. Thanks!

Re: [pgadmin-hackers] SetSize function never called in case of modal dialog

2012-08-28 Thread Dave Page
Thanks, patch applied. On Tue, Aug 28, 2012 at 4:51 PM, Akshay Joshi wrote: > Hi Dave > > I have seen one problem in the dlgProperty::Go() function, where SetSize() > function which is used to fix UI glitch on MacOS X and Windows has never > been called in case of modal dialog. I have fixed the i

[pgadmin-hackers] pgAdmin III commit: Ensure dialog sizing works correctly with modal dia

2012-08-28 Thread Dave Page
Ensure dialog sizing works correctly with modal dialogs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=1ed72bfc6062a7a6bf3e612e400f06155d7e8eef Author: Akshay Joshi Modified Files -- pgadmin/dlg/dlgProperty.cpp |9 + 1

[pgadmin-hackers] pgAdmin III commit: Ensure dialog sizing works correctly with modal dia

2012-08-28 Thread Dave Page
Ensure dialog sizing works correctly with modal dialogs. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e3ee76ad11820ad2eb2220e0bb847e4263795627 Author: Akshay Joshi Modified Files -- pgadmin/dlg/dlgProperty.cpp |9

[pgadmin-hackers] SetSize function never called in case of modal dialog

2012-08-28 Thread Akshay Joshi
Hi Dave I have seen one problem in the dlgProperty::Go() function, where SetSize() function which is used to fix UI glitch on MacOS X and Windows has never been called in case of modal dialog. I have fixed the issue. Attached is the patch. Can you please review it and if it looks OK to you please

Re: [pgadmin-hackers] Same sub-menu name for disconnectDatabaseFactory and disconnectServerFactory.

2012-08-28 Thread Dave Page
Thanks, patch applied (though, I lower-cased the second words for consistency with most of the rest of the options). Guillaume, please note - this affects translations. We should review all these options in the future, and ensure we use standardised capitalisation. On Tue, Aug 28, 2012 at 1:51 PM

[pgadmin-hackers] pgAdmin III commit: Clarify disconnect menu option labels.

2012-08-28 Thread Dave Page
Clarify disconnect menu option labels. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9f4576c14090c1f06128bf18e8e7b1db4700fe53 Author: Sachin Srivastava Modified Files -- pgadmin/schema/pgDatabase.cpp |2 +- pgadmin

[pgadmin-hackers] pgAdmin III commit: Clarify disconnect menu option labels.

2012-08-28 Thread Dave Page
Clarify disconnect menu option labels. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b16bbb19921597edb25cf8be57dca2708dab581b Author: Sachin Srivastava Modified Files -- pgadmin/schema/pgDatabase.cpp |2 +- pgadmin/schema/pgSe

Re: [pgadmin-hackers] Same sub-menu name for disconnectDatabaseFactory and disconnectServerFactory.

2012-08-28 Thread Dave Page
Hi Do both options ever show up on the same menu together? On Tue, Aug 28, 2012 at 1:22 PM, Sachin Srivastava wrote: > Hi all, > > Sub-Menu name "Disconnect" is same for disconnectDatabaseFactory and > disconnectServerFactory. > > Attached patch fixes the issue. I have kept the shortcut key same

[pgadmin-hackers] Same sub-menu name for disconnectDatabaseFactory and disconnectServerFactory.

2012-08-28 Thread Sachin Srivastava
Hi all, Sub-Menu name "Disconnect" is same for disconnectDatabaseFactory and disconnectServerFactory. Attached patch fixes the issue. I have kept the shortcut key same because both Menu options can never be enable at the same time. -- Regards, Sachin Srivastava EnterpriseDB, India disconnect_