Re: [pgadmin-hackers] Materialized View Patch File

Thanks Dave. Thanks, Neel Patel On Mon, Jul 8, 2013 at 6:04 PM, Dave Page wrote: > Thanks, patch applied. > > On Wed, Jul 3, 2013 at 8:44 AM, Neel Patel > wrote: > > Hi Dave, > > > > Thanks for the comments. > > > > Find the attached patch with below fix. > > > > --- Incomplete comments remove

Re: [pgadmin-hackers] PATCH: Handling too many notices from the debugging function

On Mon, Jul 8, 2013 at 7:14 PM, Dave Page wrote: > Thanks - patch applied, with a minor change reducing the timer delay to > 100ms. Let me know if you see a problem with that. > Thanks I do not see any problem with that. Any way - it was a random number, and - chosen a little bigger number to be

Re: [pgadmin-hackers] PATCH: Wait for the thread only if it is running

Thanks On Mon, Jul 8, 2013 at 7:18 PM, Dave Page wrote: > Thanks - patch applied. > > > On Mon, Jul 8, 2013 at 6:03 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Found couple of more issues in the same area. >> - Forgot to set variable to NULL after deleting it >> - Removed red

Re: [pgadmin-hackers] PATCH: Debugger with Postgres Plus Advanced Server (EnterpriseDB)

Thanks On Mon, Jul 8, 2013 at 7:23 PM, Dave Page wrote: > Thanks, patch applied. > > > On Fri, Jul 5, 2013 at 1:32 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Debugger with PPAS was not working properly due some of the typos in the >> commands for the older ver

Re: [pgadmin-hackers] PATCH: Debug a function deleted outside the pgAdmin III environment

Thanks a lot. On Mon, Jul 8, 2013 at 7:27 PM, Dave Page wrote: > Thanks, patch applied. > > > On Mon, Jul 8, 2013 at 5:32 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave/Team, >> >> We found one more issue related to the debugger. >> When a user try to debug a function, w

[pgadmin-hackers] Re: PATCH: Handle the cross type of debugging (context & in-context) on same function at the same time

On Mon, Jul 8, 2013 at 7:00 PM, Dave Page wrote: > Hi > > > On Fri, Jul 5, 2013 at 8:14 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> During testing of the debugger, our (EnterpriseDB's) QA found an issue. >> Please found the scenario: >> >> 1. Start a global (in-

Re: [pgadmin-hackers] PATCH: Debug a function deleted outside the pgAdmin III environment

Thanks, patch applied. On Mon, Jul 8, 2013 at 5:32 AM, Ashesh Vashi wrote: > Hi Dave/Team, > > We found one more issue related to the debugger. > When a user try to debug a function, which is deleted outside the pgAdmin > III environment, it may result into an crash. > > Please find the patch to

[pgadmin-hackers] pgAdmin III commit: Handle attempts to debug dropped functions graceful

Handle attempts to debug dropped functions gracefully. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=effdb5ac5c19eea5fe336cc822aee6aaaea468aa Author: Ashesh Vashi Modified Files -- pgadmin/debugger/debugger.cpp | 18 ---

Re: [pgadmin-hackers] PATCH: Debugger with Postgres Plus Advanced Server (EnterpriseDB)

Thanks, patch applied. On Fri, Jul 5, 2013 at 1:32 PM, Ashesh Vashi wrote: > Hi Dave, > > Debugger with PPAS was not working properly due some of the typos in the > commands for the older version of debugger and in the target generation > query. > I also found an assert initializing the paramete

[pgadmin-hackers] pgAdmin III commit: Fix a number of issues with debugging on older vers

Fix a number of issues with debugging on older versions of PPAS, and ensure we can debug package initialisers. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5a2845b812958ecdb1de6f52677792e939c4b6eb Modified Files -- pgadmin/debugg

Re: [pgadmin-hackers] PATCH: Wait for the thread only if it is running

Thanks - patch applied. On Mon, Jul 8, 2013 at 6:03 AM, Ashesh Vashi wrote: > Found couple of more issues in the same area. > - Forgot to set variable to NULL after deleting it > - Removed redundant code > - Canceling the thread execution only if the thread is running > > Attached is the updated

[pgadmin-hackers] pgAdmin III commit: Only attempt to cancel query threads that are actua

Only attempt to cancel query threads that are actually running. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f7e8a2e6ed4c13911e8c39cb8a2be2401d4d18c9 Author: Ashesh Vashi Modified Files -- pgadmin/ctl/ctlSQLResult.cpp | 3

Re: [pgadmin-hackers] PATCH: Handling too many notices from the debugging function

Thanks - patch applied, with a minor change reducing the timer delay to 100ms. Let me know if you see a problem with that. On Fri, Jul 5, 2013 at 9:37 AM, Ashesh Vashi wrote: > Hi Dave, > > During testing of debugger in pgAdmin III, EnterpriseDB's QA found one > more bug. > If the function, whic

[pgadmin-hackers] pgAdmin III commit: If the function, which is being debugged, raise too

If the function, which is being debugged, raise too many notices, pgadmin will become unresponsive. As wxTextCtrl is not able to cop up with frequent AppendText calls, I have to introduce a timer to show the current message(s) after the timer stops. That allows to avoid the frequent call to the

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

On Mon, Jul 8, 2013 at 6:17 PM, Dave Page wrote: > Hi > > On Thu, Jul 4, 2013 at 3:10 PM, Dinesh Kumar < > dinesh.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Thanks for your time. >> >> Please find the attached new patch for the same. As per my testing on >> windows/linux, it's working fin

Re: [pgadmin-hackers] Patch for pgAdmin crash, while creating procedure.

Thanks, patch applied. On Fri, Jul 5, 2013 at 2:14 PM, Dinesh Kumar wrote: > Hi Dave, > > We have been noticed a pgAdmin crash issue while creating the procedure as > follows. > > 1) Take a new "Create procedure" dialog. > > 2) Enter the procedure name and code. > > 3) Click on "Ok" button or, "

[pgadmin-hackers] pgAdmin III commit: Prevent a crash when creating a stored procedure in

Prevent a crash when creating a stored procedure in PPAS. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=868b76cb720d03126577d2abca29786c3cc719fb Author: Dinesh Kumar Modified Files -- CHANGELOG |

[pgadmin-hackers] pgAdmin III commit: Prevent a crash when creating a stored procedure in

Prevent a crash when creating a stored procedure in PPAS. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=88ee4e96c6f6e2b2c453a20ed2c3b37fe6cd7a66 Author: Dinesh Kumar Modified Files -- CHANGELOG |2 ++ pgadmin

Re: [pgadmin-hackers] Materialized View Patch File

Thanks, patch applied. On Wed, Jul 3, 2013 at 8:44 AM, Neel Patel wrote: > Hi Dave, > > Thanks for the comments. > > Find the attached patch with below fix. > > --- Incomplete comments removed and added new comments > --- s/Closed/Materialized/ > --- Added column "relkind" in outer query and remo

[pgadmin-hackers] pgAdmin III commit: Use a modified icon to indicate materialised views.

Use a modified icon to indicate materialised views. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=22482cd8402ca3b378a2c4d467d5ad7bb28ea570 Author: Neel Patel Modified Files -- pgadmin/dlg/dlgView.cpp |7 --- pg