[pgadmin-hackers] pgadmin3.hhp.cached

2013-07-19 Thread Richard PALO
I needed to undo the following workaround put in Makefile.am: # We need to ensure the help cache is world writeable install-data-hook: - touch $(help_dir)/docs/en_US/pgadmin3.hhp.cached - chmod 0666 $(help_dir)/docs/en_US/pgadmin3.hhp.cached +# touch $(help_dir)/docs/en_US/pgad

Re: [pgadmin-hackers] warnings patch submission

2013-07-19 Thread Dave Page
On Fri, Jul 19, 2013 at 2:58 PM, Richard PALO wrote: > The following patch should get over the (in this case cosmetic) warning: >> >> ./gqb/gqbView.cpp: In member function 'void >> gqbView::onMotion(wxMouseEvent&)': >> ./gqb/gqbView.cpp:344:16: warning: converting 'false' to pointer type >> 'gqbOb

[pgadmin-hackers] pgAdmin III commit: Don't use --as-needed on Solaris.

2013-07-19 Thread Dave Page
Don't use --as-needed on Solaris. As /usr/bin/ld on illumos doesn't (yet) support --as-needed, this patch to acinclude.m4 will suppress the LDFLAGS -Wl,-as-needed passed when gcc is used as the compiler in the "bash bootstrap" command. This patch assumes that all gcc variants running on illumos (

[pgadmin-hackers] pgAdmin III commit: Fix assignment.

2013-07-19 Thread Dave Page
Fix assignment. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b13ed73877959ee8ec95ce729927cd64d48e89a2 Author: Richard PALO Modified Files -- pgadmin/gqb/gqbView.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletio

[pgadmin-hackers] pgAdmin III commit: Use $(MAKE) instead of make.

2013-07-19 Thread Dave Page
Use $(MAKE) instead of make. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=2265295d19c6eee42c7c5e602b557c6354d907da Author: Richard PALO Modified Files -- Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deleti

[pgadmin-hackers] pgAdmin III commit: Fix assignment.

2013-07-19 Thread Dave Page
Fix assignment. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c8cb82470e952f9644e023f225e01a526f48e1bf Author: Richard PALO Modified Files -- pgadmin/gqb/gqbView.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- S

[pgadmin-hackers] warnings patch submission

2013-07-19 Thread Richard PALO
The following patch should get over the (in this case cosmetic) warning: ./gqb/gqbView.cpp: In member function 'void gqbView::onMotion(wxMouseEvent&)': ./gqb/gqbView.cpp:344:16: warning: converting 'false' to pointer type 'gqbObject*' [-Wconversion-null] anySelected = false;

[pgadmin-hackers] pgAdmin III commit: Fix build for wx 2.9.5, along with an RPATH issue.

2013-07-19 Thread Dave Page
Fix build for wx 2.9.5, along with an RPATH issue. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=23c1bc0944468d07e0f54cb43193aaad9e4bbe74 Author: Ashesh Vashi Modified Files -- pgadmin/Makefile.am|2 +- pgadmin

Re: [pgadmin-hackers] RTI patch using $(MAKE) instead of 'make' for SPHINX_BUILD

2013-07-19 Thread Dave Page
Thanks - applied. On Fri, Jul 19, 2013 at 1:29 PM, Richard PALO wrote: > The following patches eases integration with pkgsrc... it would be nice to > integrate into the upcoming release. > > > diff --git a/Makefile.am b/Makefile.am > index d271d52..d98280a 100644 > --- a/Makefile.am > +++ b/Makef

[pgadmin-hackers] pgAdmin III commit: Use $(MAKE) instead of make.

2013-07-19 Thread Dave Page
Use $(MAKE) instead of make. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=04f90efd7035f6207c7bf917bd753d138e584f84 Author: Richard PALO Modified Files -- Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --

[pgadmin-hackers] RTI patch using $(MAKE) instead of 'make' for SPHINX_BUILD

2013-07-19 Thread Richard PALO
The following patches eases integration with pkgsrc... it would be nice to integrate into the upcoming release. diff --git a/Makefile.am b/Makefile.am index d271d52..d98280a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -95,7 +95,7 @@ style: # Create HTML docs doc: if SPHINX_BUILD - cd

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-19 Thread Neel Patel
Thanks Dave. On Fri, Jul 19, 2013 at 2:43 PM, Dave Page wrote: > Thanks, patch applied. > > On Fri, Jul 19, 2013 at 7:21 AM, Neel Patel > wrote: > > Hi Dave, > > > > Thanks for the comment. > > > > We made the changes as you suggested. > > > > Please find the updated patch in attachment and let

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-19 Thread Dave Page
Thanks, patch applied. On Fri, Jul 19, 2013 at 7:21 AM, Neel Patel wrote: > Hi Dave, > > Thanks for the comment. > > We made the changes as you suggested. > > Please find the updated patch in attachment and let me know if you have any > query. > > Thanks, > Neel Patel > > > On Thu, Jul 18, 2013 a

[pgadmin-hackers] pgAdmin III commit: Handle materialised views more efficiently, by not

2013-07-19 Thread Dave Page
Handle materialised views more efficiently, by not running queries for every view. Run make style while we're at it. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=30c29a1772209c6864b191bacb77e8c01fe0b26d Author: Neel Patel Modified Files ---

[pgadmin-hackers] pgAdmin III commit: Don't use --as-needed on Solaris.

2013-07-19 Thread Dave Page
Don't use --as-needed on Solaris. As /usr/bin/ld on illumos doesn't (yet) support --as-needed, this patch to acinclude.m4 will suppress the LDFLAGS -Wl,-as-needed passed when gcc is used as the compiler in the "bash bootstrap" command. This patch assumes that all gcc variants running on illumos (

Re: [pgadmin-hackers] Fwd: patch proposal for acinclude.m4 to better support gcc on illumos/smartos

2013-07-19 Thread Dave Page
Apologies - I guess I missed this. It's committed now - thanks! On Fri, Jul 19, 2013 at 7:51 AM, Richard PALO wrote: > As this seemed to fall upon deaf ears, I'll reiterate my request for > integration of the following patch which fixes the fact that the linker > directive '-as-needed' is not sup