Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

2013-07-26 Thread Dinesh Kumar
Hi Dave, Thanks for committing the patch. I have found one memory leak issue in the previous implementation and would like to submit this new patch on top of the Pg_Event_Trigger_V5.patch. Please find the below attached patch and valgrind output and let me know your inputs and suggestions. Thank

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

2013-07-26 Thread Dave Page
Thanks Akshay - patch applied, with a minor change to replace "EventTrigger" with "Event Trigger" in the treeview. Nice work Dinesh. On Wed, Jul 24, 2013 at 7:48 AM, Akshay Joshi wrote: > Hi Dinesh > > Code looks good to me. Dave I have finished the review for event trigger > functionality, you

[pgadmin-hackers] pgAdmin III commit: Add support for event triggers in 9.3+.

2013-07-26 Thread Dave Page
Add support for event triggers in 9.3+. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a71985564790c5dc3cbeb397d76c61f84a4ebc9a Author: Dinesh Kumar Modified Files -- CHANGELOG |1 + pgadmin/dlg/dl

Re: [pgadmin-hackers] Fixed crash in execution dialog

2013-07-26 Thread Dave Page
Thanks, patch applied. On Fri, Jul 26, 2013 at 8:53 AM, Akshay Joshi wrote: > Hi Dave > > Today I have fixed one crash in execution dialog. The bug is reproducible by > performing following steps: > > Connect to any database server. > Right click on the database(big in size) and select maintenanc

[pgadmin-hackers] pgAdmin III commit: Keep better track of when external process threads

2013-07-26 Thread Dave Page
Keep better track of when external process threads are running to avoid crashes if the user closes a window at the wrong time. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=76df8b8a5a2252e98df038aebff129ebca14ea2d Author: Akshay Joshi Modif

[pgadmin-hackers] Fixed crash in execution dialog

2013-07-26 Thread Akshay Joshi
Hi Dave Today I have fixed one crash in execution dialog. The bug is reproducible by performing following steps: 1. Connect to any database server. 2. Right click on the database(big in size) and select maintenance. 3. Start taking maintenance and click the cancel button. 4. After cli