Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-09-13 Thread Linreg
Hi Dave, > > - You seem to have hard-coded the exit code from Windows batch job > > > > steps to 1. Why? > > > > > > > > => i changed back to git-head version. i believe it come from old 3.3.0 > > source code version. I will never make such things. > > I'm working on git-head (d6c5a807110a7e

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-09-13 Thread Dave Page
Hi On Fri, Sep 13, 2013 at 11:43 AM, Linreg wrote: > Hi Dave, > > > > - The new code doesn't match the existing coding style - you've used 4 > > spaces instead of tabs for indents, and braces to open a new context > > are not on a new line for example. Please follow the existing coding > > style