Re: [pgadmin-hackers] PATCH: Fix Explain data output column not auto-sizing

2014-10-27 Thread Sanket Mehta
Hi, I have reviewed the patch. It looks good to me. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Oct 27, 2014 at 4:14 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > > On Fri, Oct 24, 2014 at 6:02 PM, J.F. Oster wrote: > > Hello! > > > > There is a smal

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3

2014-10-27 Thread Akshay Joshi
On Mon, Oct 27, 2014 at 4:22 PM, Ashesh Vashi wrote: > > On Mon, Oct 27, 2014 at 4:16 PM, Dave Page wrote: > >> Ashesh, can you review/commit this please? >> > Sure Dave. > I/Akshay will review the patch asap. > I have reviewed the patch and it looks good to me. > > > -- > > Thanks & Regard

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3

2014-10-27 Thread Ashesh Vashi
On Mon, Oct 27, 2014 at 4:16 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > Sure Dave. I/Akshay will review the patch asap. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/ashes

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3

2014-10-27 Thread Dave Page
Ashesh, can you review/commit this please? On Mon, Oct 27, 2014 at 9:56 AM, Sanket Mehta wrote: > Hi Dave, > > I have reviewed the older patch, it looked good to me except one issue > that I have fixed. > I have attached the revised patch with this mail. > > > > Regards, > Sanket Mehta > Sr Soft

Re: [pgadmin-hackers] PATCH: Stored procedure large parameter list

2014-10-27 Thread Dave Page
Ashesh, can you review/commit this please? On Sun, Oct 26, 2014 at 5:51 AM, J.F. Oster wrote: > Hello! > > Please consider this patch. It's a small formatting improvement for > pgFunction::GetSql() per discussion: > http://www.postgresql.org/message-id/CAHYn==4bqljo5y+aganc-hwrtkhpyduueq_nvbpbpyp

Re: [pgadmin-hackers] F8 for Execute to file

2014-10-27 Thread Dave Page
Ashesh, can you review/commit this please? On Fri, Oct 24, 2014 at 10:57 PM, Mads Jensen wrote: > Hi, > > It's a trivial patch: I miss a shortcut key for this function, and thus > created a patch to support it. > > I don't get why this was: > wxAcceleratorTable accel(12, entries); > and n

Re: [pgadmin-hackers] PATCH: Clear undo/redo history when a file is opened in Query editor

2014-10-27 Thread Dave Page
Ashesh, can you review/commit this please? On Fri, Oct 24, 2014 at 8:35 PM, J.F. Oster wrote: > Hello! > > A user may occasionaly assign content of a previously edited file into > a next file opened in the same Query window, by calling Undo and Save. > > Simple non-MDI text editors (for example,

Re: [pgadmin-hackers] PATCH: Fix Explain data output column not auto-sizing

2014-10-27 Thread Dave Page
Ashesh, can you review/commit this please? On Fri, Oct 24, 2014 at 6:02 PM, J.F. Oster wrote: > Hello! > > There is a small bug with Explain data output. > > Steps to reproduce: > > 1. Open a new Query window. > 2. Perform Explain of any query. Switch to "Data output" tab. Column > was auto-sized

Re: [pgadmin-hackers] PATCH: Support smallserial columns in Edit Data window

2014-10-27 Thread Dave Page
Ashesh, can you review/commit this please? On Fri, Oct 24, 2014 at 8:12 PM, J.F. Oster wrote: > Hello! > > This patch adds a few missing lines of code to handle smallserial > columns the same way as serial and bigserial. > > > -- > Best regards, > J.F. > > -- > Sent via pgadmin-hackers mailing l

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3

2014-10-27 Thread Sanket Mehta
Hi Dave, I have reviewed the older patch, it looked good to me except one issue that I have fixed. I have attached the revised patch with this mail. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Oct 27, 2014 at 3:16 PM, Akshay Joshi wrote: > Adding Sanket > > He has already

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3

2014-10-27 Thread Akshay Joshi
Adding Sanket He has already worked on it. On Tue, Feb 11, 2014 at 10:35 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Sure > > > On Mon, Feb 10, 2014 at 8:00 PM, Dave Page wrote: > >> Ashesh; can you review this please? >> >> Thanks. >> >> >> On Fri, Feb 7, 2014 at 9:17 AM, Dinesh