Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

2015-06-16 Thread John Obaterspok
Hello, I forgot to mention that yesterday I did a search for GetChar() and there was another place that also checked the length prior to calling GetChar(). But perhaps that case was different. Might be wx 3 related. (It has works fine except for an assert that pops up after connecting to a db +

Re: [pgadmin-hackers] [PATCH] Fix crash when disabling auto commit

2015-06-16 Thread Sanket Mehta
Hi, We were using wxWidgets 2.8.12 so that may be the issue. I will now try with wxwidgets 3.0.2 and let you know. Btw apart from this issue, we have also resolved other issues in the code, i will soon send a new patch for the same. Regards, Sanket Mehta Sr Software engineer Enterprisedb On

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

2015-06-16 Thread Dave Page
Sanket, can you look at this please? Sent from my iPad On 15 Jun 2015, at 16:33, John Obaterspok john.obaters...@gmail.com wrote: Hello, With the newly added option to disable auto commit (hurray) I really missed commit/rollback toolbar buttons. Attached patch adds this. -- john

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action

2015-06-16 Thread Sanket Mehta
Sure Dave. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Tue, Jun 16, 2015 at 4:55 PM, Dave Page dp...@pgadmin.org wrote: Sanket, can you look at this please? Sent from my iPad On 15 Jun 2015, at 16:33, John Obaterspok john.obaters...@gmail.com wrote: Hello, With the