[pgadmin-hackers] [pgAdmin4 Patch]: NodeAjaxOptionsControl Formatter Fix

2016-02-08 Thread Khushboo Vashi
Hi, The current formatter of NodeAjaxOptionsControl doesn't parse JS Array properly. So, I have fixed this issue and attached the patch for the same. Thanks, Khushboo diff --git a/web/pgadmin/browser/static/js/node.ui.js b/web/pgadmin/browser/static/js/node.ui.js index cd562af..f650961 100644

[pgadmin-hackers] pgAdmin 4 commit: Add a simple version check mechanism to warn the user

2016-02-08 Thread Dave Page
Add a simple version check mechanism to warn the user if a new release is available. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a52462dbf2dc4f1658446aefac25c3051930de4 Modified Files -- web/config.py

Re: [pgadmin-hackers] pgAdmin 3 update

2016-02-08 Thread Dave Page
On Mon, Feb 8, 2016 at 12:52 PM, Nikolai Zhubr wrote: > Hello Dave, > 08.02.2016 12:48, Dave Page: >> >> Just a quick heads-up - I'm going to wrap 1.22.1 today ready to go out >> with the PG updates later this week. There have been a few tweaks and >> fixes since 1.22.0, so it seems like a good id

Re: [pgadmin-hackers] pgAdmin 3 update

2016-02-08 Thread Nikolai Zhubr
Hello Dave, 08.02.2016 12:48, Dave Page: Just a quick heads-up - I'm going to wrap 1.22.1 today ready to go out with the PG updates later this week. There have been a few tweaks and fixes since 1.22.0, so it seems like a good idea. Indeed, sounds good. Whould there be some preliminary windows b

[pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-08 Thread Akshay Joshi
Hi All Attached is the patch for the Language Module. Please review it and if it looks good then please commit it. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Languages.patch Description: Binary data -- Sent via pgadmin-hackers mailin

[pgadmin-hackers] PATCH: Catalog Objects Node [pgAdmin4]

2016-02-08 Thread Murtuza Zabuawala
Hi, PFA patch for catalog objects node which is child of catalog node. (Catalog -> Information Schema -> Catalog Objects ). FYI, This node is already reviewed by Neel but I made changes in generate browser node function to add parent id. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.en

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

2016-02-08 Thread Andreas 'ads' Scherbaum
On 08.02.2016 11:23, Dave Page wrote: On Thu, Feb 4, 2016 at 12:22 PM, Andreas 'ads' Scherbaum wrote: The attached patch adds recognition for Greenplum HAWQ (SQL on Hadoop), where I know that it has problems with some catalog tables. An error message is still shown for HAWQ. The error message

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Resource Group Module

2016-02-08 Thread Akshay Joshi
Hi All Attached is the patch with the fixes. Please review it and if looks good then please commit it. On Mon, Feb 8, 2016 at 11:54 AM, Neel Patel wrote: > Hi Akshay, > > Please find below review comments. > > - As per the pgAdmin3, we should allow to enter the floating point value > in "CPU R

[pgadmin-hackers] pgAdmin III commit: Bump version.

2016-02-08 Thread Dave Page
Bump version. Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=62c3fdc384ba8b8471e96ce8f64ddb616afd78d4 Modified Files -- pgadmin/include/version.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via

[pgadmin-hackers] pgAdmin III commit: Make style.

2016-02-08 Thread Dave Page
Make style. Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f24b0f02a94b42314b4964354720e4b6fa3c1540 Modified Files -- pgadmin/dlg/dlgCast.cpp | 12 ++-- pgadmin/dlg/dlgView.cpp | 18 +- pga

[pgadmin-hackers] pgAdmin III commit: Make style.

2016-02-08 Thread Dave Page
Make style. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a34df5d0dfd4f6719054a19ef6c5d2f1147805f0 Modified Files -- pgadmin/dlg/dlgCast.cpp | 12 ++-- pgadmin/dlg/dlgView.cpp | 18 +- pgadmin/pgAdmin

[pgadmin-hackers] pgAdmin III commit: Update xrcDialogs.

2016-02-08 Thread Dave Page
Update xrcDialogs. Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=d4edbe3821a56354f16b907105561ea7dcc0222d Modified Files -- pgadmin/ui/xrcDialogs.cpp | 328 +++--- 1 file changed,

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

2016-02-08 Thread Dave Page
On Thu, Feb 4, 2016 at 12:22 PM, Andreas 'ads' Scherbaum wrote: > On 18.01.2016 02:44, Andreas 'ads' Scherbaum wrote: >> >> >> we tested pgAdminIII 1.22 internally and found that it works sufficient >> with Greenplum. A few minor problems are identified and we plan to work >> on them as well, but

[pgadmin-hackers] pgAdmin III commit: Update xrcDialogs.

2016-02-08 Thread Dave Page
Update xrcDialogs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=30af21b42e40a6c736c138cd8e61cb90478d138d Modified Files -- pgadmin/ui/xrcDialogs.cpp | 328 +++--- 1 file changed, 164 inserti

[pgadmin-hackers] pgAdmin III commit: Don't barf when connecting to Greenplum or Greenplu

2016-02-08 Thread Dave Page
Don't barf when connecting to Greenplum or Greenplum HAWQ Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f24f2a48a91c21cff352fd538c1668b82cd6e762 Author: Andreas 'ads' Scherbaum Modified Files -- CHANGELOG

[pgadmin-hackers] pgAdmin III commit: Don't barf when connecting to Greenplum or Greenplu

2016-02-08 Thread Dave Page
Don't barf when connecting to Greenplum or Greenplum HAWQ Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=3ccc9afcc8cb49f6b10a4292a3beb1cc7c9481e1 Author: Andreas 'ads' Scherbaum Modified Files -- CHANGELOG | 2 +

Re: [pgadmin-hackers] patch for cast module

2016-02-08 Thread Sanket Mehta
Hi Akshay, PFA the revised patch. All the comments are inline. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Fri, Feb 5, 2016 at 12:43 PM, Akshay Joshi wrote: > Hi Sanket > > Below are the review comments > >- As "Show System Object" is not implemented yet, we should show all

[pgadmin-hackers] pgAdmin 3 update

2016-02-08 Thread Dave Page
All, Just a quick heads-up - I'm going to wrap 1.22.1 today ready to go out with the PG updates later this week. There have been a few tweaks and fixes since 1.22.0, so it seems like a good idea. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterp