Re: [pgadmin-hackers] Dialogues not closing

On Fri, Apr 15, 2016 at 2:23 AM, Dave Page wrote: > Hey Ashesh, > > We have an issue with dialogues not closing on Save button presses. > One of the team told me yesterday or the day before that it's a > general issue, not one specific to the patch I was reviewing at the >

[pgadmin-hackers] pgAdmin 4 commit: Improvise the Select2Cell

Improvise the Select2Cell Select2 does not allow to scroll any of the parent container once it was opened, and if it was not properly closed. Also, resolved an issue - existing selection was not working, while re-rendering the Select2Cell. Branch -- master Details ---

Re: [pgadmin-hackers] pgadmin4 new server host rule is missing

Updated as well - thanks. On Thu, Apr 14, 2016 at 9:46 PM, Seçkin Alan wrote: > ++ > change node js > > full patch is attached > > On Thu, Apr 14, 2016 at 11:18 PM, Seçkin Alan wrote: >> Hi, >> In model Server.host field is nullable=False but, UI

[pgadmin-hackers] Dialogues not closing

Hey Ashesh, We have an issue with dialogues not closing on Save button presses. One of the team told me yesterday or the day before that it's a general issue, not one specific to the patch I was reviewing at the time, which I've been finding seems to be the case. Any idea what this issue is? --

[pgadmin-hackers] pgAdmin 4 commit: Validate the model on save.

Validate the model on save. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7b344185b431a05e167d21f56e29af652c97b938 Author: Seçkin Alan Modified Files -- web/pgadmin/browser/templates/browser/js/node.js | 4

Re: [pgadmin-hackers] pgadmin4 new server host rule is missing

++ change node js full patch is attached On Thu, Apr 14, 2016 at 11:18 PM, Seçkin Alan wrote: > Hi, > In model Server.host field is nullable=False but, UI Hostname/address > field can accept null value. > So, > When I click save button, in that time throw error like NOT

[pgadmin-hackers] pgAdmin 4 commit: Require a server hostname/address to be specified.

Require a server hostname/address to be specified. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=290e6949f877524335b5bcb8b82e3754d597dd3b Author: Seçkin Alan Modified Files --

Re: [pgadmin-hackers] pgadmin4 new server host rule is missing

Thanks - patch applied, with some improved messages for this check and the name check.. On Thu, Apr 14, 2016 at 9:18 PM, Seçkin Alan wrote: > Hi, > In model Server.host field is nullable=False but, UI Hostname/address > field can accept null value. > So, > When I click save

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

Hi On Thu, Apr 14, 2016 at 1:52 PM, Neel Patel wrote: > Hi, > > Please find attached v2 patch file of the debugger which fixes the below > issues which was not present in the first patch. > In this patch, we have added new table in sqlite database to store the >

[pgadmin-hackers] pgAdmin 4 commit: Procedural language debugger.

Procedural language debugger. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=12ae40fe62cd0b99be70469e4bc1a91f534a4d98 Author: Neel Patel Modified Files -- web/config.py

[pgadmin-hackers] pgadmin4 new server host rule is missing

Hi, In model Server.host field is nullable=False but, UI Hostname/address field can accept null value. So, When I click save button, in that time throw error like NOT NULL constraint failed: server.host . -- Seçkin ALAN http://sckn.org diff --git

Re: [pgadmin-hackers] PATCH: FTS Dictionary

Thanks for reviewing it Dave. I will resolve these issues ASAP. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Fri, Apr 15, 2016 at 1:27 AM, Dave Page wrote: > On Thu, Apr 14, 2016 at 3:41 PM, Sanket Mehta > wrote: > > Hi, > > > >

Re: [pgadmin-hackers] PATCH: FTS Dictionary

On Thu, Apr 14, 2016 at 3:41 PM, Sanket Mehta wrote: > Hi, > > PFA patch for FTS Dictionaries. > Please do review it and let me know in case of any issues. Thanks - committed with a few cosmetic changes, and a couple of minor issues to resolve: 1) The template is

[pgadmin-hackers] pgAdmin 4 commit: FTS Dictionary support (icons)

FTS Dictionary support (icons) Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b442cff41728d64f4cacbbe8f8c5732e6f9f0fd Author: Sanket Mehta Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: FTS Dictionary support.

FTS Dictionary support. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7305986e14d9e895886ecb6e803b34b05dd106b0 Author: Sanket Mehta Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix issue renaming FTS Parser.

Fix issue renaming FTS Parser. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b47577390a95ec5de35ca3d6156bd41b026ca99d Author: Sanket Mehta Modified Files --

Re: [pgadmin-hackers] PATCH: Resolving issue regarding FTS Parser name

Thanks - applied. On Thu, Apr 14, 2016 at 3:48 PM, Sanket Mehta wrote: > Hi, > > PFA the patch for resolving an issue related to FTS Parser name. > > Steps to reproduce the issue: > > - create fts parser with name "user name" > - Expand fts parser > - Right Click

[pgadmin-hackers] pgAdmin 4 commit: Update message catalog

Update message catalog Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dc06f92bb3f799cd661ee5bfa14ec271c3757e0f Modified Files -- web/pgadmin/messages.pot | 2977 -- 1 file changed, 2882

[pgadmin-hackers] PATCH: Resolving issue regarding FTS Parser name

Hi, PFA the patch for resolving an issue related to FTS Parser name. Steps to reproduce the issue: - create fts parser with name "user name" - Expand fts parser - Right Click and select properties - Change name to "user name car" it's give ERROR: syntax error at or near "name" LINE 2: RENAME

Re: [pgadmin-hackers] Styling error panel on dialogues

Per discussion in the office with Arun, we're going to move the error message div into the main button/status bar which will be a better way to resolve this issue. On Thu, Apr 14, 2016 at 2:35 PM, Arun Kollan wrote: > Hi Team, > The patch broke the vertical scroll

[pgadmin-hackers] pgAdmin 4 commit: Type fixes:

Type fixes: - Renaming or changing the schema for a shell type should not be allowed. - I'm allowed to try to add ACL entries or security labels to an existing shell type. This should be disallowed. - Changing the schema on a (non-shell) type doesn't work - the type name is omitted, e.g. ALTER

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Thanks - patch applied! On Thu, Apr 14, 2016 at 2:31 PM, Murtuza Zabuawala wrote: > Hi Dave, > > Sorry my bad I misinterpreted, I thought you meant rename/changing schema > only. > > PFA updated patch. > > And For Dialog not closing issue is generic and I have

[pgadmin-hackers] PATCH: FTS Dictionary

Hi, PFA patch for FTS Dictionaries. Please do review it and let me know in case of any issues. Regards, Sanket Mehta Sr Software engineer Enterprisedb diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/__init__.py

[pgadmin-hackers] pgAdmin4 python3 some issues

Hi, In Python 2.7 >>>NameError('seckin').message 'seckin' In Python3 >>> NameError('seckin').message Traceback (most recent call last): File "", line 1, in AttributeError: 'NameError' object has no attribute 'message' So In python3 some exceptions doesnt showing For example:

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

Hi On Thu, Apr 14, 2016 at 1:58 PM, Akshay Joshi wrote: > Hi All > > I have fixed review comments given by Dave and couple of them are remaining > > *Fixed Review Comments:* > >- The View Data menu option should be on the Object menu, which should >mirror

[pgadmin-hackers] pgAdmin 4 commit: Query tool/data editor initial version

Query tool/data editor initial version Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6acbcb5ad3af46a0cce1cb3a5ec1b75901a4b35 Author: Akshay Joshi Modified Files --

Re: [pgadmin-hackers] Styling error panel on dialogues

Hi Team, The patch broke the vertical scroll on all object properties panel. I have replaced the margin-bottom attribute with a value of 75px ( earlier it was 110px and was not required on discussion with Ashesh) . The attached patch should fix the issue with version 1 Thank you. Regards, Arun

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi Dave, Sorry my bad I misinterpreted, I thought you meant rename/changing schema only. PFA updated patch. And For Dialog not closing issue is generic and I have already created internal ticket for it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi, The first issue is only partially fixed - it'll still let me try to rename a shell type. Also, I notice when hitting Save on my changes, they're applied (if they're valid), but the dialogue doesn't close. I see the following in the browser console: Uncaught TypeError: Cannot read property

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi Dave, PFA patch to fixed given issues. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 14, 2016 at 5:11 PM, Dave Page wrote: > Thanks - patch applied. Unfortunately there are 3 more minor issues > for

[pgadmin-hackers] pgAdmin 4 commit: Fix favicon routing

Fix favicon routing Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=042021007698aa19152149faa8fbe1c521ee517e Modified Files -- web/pgadmin/redirects/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Thanks - patch applied. Unfortunately there are 3 more minor issues for you to fix: - Renaming or changing the schema for a shell type should not be allowed. - I'm allowed to try to add ACL entries or security labels to an existing shell type. This should be disallowed. - Changing the schema on

[pgadmin-hackers] pgAdmin 4 commit: Fix various issues with Types, per discussion

Fix various issues with Types, per discussion Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c047abd8a41c0973b35863dcb933b32c778b1182 Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Backend changes to fetch the statistics for the datab

Backend changes to fetch the statistics for the database and server nodes, along with the front-end changes for those node. NOTE: We've not yet added the support to show them on the front-end. Branch -- master Details ---

[pgadmin-hackers] Styling error panel on dialogues

Hi Team, Please find attached patch for fixing the styling issues with the error panel on dialogues. The codemirror-gutter will now extend to the bottom and will be overlayed on top of the object properties status bar. Thanks. Regards, Arun error_panel_on_dialogue_styling.patch Description:

[pgadmin-hackers] [pgAdmin 3][Patch]Row-level security policies

Hello, I've implemented basic support for Row-level security policies (introduced in PostgreSQL 9.5) in PgAdmin3. Please, have a look at patches attached to mail. First patch contains pgPolicy tree object, dlgPolicy dialog, some small changes in the pgTable and dlgTable code to represent

[pgadmin-hackers] Review: Views, Mat. Views, Vaccum controls, Columns, Indexes, Rules, Triggers

Hi This review combines the patches from the following threads. As they are so interdependent, please work on them as one patch moving forward: http://www.postgresql.org/message-id/cam5-9d93fb6hdgwanghwo5j+laszz7rpqm1a1hhg9qjorop...@mail.gmail.com

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi Dave, PFA updated patch which will fix mentioned issues. Hopefully the last one :-) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 13, 2016 at 6:18 PM, Dave Page wrote: > Hi > > I'm seeing some more

[pgadmin-hackers] pgAdmin 4 commit: Bind the current panel with the temporary functions,

Bind the current panel with the temporary functions, so that - it works on the object everytime, it hits the buttons, and the callback functions are being executed. The original implementation was not using the same panel, when it was recalled from other function. And, results into unexpected

[pgadmin-hackers] pgAdmin 4 commit: Load the codemirror as package in the require.js, whi

Load the codemirror as package in the require.js, which will allow us to load the codemirror addons without any modification. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30d189f499412a98f56b28f32fa9b0e502995dbf Modified Files

Re: [pgadmin-hackers] grant_wizard py3 bug

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Apr 14, 2016 at 12:40 AM, Seçkin Alan wrote: