Re: [pgadmin-hackers] [pgAdmin4][Patch]: Node issues under catalogs

2016-05-25 Thread Ashesh Vashi
On Thu, May 26, 2016 at 10:51 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > > > On Thu, May 26, 2016 at 9:28 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> >> >> On Thu, May 26, 2016 at 8:58 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Node issues under catalogs

2016-05-25 Thread Ashesh Vashi
On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Following are the issues fixed in this patch: > 1. Nodes not expanding under catalogs > *Issue: *Check for setting schema was missing. schema should set only if > node is in create mode. > > 2.

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Node issues under catalogs

2016-05-25 Thread Ashesh Vashi
On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Following are the issues fixed in this patch: > 1. Nodes not expanding under catalogs > *Issue: *Check for setting schema was missing. schema should set only if > node is in create mode. > > 2.

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-25 Thread Thom Brown
Thanks. I've raised all of these in tickets 1231 to 1237. Thom On 25 May 2016 at 04:23, Ashesh Vashi wrote: > Hi Thom, > > Can you please create RM cases for the same, it will be easy to track > those issues? > We're using

[pgadmin-hackers] [pgAdmin4][Patch]: Node issues under catalogs

2016-05-25 Thread Surinder Kumar
Hi Following are the issues fixed in this patch: 1. Nodes not expanding under catalogs *Issue: *Check for setting schema was missing. schema should set only if node is in create mode. 2. Error fetching node's properties. *Issue: *Node attribute *parent_type* is not set to catalogs. 3. Don't

Re: [pgadmin-hackers] [pgAdmin4][datagrid] : Fix URL generation issue in datagrid

2016-05-25 Thread Ashesh Vashi
thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, May 25, 2016 at 5:48 PM, Neel Patel

[pgadmin-hackers] pgAdmin 4 commit: Use the correct URL in the 'View Filtered Rows' dialo

2016-05-25 Thread Ashesh Vashi
Use the correct URL in the 'View Filtered Rows' dialog for the table node. It should have not honoured the object node which is selected afterwards. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=95fe98600ffa314080574a3857214a2ed4a6365e

Re: [pgadmin-hackers][pgAdmin4][Patch]: Load/Save file in query tool

2016-05-25 Thread Ashesh Vashi
thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, May 16, 2016 at 1:46 PM, Surinder Kumar <

[pgadmin-hackers] pgAdmin 4 commit: Error out - when user tries to load a binary file in

2016-05-25 Thread Ashesh Vashi
Error out - when user tries to load a binary file in the Query Editor. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4938beb3cdd371177993709f22368d67bab8da7 Author: Surinder Kumar Modified Files

[pgadmin-hackers] [pgAdmin4][datagrid] : Fix URL generation issue in datagrid

2016-05-25 Thread Neel Patel
Hi, Please find attached patch file for the fix of below issue. *Issue:-* This issue will reproduced only when user select "View Filtered Rows" option from context menu. URL parameters was not passed properly to filtered alertify dialog. Because of this last preserved table OID will be in the

Re: [pgadmin-hackers] PATCH: To fix the issue when user disconnects database and object menu remains the same (pgAdmin4)

2016-05-25 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, May 25, 2016 at 5:40 PM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1150 - Disconnecting a database action should

2016-05-25 Thread Ashesh Vashi
Fixes #1150 - Disconnecting a database action should followed by updating the menu state according to its current state. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db79f3ff3d74b31ab9b18d22dbfdb76bc361437c Author: Murtuza Zabuawala

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Add support for Materialized View & Cancel button on dialog header in Grant Wizard

2016-05-25 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, May 25, 2016 at 2:06 PM, Surinder Kumar <

[pgadmin-hackers] PATCH: To fix the issue when user disconnects database and object menu remains the same (pgAdmin4)

2016-05-25 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue when user disconnects the database with right click context menu and object menu remains the same with old options. (RM#1150) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1150.patch Description:

[pgadmin-hackers] pgAdmin 4 commit: [Grant Wizard] Added support for Materialized View in

2016-05-25 Thread Ashesh Vashi
[Grant Wizard] Added support for Materialized View in the Grant Wizard. Also - done proper view clean up when the wizard is cancelled. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4741992ad7ecd3ee81ec0848d04a81dd1a0ce250 Author: Surinder

Re: [pgadmin-hackers] PATCH: To fix issue in Updating comments in sequence node (pgAdmin4)

2016-05-25 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, May 24, 2016 at 3:38 PM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1118 - Handle null, or empty string for the co

2016-05-25 Thread Ashesh Vashi
Fixes #1118 - Handle null, or empty string for the comments in Jinja2 template for Sequence Node. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b1aa956af8ea3a391a40e13ea028a51198dd1cce Author: Murtuza Zabuawala

[pgadmin-hackers] pgAdmin 4 commit: Dialog default sizing.

2016-05-25 Thread Dave Page
Dialog default sizing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf0f692d00af037751906e272d471b6869a19489 Author: Ashesh Vashi Modified Files -- web/pgadmin/browser/static/js/panel.js

[pgadmin-hackers] [pgAdmin4][Patch]: Add support for Materialized View & Cancel button on dialog header in Grant Wizard

2016-05-25 Thread Surinder Kumar
Hi Please find attached patch for the supported added for following: 1. Adds support for Materialized Views in Grant Wizard. 2. Modified wizard template defined in wizard.js to add support for cancel button in wizard header. *Issue: *When the wizard is closed, it should cleanup the Backbone

[pgadmin-hackers] pgAdmin 4 commit: Role can update the catalog is not support from PG >=

2016-05-25 Thread Ashesh Vashi
Role can update the catalog is not support from PG >= 9.5. We will set rolcatupdate same as rolsuper from the properties query for PG >= 9.5 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=798ff03818b400338b16c50dbe490ac9df8dd1d5 Modified

[pgadmin-hackers] pgAdmin 4 commit: Center align the switch in backgrid

2016-05-25 Thread Ashesh Vashi
Center align the switch in backgrid Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=75fb99651af3f9b318ce9233beb76f3ef7723d03 Modified Files -- web/pgadmin/static/css/overrides.css | 6 ++ 1 file changed, 6 insertions(+) --

Re: [pgadmin-hackers] Patch for pgAdmin4 docs

2016-05-25 Thread Susan Douglas
> On May 24, 2016, at 12:02 PM, Dave Page wrote: > > Hi > > This seems to be missing the images. Did you remember to git add them, > before diff'ing? I think the .png's are already checked in as part of the last patch... -- Susan > > On Tue, May 24, 2016 at 4:21 PM,

[pgadmin-hackers] Patch for pgAdmin4 docs

2016-05-25 Thread Susan Douglas
Hi All, I've attached a patch that updates the Foreign Table dialog - this patch does not address all of the problems in the index file (I'm hoping to get that cleaned up next week). Thanks! -- Susan pgadmin_doc.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] pgAdmin3 patch for pgFunctions.cpp

2016-05-25 Thread Dave Page
On Tue, May 24, 2016 at 7:57 PM, Andreas 'ads' Scherbaum wrote: > On 24.05.2016 14:38, Dave Page wrote: >> >> Thanks, applied. >> > > Thanks for applying the patch. Are there any plans for a next release for > pgAdmin3? We'll probably do a minor release for the next

Re: [pgadmin-hackers] Patch for pgAdmin4 docs

2016-05-25 Thread Dave Page
On Tue, May 24, 2016 at 8:03 PM, Susan Douglas wrote: > > I've created another patch (below) that adds the .rst and .png files, and > includes an updated index.rst file that adds the Foreign Table dialog. There > are still errors related to the index, but I'd

[pgadmin-hackers] pgAdmin 4 commit: Foreign table docs.

2016-05-25 Thread Dave Page
Foreign table docs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9121bede668f979605f64d3625a05f1ad5840e8 Author: Susan Douglas Modified Files -- docs/en_US/foreign_table_dialog.rst |