Re: [pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Colin Beckingham
On 08/06/16 12:22, Dave Page wrote: On Wed, Jun 8, 2016 at 5:03 PM, Colin Beckingham wrote: Right, forced an upgrade via pip2 and it overwrote the existing psycopg2. In interactive mode psycopg2 now imports correctly. Now, when I run step 3 from web directory the command is accepted but there

Re: [pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Dave Page
On Wed, Jun 8, 2016 at 5:03 PM, Colin Beckingham wrote: > > Right, forced an upgrade via pip2 and it overwrote the existing psycopg2. In > interactive mode psycopg2 now imports correctly. > Now, when I run step 3 from web directory the command is accepted but there > is no output. The command appe

[pgadmin-hackers] pgAdmin 4 v1.0 Beta 1 - Soft Release

2016-06-08 Thread Dave Page
pgadmin-hackers subscribers, I'm pleased to announce that I've just released pgAdmin 4 v1.0 Beta 1 for testing. You can find more details on the website: Announcement: https://www.pgadmin.org/ Documentation (WIP): https://www.pgadmin.org/docs4/dev/index.html Downloads: https://www.pgadmin.org/d

Re: [pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Colin Beckingham
On 08/06/16 11:40, Ashesh Vashi wrote: On Jun 8, 2016 20:54, "Colin Beckingham" > wrote: > > > > On 08/06/16 09:57, Dave Page wrote: >> >> On Wed, Jun 8, 2016 at 2:46 PM, Ashesh Vashi >> > wrote: >>> >>> On Jun 8, 2016 18:53,

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework

2016-06-08 Thread Dave Page
Thanks - applied. On Wed, Jun 8, 2016 at 2:55 PM, Surinder Kumar wrote: > Hi Dave, > > Please find attached patch > Issue: Make the grant wizard dialogue non-modal. > > I have set two properties in dialog options: > a) modal: false > b) pinnable: false (setting modal to false adds pin to the titl

[pgadmin-hackers] pgAdmin 4 commit: Tag REL-1_0-BETA1 has been created.

2016-06-08 Thread Dave Page
Tag REL-1_0-BETA1 has been created. View: http://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-1_0-BETA1 Log Message --- Tag 1.0 Beta 1 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.o

[pgadmin-hackers] pgAdmin 4 commit: Make the Grant Wizard non-modal.

2016-06-08 Thread Dave Page
Make the Grant Wizard non-modal. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=085f8e198e386515b827c8fb3b896dd529b19650 Author: Surinder Kumar Modified Files -- .../grant_wizard/templates/grant_wizard/js/grant_wizard.js | 12 ++

Re: [pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Ashesh Vashi
On Jun 8, 2016 20:54, "Colin Beckingham" wrote: > > > > On 08/06/16 09:57, Dave Page wrote: >> >> On Wed, Jun 8, 2016 at 2:46 PM, Ashesh Vashi >> wrote: >>> >>> On Jun 8, 2016 18:53, "Colin Beckingham" wrote: Thanks. config_local.py did not exist. I created one in the "web" direc

Re: [pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Colin Beckingham
On 08/06/16 09:57, Dave Page wrote: On Wed, Jun 8, 2016 at 2:46 PM, Ashesh Vashi wrote: On Jun 8, 2016 18:53, "Colin Beckingham" wrote: Thanks. config_local.py did not exist. I created one in the "web" directory, with entries for SECRET_KEY, SECURITY_PASSWORD_SALT and CSRF_SESSION_KEY (wit

[pgadmin-hackers] pgAdmin website commit: Ignore the svnrepo link.

2016-06-08 Thread Dave Page
Ignore the svnrepo link. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=d20957751731054433e0da506504decf3c4c9a67 Modified Files -- .gitignore | 1 + 1 file changed, 1 insertion(+) -- Sent via pgadmin-hackers mailing list (pgad

[pgadmin-hackers] pgAdmin website commit: pgAdmin 4 Beta 1

2016-06-08 Thread Dave Page
pgAdmin 4 Beta 1 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=acba189f3d95a15b5bc2587f1c4b46cf13c75c04 Modified Files -- docs/menu.php | 5 + download/adminpacks.php

Re: [pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Colin Beckingham
On 08/06/16 09:57, Dave Page wrote: On Wed, Jun 8, 2016 at 2:46 PM, Ashesh Vashi wrote: On Jun 8, 2016 18:53, "Colin Beckingham" wrote: Thanks. config_local.py did not exist. I created one in the "web" directory, with entries for SECRET_KEY, SECURITY_PASSWORD_SALT and CSRF_SESSION_KEY (wit

[pgadmin-hackers] pgAdmin 4 commit: Exclude config_local.py from PIP wheels.

2016-06-08 Thread Dave Page
Exclude config_local.py from PIP wheels. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f46227c3dfbb96270be09c05034068796501ea59 Modified Files -- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin

Re: [pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Dave Page
On Wed, Jun 8, 2016 at 2:46 PM, Ashesh Vashi wrote: > > On Jun 8, 2016 18:53, "Colin Beckingham" wrote: >> >> Thanks. config_local.py did not exist. I created one in the "web" >> directory, with entries for SECRET_KEY, SECURITY_PASSWORD_SALT and >> CSRF_SESSION_KEY (with fabricated entry values)

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework

2016-06-08 Thread Surinder Kumar
Hi Dave, Please find attached patch *Issue: *Make the grant wizard dialogue non-modal. I have set two properties in dialog options: a) modal: false b) pinnable: false (setting modal to false adds pin to the title which is not needed). On Wed, Jun 8, 2016 at 6:49 PM, Surinder Kumar < surinder.ku.

Re: [pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Ashesh Vashi
On Jun 8, 2016 18:53, "Colin Beckingham" wrote: > > Thanks. config_local.py did not exist. I created one in the "web" directory, with entries for SECRET_KEY, SECURITY_PASSWORD_SALT and CSRF_SESSION_KEY (with fabricated entry values) as detailed in the code in https://github.com/asheshv/pgadmin4/b

Re: [pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Colin Beckingham
Thanks. config_local.py did not exist. I created one in the "web" directory, with entries for SECRET_KEY, SECURITY_PASSWORD_SALT and CSRF_SESSION_KEY (with fabricated entry values) as detailed in the code in https://github.com/asheshv/pgadmin4/blob/master/web/pgAdmin4.py, redid qmake, make cle

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework

2016-06-08 Thread Surinder Kumar
On Wed, Jun 8, 2016 at 6:40 PM, Dave Page wrote: > On Wed, Jun 8, 2016 at 1:55 PM, Surinder Kumar > wrote: > > > > > > On Wed, Jun 8, 2016 at 6:15 PM, Dave Page wrote: > >> > >> On Wed, Jun 8, 2016 at 1:41 PM, Surinder Kumar > >> wrote: > >> > On Wed, Jun 8, 2016 at 6:07 PM, Dave Page wrote:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework

2016-06-08 Thread Dave Page
On Wed, Jun 8, 2016 at 1:55 PM, Surinder Kumar wrote: > > > On Wed, Jun 8, 2016 at 6:15 PM, Dave Page wrote: >> >> On Wed, Jun 8, 2016 at 1:41 PM, Surinder Kumar >> wrote: >> > On Wed, Jun 8, 2016 at 6:07 PM, Dave Page wrote: >> >> >> >> Hi >> >> >> >> On Tue, Jun 7, 2016 at 9:44 AM, Surinder K

[pgadmin-hackers] pgAdmin 4 commit: Add a Help button to the bottom left of the Wizard fr

2016-06-08 Thread Dave Page
Add a Help button to the bottom left of the Wizard framework Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47d7e24bb91f22da3b55c941f515ce76248f2cc6 Author: Surinder Kumar Modified Files -- web/pgadmin/browser/static/css/wizard.cs

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework

2016-06-08 Thread Surinder Kumar
On Wed, Jun 8, 2016 at 6:15 PM, Dave Page wrote: > On Wed, Jun 8, 2016 at 1:41 PM, Surinder Kumar > wrote: > > On Wed, Jun 8, 2016 at 6:07 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Tue, Jun 7, 2016 at 9:44 AM, Surinder Kumar > >> wrote: > >> > Hi, > >> > > >> > Please find the patch with

Re: [pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Ashesh Vashi
Hi, What do you have in config_local. py? It is failing to load that file. -- Thanks & Regards, Ashesh Vashi On Jun 8, 2016 17:45, "Colin Beckingham" wrote: > FWIW I can build a pgAdmin4 file ok on openSUSE linux, but on launch I see: > > ~/pgadmin4/runtime> ./pgAdmin4 > Python path: "/usr/li

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework

2016-06-08 Thread Surinder Kumar
On Wed, Jun 8, 2016 at 6:07 PM, Dave Page wrote: > Hi > > On Tue, Jun 7, 2016 at 9:44 AM, Surinder Kumar > wrote: > > Hi, > > > > Please find the patch with following changes: > > 1. Added help button to the bottom left of the wizard framework. > > Usage: > > Set wizard_help property with url wh

[pgadmin-hackers] pgAdmin 4 commit: Cleanup a couple of issues missed when the Windows in

2016-06-08 Thread Dave Page
Cleanup a couple of issues missed when the Windows installer patch was committed. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d8cbbae3a446435f1072d3e8aaa762c0476630c2 Author: Paresh More Modified Files -- .gitignore

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework

2016-06-08 Thread Dave Page
Hi On Tue, Jun 7, 2016 at 9:44 AM, Surinder Kumar wrote: > Hi, > > Please find the patch with following changes: > 1. Added help button to the bottom left of the wizard framework. > Usage: > Set wizard_help property with url while creating wizard object. > > var wizard = new (pgBrowser.Wizard.ext

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1277 - Few cosmetic issues with preference dialog

2016-06-08 Thread Dave Page
Thanks, applied. On Mon, Jun 6, 2016 at 9:45 AM, Surinder Kumar wrote: > Hi, > > Please find the patch for issues fixed: > 1. Foreign keys listed twice > The label for Exclusion constraint was set to 'Foreign keys'. fixed it. > 2. Trigger function, Unique constraint, Primary key should be in titl

[pgadmin-hackers] pgAdmin 4 commit: Fix various cosmetic issues with preference dialog

2016-06-08 Thread Dave Page
Fix various cosmetic issues with preference dialog 1. Foreign keys listed twice The label for Exclusion constraint was set to 'Foreign keys'. fixed it. 2. Trigger function, Unique constraint, Primary key should be in title case 3. if user click outside of Preferences window it disappear (it should

Re: [pgadmin-hackers] [pgAdmin4][Debugger][Patch]: RM-1225 - Debugger start error if function contains special characters

2016-06-08 Thread Dave Page
Thanks, applied. On Sat, Jun 4, 2016 at 9:49 AM, Neel Patel wrote: > Hi, > > Please find the attached patch file for the fix of RM-1225. > > Issue :- > Debugger start error when function name contains the special characters. > > Solution:- > Added "qtIdent" function so that special characters wil

[pgadmin-hackers] pgAdmin 4 commit: Properly quote function names when starting the debug

2016-06-08 Thread Dave Page
Properly quote function names when starting the debugger. Fixes #1225 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=17fa6dcc402693713004e7f3065314e14ed34bef Author: Neel Patel Modified Files -- web/pgadmin/tools/debugger/__init__

[pgadmin-hackers] pgAdmin 4 commit: Add the Query Tool to the context menu, and improve p

2016-06-08 Thread Dave Page
Add the Query Tool to the context menu, and improve prioritisation. Fixes #1256 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8eb074207619ef09b97d7ac72a94c4916b6f5d29 Author: Surinder Kumar Modified Files -- .../browser/templates

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1256 - Add support for Query tool in the context menu

2016-06-08 Thread Dave Page
Thanks, committed with some priority tweaks. On Fri, Jun 3, 2016 at 6:54 PM, Surinder Kumar wrote: > Hi, > > Please find attached patch for RM#1256 > Explanation: > 1) Add support for query tool in context menu for nodes and collections. > 2) Added 'unsupported_node' object of datagrid as pgAdmin

[pgadmin-hackers] pgadmin4: Server does not launch

2016-06-08 Thread Colin Beckingham
FWIW I can build a pgAdmin4 file ok on openSUSE linux, but on launch I see: ~/pgadmin4/runtime> ./pgAdmin4 Python path: "/usr/lib64/python2.7" Webapp path: "/home/colin/pgadmin4/web/pgAdmin4.py" Traceback (most recent call last): File "/home/colin/pgadmin4/web/pgAdmin4.py", line 23, in i

Re: [pgadmin-hackers] PATCH: TO fix issue in Role node (pgAdmin4)

2016-06-08 Thread Dave Page
On Fri, Jun 3, 2016 at 3:19 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix an issue while creating role if user has set expire date. > Current implements works only if datestyle is set to ISO,MDY in database for > others it fails. > (RM#1134) With this patch applied, the SQL shown on the

[pgadmin-hackers] pgAdmin 4 commit: Fix unwanted space indentation issue in Database node

2016-06-08 Thread Dave Page
Fix unwanted space indentation issue in Database node. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d7f5e95b2babccea8f315edff2fb3f66f1ac96ec Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/server_groups/servers/d

Re: [pgadmin-hackers] PATCH: Reset view/layout (pgAdmin4)

2016-06-08 Thread Dave Page
Hi On Wed, Jun 8, 2016 at 12:41 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to add reset view/layout. > Please review. > > RM#1248 This needs to go on a different menu (File?), otherwise it won't be accessible when running in desktop mode. > - Additionally, attaching patch to fix validatio

[pgadmin-hackers] pgAdmin 4 commit: Fix validation issue causing statistics tab to break

2016-06-08 Thread Dave Page
Fix validation issue causing statistics tab to break if no node is selected on browser tree and user clicks on statistics tab. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47007076cc22ea56eacff41e8d70463d6c57810f Author: Murtuza Zabuawala

Re: [pgadmin-hackers] [pgAdmin4][Patch]: TypeError: Cannot read property 'generate_url' of undefined

2016-06-08 Thread Dave Page
Thanks, applied. On Tue, Jun 7, 2016 at 12:02 PM, Surinder Kumar wrote: > Hi, > > Issue: When any of the docked tab(statistics, dependents & dependencies) are > clicked without selecting any tree node. it gives error in browser console > panel. > Because the node passed is undefined. and check is

[pgadmin-hackers] pgAdmin 4 commit: When any of the docked tab(statistics, dependents & d

2016-06-08 Thread Dave Page
When any of the docked tab(statistics, dependents & dependencies) are clicked without selecting any tree node. it gives error in browser console panel. Because the node passed is undefined. and check is missing. This is now fixed by adding check for node passed. Branch -- master Details -

[pgadmin-hackers] PATCH: Reset view/layout (pgAdmin4)

2016-06-08 Thread Murtuza Zabuawala
Hi, PFA patch to add reset view/layout. Please review. RM#1248 --- - Additionally, attaching patch to fix validation issue. which was causing statistics tab to break if no node is selected on browser tree and user clicks on statistics tab. - And also observed an issue with panels ca

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

2016-06-08 Thread Dave Page
Thanks! That's now committed, with a few modifications: - Install/uninstall Sphinx as it's not actually in the requirements.txt file and is only needed for building. - Detect errors in the doc build. - Rename ve_python to venv for consistency with Mac. - Comment/progress info improvements On Wed,

[pgadmin-hackers] pgAdmin 4 commit: Windows installer!

2016-06-08 Thread Dave Page
Windows installer! Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47dccec915548abfcad4f2ea0017477132ba96fb Author: Paresh More Modified Files -- .gitignore | 4 + Make.bat | 494 +

Re: [pgadmin-hackers] [pgAdmin4][runtime]: Fix #1310 - Application icon missing from runtime

2016-06-08 Thread Dave Page
Thanks - pushed. On Wed, Jun 8, 2016 at 9:44 AM, Neel Patel wrote: > Hi, > > Please find attached patch file for the fix of issue #1310. > > Issue :- > > Application icon is missing from runtime title bar when the exe is built on > windows. > > Solution:- > > Qt5 :- > > Qt5 handle it automaticall

[pgadmin-hackers] pgAdmin 4 commit: Icon for the Windows runtime executable. Fixes #1310

2016-06-08 Thread Dave Page
Icon for the Windows runtime executable. Fixes #1310 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1a0a9bab22a306dc7188a939f5315f80a0d228a Author: Neel Patel Modified Files -- runtime/pgAdmin4.pro | 8 +++- runtime/pgAdmin4.r

Re: [pgadmin-hackers] Patch for pgAdmin 4 docs

2016-06-08 Thread Dave Page
Hi On Tue, Jun 7, 2016 at 5:29 PM, Susan Douglas wrote: > Hi All, > > I've attached a patch for the pgAdmin 4 documentation files. Let me know if > there are any problems! Thanks - committed as-is. Please note that the following errors/warnings are generated during compilation (some are new).

[pgadmin-hackers] pgAdmin 4 commit: More doc updates.

2016-06-08 Thread Dave Page
More doc updates. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7862cadad29e62b3e125bc052fa37bd62f43296 Author: Susan Douglas Modified Files -- docs/en_US/add_restore_point_dialog.rst| 20 docs/en_US/backup_glob

[pgadmin-hackers] pgAdmin 4 commit: Proper doc styling.

2016-06-08 Thread Dave Page
Proper doc styling. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=615882e1ee79e5d24679f52ced73452b783709b5 Modified Files -- docs/en_US/conf.py | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) -- Se

[pgadmin-hackers] pgAdmin 4 commit: Cleanup the Python requirements.

2016-06-08 Thread Dave Page
Cleanup the Python requirements. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9caf41054fb26c925047d0cb6a5faab9108b4c9 Modified Files -- requirements_py2.txt | 8 +--- requirements_py3.txt | 1 - 2 files changed, 1 insertion(+)

[pgadmin-hackers] [pgAdmin4][runtime]: Fix #1310 - Application icon missing from runtime

2016-06-08 Thread Neel Patel
Hi, Please find attached patch file for the fix of issue #1310. *Issue :- * Application icon is missing from runtime title bar when the exe is built on windows. *Solution:-* Qt5 :- Qt5 handle it automatically by adding RC_ICONS flag which contains the path of pgAdmin4.ico file to Qt project f

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-08 Thread Dave Page
On Wed, Jun 8, 2016 at 6:54 AM, Murtuza Zabuawala wrote: > Hi Dave, > > Can you please share steps to re-produce RM#1316, I’m not able to re-produce > it on my side. Please see Ashesh's response. > Meanwhile, PFA patch for RM#1315 :-) Thanks, pushed. -- Dave Page Blog: http://pgsnake.blogspot

[pgadmin-hackers] pgAdmin 4 commit: Fix styling of statistics table. Fixes #1315

2016-06-08 Thread Dave Page
Fix styling of statistics table. Fixes #1315 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=61037d4f602ceb19a726b7b2f3b36794125f61a0 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/overrides.css | 17 +++