[pgadmin-hackers] pgAdmin 4 commit: Auto complete is not based on psql.

2016-06-10 Thread Dave Page
Auto complete is not based on psql. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f5dde481c04325f67899222c3685b8791d013a4e Modified Files -- docs/en_US/query_tool.rst | 2 -- 1 file changed, 2 deletions(-) -- Sent via

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1327 After selecting the expiry date for role , the calendar box not disappearing

2016-06-10 Thread Dave Page
Thanks, applied. On Fri, Jun 10, 2016 at 8:03 AM, Surinder Kumar wrote: > Hi, > > Please find attached patch for this issue > set autoclose: true to vanish the datepicker after selecting date. > > Please review. > > > Thanks, > Surinder Kumar > > > -- > Sent via

[pgadmin-hackers] pgAdmin 4 commit: Auto-close the date picker when selecting a role expi

2016-06-10 Thread Dave Page
Auto-close the date picker when selecting a role expiry date. Fixes #1327 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c331b514a9a88d0cb1848802a349063008e3d56e Author: Surinder Kumar Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1324 - Grant wizard does not show privileges option again if Click on Back button on Privileges page

2016-06-10 Thread Dave Page
Thanks, applied. On Thu, Jun 9, 2016 at 1:52 PM, Surinder Kumar wrote: > Hi, > > Please find attached patch. > This issue was regression of commit id: > 47d7e24bb91f22da3b55c941f515ce76248f2cc6 > shouldn't have return statement in view object because it is called

[pgadmin-hackers] pgAdmin 4 commit: Fix re-display of privileges on the grant wizard if t

2016-06-10 Thread Dave Page
Fix re-display of privileges on the grant wizard if the back button is used. Fixes #1324 This issue was regression of commit id: 47d7e24bb91f22da3b55c941f515ce76248f2cc6 Shouldn't have return statement in view object because it is called by render of wizard object class to render the page in

Re: [pgadmin-hackers] [pgAdmin4[Patch]: RM#1319 - Unable to select sql file through query tool on windows operating system

2016-06-10 Thread Dave Page
Thanks, committed. On Thu, Jun 9, 2016 at 1:24 PM, Surinder Kumar wrote: > Hi, > > Please find attached patch with fixes: > 1) Unable to select sql file through query tool on windows OS. > In file_manager.js, we are stripping initial slash '/' from the path >

[pgadmin-hackers] pgAdmin 4 commit: Fix file selection on Windows. Fixes #1319

2016-06-10 Thread Dave Page
Fix file selection on Windows. Fixes #1319 1) Unable to select sql file through query tool on windows OS. In file_manager.js, we are stripping initial slash '/' from the path obtained, but we should not strip if it is full path like 'c:/path/to/dir/filename.ext' 2) Handle directory path if

[pgadmin-hackers] pgAdmin 4 commit: Add a menu option to reset the layout. Fixes #1248

2016-06-10 Thread Dave Page
Add a menu option to reset the layout. Fixes #1248 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9804ae2a21c00b2dfbb3c3ce5ac5a4e574c39fd Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] PATCH: Reset view/layout (pgAdmin4)

2016-06-10 Thread Dave Page
Thanks, applied. On Thu, Jun 9, 2016 at 8:47 AM, Murtuza Zabuawala wrote: > Hi, > > PFA updated patch, I have shifted it to File menu. > Please review. > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com >

[pgadmin-hackers] pgAdmin website commit: Move the "generic" download link up a level.

2016-06-10 Thread Dave Page
Move the "generic" download link up a level. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=d93a18e807a18a686dfcfc1b623b58a2d51d9b84 Modified Files -- download/index.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-10 Thread Dave Page
On Thu, Jun 9, 2016 at 9:21 AM, Murtuza Zabuawala wrote: > Hi Ashesh/Dave, > > I tried setting 'track_functions' to false in postgresql.conf. but then I am > not able to start server got error saying false is not correct argument > (Version: PG 9.5). > Then I

[pgadmin-hackers] pgAdmin 4 commit: More doc updates - query tool

2016-06-10 Thread Dave Page
More doc updates - query tool Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b84dc832a5f49a7f7367e27fa9bb0b8d33fef18 Author: Susan Douglas Modified Files --

Re: [pgadmin-hackers] Patch for pgAdmin 4 docs

2016-06-10 Thread Dave Page
Thanks, applied! On Thu, Jun 9, 2016 at 3:16 PM, Susan Douglas wrote: > Hi All, > > I've attached a patch for the pgAdmin 4 docs... Let me know if there are any > problems! > > Thanks! > > -- Susan > > -- Dave Page VP, Chief Architect, Tools & Installers

[pgadmin-hackers] pgAdmin 4 commit: Validate email addresses when creating the config DB.

2016-06-10 Thread Dave Page
Validate email addresses when creating the config DB. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6cfa022e350c9e9838d73ea18595a9e07681c3be Author: Harshal Dhumal Modified Files -- web/setup.py

Re: [pgadmin-hackers] Email validation in setup.py [pgadmin4]

2016-06-10 Thread Dave Page
Thanks, applied. On Thu, Jun 9, 2016 at 8:41 AM, Harshal Dhumal wrote: > Hi, > > PFA patch for email validation in setup.py > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > >

Re: [pgadmin-hackers] PATCH: TO fix issue in Role node (pgAdmin4)

2016-06-10 Thread Dave Page
Thanks - applied. On Thu, Jun 9, 2016 at 8:36 AM, Murtuza Zabuawala wrote: > Hi, > > Apologies, It was partial patch, missed JS side changes in last patch. > > Please review updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

[pgadmin-hackers] pgAdmin 4 commit: Fix role valid until date handling. Fixes #1107

2016-06-10 Thread Dave Page
Fix role valid until date handling. Fixes #1107 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fcd33162a980bdff66d43b0041700fc2fa19e16b Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Ensure the properties dialogues create objects in a s

2016-06-10 Thread Dave Page
Ensure the properties dialogues create objects in a single transaction/statement. Fixes #1107 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d5a91c969c4a3c5d76d8cd53120562f5afc80a87 Author: Sanket Mehta

[pgadmin-hackers] pgAdmin website commit: Further improvements to pip docs.

2016-06-10 Thread Dave Page
Further improvements to pip docs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=b8e7cb175aea3ecac832b65774ac1a16e39a6dd9 Modified Files -- download/pip4.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent

[pgadmin-hackers] pgAdmin website commit: Add some rough notes on how to use the PIP whee

2016-06-10 Thread Dave Page
Add some rough notes on how to use the PIP wheel. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=f56c5fdb51f3bf4f8171daafe36f84c7bd89f5cc Modified Files -- download/pip4.php | 6 ++ 1 file changed, 6 insertions(+) -- Sent

Re: [pgadmin-hackers] Pgadmin4: emoji in comments

2016-06-10 Thread Dave Page
OK. Let me ping Daniele and see if he's planning the release soon. On Fri, Jun 10, 2016 at 9:39 AM, Murtuza Zabuawala wrote: > No not right now, the milestone set is to 2.6.2 by the author for that bug > and pypi still has 2.6.1. > > > On 10-Jun-2016, at 2:01

Re: [pgadmin-hackers] Pgadmin4: emoji in comments

2016-06-10 Thread Murtuza Zabuawala
No not right now, the milestone set is to 2.6.2 by the author for that bug and pypi still has 2.6.1. > On 10-Jun-2016, at 2:01 pm, Dave Page wrote: > > Is the newer version of psycopg2 actually released? If so, this should be a > non-issue in a fresh venv right? > > -- >

Re: [pgadmin-hackers] Pgadmin4: emoji in comments

2016-06-10 Thread Dave Page
Is the newer version of psycopg2 actually released? If so, this should be a non-issue in a fresh venv right? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 10 Jun 2016, at 08:02, Murtuza

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1327 After selecting the expiry date for role , the calendar box not disappearing

2016-06-10 Thread Surinder Kumar
Hi, Please find attached patch for this issue set *autoclose: true* to vanish the datepicker after selecting date. Please review. Thanks, Surinder Kumar RM#1327.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your

Re: [pgadmin-hackers] Pgadmin4: emoji in comments

2016-06-10 Thread Murtuza Zabuawala
Hi, This seems to issue with psycopg2. ( https://github.com/psycopg/psycopg2/issues/331) To resolve this issue we have two solutions, *Solution-1* we can upgrade the psycopg2 module to newer version *Solution-2* Re-write of our 'qtLiteral' implementation which also accepts current connection