Re: [pgadmin-hackers] patch for issue RM1418 and RM1434 [pgadmin4]

2016-07-05 Thread Dave Page
Thanks, applied. On Tue, Jul 5, 2016 at 12:39 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for Issue RM1418 and RM1434 > > Issues fixed: 1. Select2 control fixed for multi-select mode. > 2. Index constrains (primary and unique key) fixed column listing issue. >

[pgadmin-hackers] pgAdmin 4 commit: Fix Select2 issues. Fixes #1418. Fixes #1434

2016-07-05 Thread Dave Page
Fix Select2 issues. Fixes #1418. Fixes #1434 1. Select2 control fixed for multi-select mode. 2. Index constrains (primary and unique key) fixed column listing issue. 3. Table node "inherited from" (Select2 control) was not showing table name with public schema Branch -- master Details

[pgadmin-hackers] patch for issue RM1418 and RM1434 [pgadmin4]

2016-07-05 Thread Harshal Dhumal
Hi, PFA patch for Issue RM1418 and RM1434 Issues fixed: 1. Select2 control fixed for multi-select mode. 2. Index constrains (primary and unique key) fixed column listing issue. 3. Table node "inherited from" (Select2 control) was not showing table name with public schema -- *Harshal Dhumal*

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1422 - "Move to last page" warning shown unnecessarily

2016-07-05 Thread Dave Page
Thanks, applied. On Tue, Jul 5, 2016 at 11:28 AM, Surinder Kumar wrote: > Hi > > Please find attached patch with fix. >> >> If last page attribute of collection is null, that means it is first page. >> This check is applied for add new row and paste row as well.

[pgadmin-hackers] pgAdmin 4 commit: Resolve "Move to last page" warning shown unnecessari

2016-07-05 Thread Dave Page
Resolve "Move to last page" warning shown unnecessarily issue. Fixes #1422 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c6660e576688ff6f2af426872b47f0d1cc93250 Author: Surinder Kumar Modified Files

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-07-05 Thread Dave Page
Hi On Mon, Jul 4, 2016 at 3:00 PM, Harshal Dhumal wrote: > Hi, > > PFA updated patch for RM1336 and keyboard shortcuts file separately. > > This patch is same as last patch except I have removed keyboard shortcut > list from this patch. > > Also please see my

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1422 - "Move to last page" warning shown unnecessarily

2016-07-05 Thread Surinder Kumar
Hi Please find attached patch with fix. > If last page attribute of collection is null, that means it is first page. > This check is applied for add new row and paste row as well. Please review. Thanks, Surinder Kumar RM#1422.patch Description: Binary data -- Sent via pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1423 - SQL panel should be greyed in Edit Data mode

2016-07-05 Thread Surinder Kumar
Hi Please find the attached patch with solution: 1. Introduced a new class 'cm_disabled' with css property background-color to '#E' 2. Query tool in edit mode, add the class 'cm_disabled' to set background color to dark and set the cursor property to 'nocursor' to disable

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-05 Thread Priyanka Shendge
Hi Dave, I tried running the testsuite against PG9.4 and unable to reproduce the failures. I have added debug statements to previous patch. Patch attached. Could you please re-run the same and send me the logs and output? Thank you. On 4 July 2016 at 17:30, Dave Page wrote:

Re: [pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

2016-07-05 Thread Harshal Dhumal
Hi, This patch has caused another new issue (or regression). Issue: Select2 control does not work in multi-select mode. Node affected due to this are Primary key, unique key, and all other node where we have used select2 control in multi-select mode. Commit id: