Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1397 - File upload not working in File Manager in pgAdmin4 Runtime

2016-08-04 Thread Dave Page
Thanks, applied. On Thu, Aug 4, 2016 at 1:59 PM, Surinder Kumar wrote: > Hi > > Issue: > When a file is uploaded via FileManager it gets storage directory path from > STORAGE_DIR config variable. but in case of pgAdmin4 Runtime it is set to > None, that means STORAGE_DIR path should be the root d

[pgadmin-hackers] pgAdmin 4 commit: Fix file upload in File Manager in pgAdmin4 Runtime.

2016-08-04 Thread Dave Page
Fix file upload in File Manager in pgAdmin4 Runtime. Fixes #1397 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a43f053a10327fae02c259ce0f791f8c57e9ec09 Author: Surinder Kumar Modified Files -- web/pgadmin/misc/file_manager/__init

Re: [pgadmin-hackers] [pgAdmin][Patch]: Fixed RM 1467

2016-08-04 Thread Dave Page
Thanks, applied. On Thu, Aug 4, 2016 at 12:21 PM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch for the fix of RM 1467: Unable to drop > trigger function, function and procedures. > > The issue was produced because of execute_2darray function change. > > Thanks, > Khushboo > > >

[pgadmin-hackers] pgAdmin 4 commit: Fix drop trigger function, function and procedures. F

2016-08-04 Thread Dave Page
Fix drop trigger function, function and procedures. Fixes #1467 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b00e94e904d80fd058801a5574faa5731963798f Author: Khushboo Vashi Modified Files -- .../servers/databases/schemas/functio

[pgadmin-hackers] [pgAdmin4][Patch]: RM1397 - File upload not working in File Manager in pgAdmin4 Runtime

2016-08-04 Thread Surinder Kumar
Hi *Issue:* When a file is uploaded via FileManager it gets storage directory path from STORAGE_DIR config variable. but in case of pgAdmin4 Runtime it is set to None, that means STORAGE_DIR path should be the root directory. The path formed to file was "None/filename.ext'. but it should be '/fil

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

2016-08-04 Thread Dave Page
On Thu, Aug 4, 2016 at 1:02 PM, Navnath Gadakh wrote: > Hi Dave, > > On Thu, Aug 4, 2016 at 4:04 PM, Dave Page > wrote: >> >> Hi >> >> On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh >> wrote: >> >> >> Oh - does the per-server config override the main config? That's >> >> useful. So anything tha

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

2016-08-04 Thread Navnath Gadakh
Hi Dave, On Thu, Aug 4, 2016 at 4:04 PM, Dave Page wrote: > Hi > > On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh > wrote: > > >> Oh - does the per-server config override the main config? That's > >> useful. So anything that's in test_advanced_config.py can be > >> overridden on a per-server b

Re: [pgadmin-hackers] Possible error in latest git pull

2016-08-04 Thread Colin Beckingham
Thanks Ashesh, all good now. On 04/08/16 07:15, Ashesh Vashi wrote: Dave upgraded the dependencies of flask_babel few days back. Did you run "pip upgrade -r requirements_pyX.txt"? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

[pgadmin-hackers] [pgAdmin][Patch]: Fixed RM 1467

2016-08-04 Thread Khushboo Vashi
Hi, Please find the attached patch for the fix of RM 1467: Unable to drop trigger function, function and procedures. The issue was produced because of execute_2darray function change. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py

Re: [pgadmin-hackers] Possible error in latest git pull

2016-08-04 Thread Ashesh Vashi
Dave upgraded the dependencies of flask_babel few days back. Did you run "pip upgrade -r requirements_pyX.txt"? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

Re: [pgadmin-hackers] [Patch][pgAdmin4]: RM1519 - Error running VACUUM FULL FREEZE ANALYZE VERBOSE

2016-08-04 Thread Dave Page
Thanks, applied. On Thu, Aug 4, 2016 at 10:59 AM, Surinder Kumar wrote: > Hi > > This issue is reproduced to me with following steps.: > 1) When the query "VACUUM FULL FREEZE ANALYZE VERBOSE" is run for first > time, it runs without error. > 2) then the query "SELECT 1" is executed. no error. > 3

[pgadmin-hackers] pgAdmin 4 commit: Fix error running VACUUM FULL FREEZE ANALYZE VERBOSE.

2016-08-04 Thread Dave Page
Fix error running VACUUM FULL FREEZE ANALYZE VERBOSE. Fixes #1519 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=42f8745abaebabd0bb78c84a26ff63a3f019127d Author: Surinder Kumar Modified Files -- web/pgadmin/tools/sqleditor/__init_

[pgadmin-hackers] Possible error in latest git pull

2016-08-04 Thread Colin Beckingham
Just did a git pull on pgadmin4 and on attempt to start the web interface I have a problem. App seems to start correctly and invites me to open my browser, but on attempt to log in I get a rotating wheel and this in the console. Quite possibly my error, on openSUSE Leap 42.1 fully patched: >

Re: [pgadmin-hackers] RM1492 [pgadmin4]

2016-08-04 Thread Dave Page
Thanks, applied. On Thu, Aug 4, 2016 at 10:52 AM, Harshal Dhumal wrote: > Hi, > > PFA patch for RM1492 > > Issue fixed: Generate proper queries for "View all/first 100/last 100 rows" > with table containing columns with capital letters. > > > -- > Harshal Dhumal > Software Engineer > > Enterprise

[pgadmin-hackers] pgAdmin 4 commit: Fix View Data options for tables with columns that ne

2016-08-04 Thread Dave Page
Fix View Data options for tables with columns that need quoting. Fixes #1492 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb35c46f03222693e145f35a97a1dca63f7f9ed5 Author: Harshal Dhumal Modified Files -- web/pgadmin/tools/sqledi

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

2016-08-04 Thread Dave Page
Hi On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh wrote: >> Oh - does the per-server config override the main config? That's >> useful. So anything that's in test_advanced_config.py can be >> overridden on a per-server basis in test_config.py? > > No. > per-server i.e advance config(tes

Re: [pgadmin-hackers] PATCH: To handle numeric type display (pgAdmin4)

2016-08-04 Thread Dave Page
Thanks, applied. On Thu, Aug 4, 2016 at 7:59 AM, Murtuza Zabuawala wrote: > Hi, > > Please find minor patch to handle numeric/float type display. > RM#1463 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via p

[pgadmin-hackers] pgAdmin 4 commit: Fix display of numerics in the query tool. Fixes #146

2016-08-04 Thread Dave Page
Fix display of numerics in the query tool. Fixes #1463 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c433fbfcee045351457ea4722b582ffacb39b8f Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqleditor/templates/sqled

[pgadmin-hackers] [Patch][pgAdmin4]: RM1519 - Error running VACUUM FULL FREEZE ANALYZE VERBOSE

2016-08-04 Thread Surinder Kumar
Hi This issue is reproduced to me with following steps.: 1) When the query "VACUUM FULL FREEZE ANALYZE VERBOSE" is run for first time, it runs without error. 2) then the query "SELECT 1" is executed. no error. 3) But when query in step #1 is run again, it throws an error: *TypeError: cannot concat

[pgadmin-hackers] RM1492 [pgadmin4]

2016-08-04 Thread Harshal Dhumal
Hi, PFA patch for RM1492 Issue fixed: Generate proper queries for "View all/first 100/last 100 rows" with table containing columns with capital letters. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/p

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

2016-08-04 Thread Navnath Gadakh
Hi Dave, On Wed, Aug 3, 2016 at 8:32 PM, Dave Page wrote: > On Wed, Aug 3, 2016 at 2:01 PM, Navnath Gadakh > wrote: > > Hi Dave, > > Thanks for clarification. > > > > On Wed, Aug 3, 2016 at 2:45 PM, Dave Page > > wrote: > >> > >> Hi Navnath > >> > >> On Tue, Aug 2, 2016 at 3:58 PM, Navnat

[pgadmin-hackers] PATCH: To handle numeric type display (pgAdmin4)

2016-08-04 Thread Murtuza Zabuawala
Hi, Please find minor patch to handle numeric/float type display. RM#1463 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1463.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)