[pgadmin-hackers] [pgAdmin4][Patch]: SqlFieldControl enhancements

2016-08-22 Thread Surinder Kumar
Hi Following are the enhancements: 1) Disable cursor mode if editor is disabled. if cursor is enabled. on pressing keys, a false event is generated and on validating models it causes Save button to enable. 2) If editor is disabled, set dark background colour. 3) CodeMirror corners seems to cut aro

[pgadmin-hackers] pgAdmin 4 commit: Cleanup old code in server_groups.js. Fixes #1247

2016-08-22 Thread Ashesh Vashi
Cleanup old code in server_groups.js. Fixes #1247 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6775adc4c750181ec1defbd2522daac40e784ccd Modified Files -- .../templates/server_groups/server_groups.js | 86 ---

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

2016-08-22 Thread Dave Page
Thanks, applied. On Mon, Aug 22, 2016 at 3:23 PM, Harshal Dhumal wrote: > Hi Dave, > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Aug 22, 2016 at 5:45 PM, Dave Page wrote: >> >> Hi >> >> On Mon, Aug

[pgadmin-hackers] pgAdmin 4 commit: Fix parsing issue in packages.

2016-08-22 Thread Dave Page
Fix parsing issue in packages. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=58a79e4fc63350717c25b70ff3cd3c68306616d8 Author: Harshal Dhumal Modified Files -- .../servers/databases/schemas/packages/__init__.py | 20 +++-

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

2016-08-22 Thread Harshal Dhumal
Hi Dave, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Aug 22, 2016 at 5:45 PM, Dave Page wrote: > Hi > > On Mon, Aug 22, 2016 at 1:04 PM, Harshal Dhumal > wrote: > > Hi, > > PFA patch for wrong header and bo

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

2016-08-22 Thread Dave Page
Hi On Mon, Aug 22, 2016 at 1:04 PM, Harshal Dhumal wrote: > Hi, > PFA patch for wrong header and body were generated. > > Fixed the header and body sql parsing issue. Won't this break if I have a package called issues.foo or anything else that matches the ' is' or ' as'? -- Dave Page Blog: htt

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

2016-08-22 Thread Harshal Dhumal
Hi, PFA patch for wrong header and body were generated. Fixed the header and body sql parsing issue. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Aug 22, 2016 at 5:10 PM, Khushboo Vashi < khushboo.va...@enterp

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

2016-08-22 Thread Khushboo Vashi
On Mon, Aug 22, 2016 at 3:10 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for packages > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Aug 18, 2016 at 12:

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

2016-08-22 Thread Dave Page
Thanks - applied with some minor tweaks to groupings. On Mon, Aug 22, 2016 at 10:40 AM, Harshal Dhumal wrote: > Hi, > > PFA updated patch for packages > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Au

[pgadmin-hackers] pgAdmin 4 commit: Add support for Packages on EPAS.

2016-08-22 Thread Dave Page
Add support for Packages on EPAS. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf1be2a32040d6978ad6d9b20f63accaf6ba4a9d Author: Harshal Dhumal Modified Files -- .../js/catalog_object_column.js| 1 + .../temp

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option

2016-08-22 Thread Dave Page
Thanks, applied. On Fri, Aug 19, 2016 at 10:14 PM, Surinder Kumar wrote: > On Sat, Aug 20, 2016 at 1:39 AM, Dave Page wrote: >> >> Hi >> >> That's not a reliable check - you can just as easily use postgres as the >> maintenance db on epas. > > Yes, somehow i missed it. >> >> >> Why don't we just

[pgadmin-hackers] pgAdmin 4 commit: Don't offer to create resource groups on disconnected

2016-08-22 Thread Dave Page
Don't offer to create resource groups on disconnected servers. Fixes #1569 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe54a124da91bc3240520c4521a89be6100347de Author: Surinder Kumar Modified Files -- web/pgadmin/browser/server

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1251 - Tab complete for combo boxes

2016-08-22 Thread Dave Page
Thanks, applied. On Mon, Aug 22, 2016 at 8:40 AM, Surinder Kumar wrote: > Hi > > In previous patch, the support to "select highlighted option in Select2 > control on TAB press" was for Backform Select2Control. > Now the same is added for Backgrid Select2Cell as well in v1 patch. > > Thanks to Har

[pgadmin-hackers] pgAdmin 4 commit: Allow the use of the tab key to select options in com

2016-08-22 Thread Dave Page
Allow the use of the tab key to select options in combo boxes. Fixes #1251 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4c2020cdc7c38b07d6db6be19bd9371d93083f62 Author: Surinder Kumar Modified Files -- .../tables/column/template

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1251 - Tab complete for combo boxes

2016-08-22 Thread Surinder Kumar
Hi In previous patch, the support to "select highlighted option in Select2 control on TAB press" was for *Backform Select2Control*. Now the same is added for *Backgrid Select2Cell* as well in v1 patch. Thanks to Harshal for helping me in resolving one issue. Please find updated patch and review.