[pgadmin-hackers] Server specific advanced config file for testsuite

2016-09-12 Thread Navnath Gadakh
Hi Dave, As we know that, we are using two JSON files one is for basic configuration of server(test_config.json) and second for detailed configuration of server(test_advanced_config.json). In test_advanced_config.json, we give detail for database, schema, extension, collation etc. These detail

[pgadmin-hackers] pgAdmin 4 commit: Fix function signature generation. Fixes #1683

2016-09-12 Thread Dave Page
Fix function signature generation. Fixes #1683 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f2ed6fa4dd88a5941680bb369ebdd4ff80024fa7 Author: Surinder Kumar Modified Files -- .../databases/schemas/functions/__init__.py| 2

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters

2016-09-12 Thread Dave Page
Thanks, applied. On Mon, Sep 12, 2016 at 11:57 AM, Surinder Kumar wrote: > Hi > > I forgot to remove a line args_without_name += ', ' from the code in > previous patch, thus it adds extra commas into the function arguments in > case of procedures only. > It is now fixed. > Please find updated v2

Re: [pgadmin-hackers] importlib dependency?

2016-09-12 Thread Dave Page
Hi On Mon, Sep 12, 2016 at 2:50 PM, Devrim Gündüz wrote: > > Hi, > > python-importlib is mentioned in requirements_py2.txt, but not > in requirements_py3.txt. Is that expected? Do we need importlib only in PY2? Yes. The functionality is built into Python 3 (and I think 2.7 as well, but not earli

[pgadmin-hackers] importlib dependency?

2016-09-12 Thread Devrim Gündüz
Hi, python-importlib is mentioned in requirements_py2.txt, but not in requirements_py3.txt. Is that expected? Do we need importlib only in PY2? (I'm tired of building the dependency hell...) Thanks! Regards, -- Devrim GÜNDÜZ EnterpriseDB: http://www.enterprisedb.com PostgreSQL Danışmanı/Consul

Re: [pgadmin-hackers] PATCH: To fix the issue where user cannot view long data in Query Tool output (pgAdmin4)

2016-09-12 Thread Dave Page
Thanks, applied. On Mon, Sep 12, 2016 at 11:54 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where user was not able to view long data in the > data grid. > To fix the issue we have added Readonly editors in the grid to view data. > RM#1672, RM#1668 > > > -- > Regards, > Mur

[pgadmin-hackers] pgAdmin 4 commit: Allow viewing of long data values in the grid. Fixes

2016-09-12 Thread Dave Page
Allow viewing of long data values in the grid. Fixes #1672 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ffc58b74d25cca156fe6014ad5e8385651da4181 Author: Murtuza Zabuawala Modified Files -- .../static/js/slickgrid/slick.pgadmin.e

Re: [pgadmin-hackers] Startup error on RHEL 7

2016-09-12 Thread Devrim Gündüz
Hi Dave, On Mon, 2016-09-12 at 12:07 +0100, Dave Page wrote: > > I don't have config_distro.py > > Please move those two lines into config_distro.py - that's intended > for distro-specific configuration, whilst config_loca.py is for > user-specific. Done. Cheers, -- Devrim GÜNDÜZ EnterpriseDB

Re: [pgadmin-hackers] Startup error on RHEL 7

2016-09-12 Thread Dave Page
On Mon, Sep 12, 2016 at 11:53 AM, Devrim Gündüz wrote: > > Hi Dave, > > On Mon, 2016-09-12 at 13:50 +0300, Devrim Gündüz wrote: > >> > - What version of Babel? >> >> python-babel-0.9.6 > > Argh. Upgrading it to 1.3 fixed the issue. Sorry for the noise. :-) -- Dave Page Blog: http://pgsnake.blog

Re: [pgadmin-hackers] Startup error on RHEL 7

2016-09-12 Thread Dave Page
On Mon, Sep 12, 2016 at 11:50 AM, Devrim Gündüz wrote: > > Hi Dave, > > On Mon, 2016-09-12 at 10:05 +0100, Dave Page wrote: > >> Hmm, not sure. Questions: >> >> - What version of Babel? > > python-babel-0.9.6 That's really old - I have 2.3.4. >> - I assume (hope) you haven't changed config.py, b

[pgadmin-hackers] Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters

2016-09-12 Thread Surinder Kumar
Hi I forgot to remove a line args_without_name += ', ' from the code in previous patch, thus it adds extra commas into the function arguments in case of procedures only. It is now fixed. Please find updated v2 patch and review. On Mon, Sep 12, 2016 at 3:54 PM, Surinder Kumar < surinder.ku...@ent

[pgadmin-hackers] PATCH: To fix the issue where user cannot view long data in Query Tool output (pgAdmin4)

2016-09-12 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where user was not able to view long data in the data grid. To fix the issue we have added Readonly editors in the grid to view data. RM#1672, RM#1668 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --g

Re: [pgadmin-hackers] Startup error on RHEL 7

2016-09-12 Thread Devrim Gündüz
Hi Dave, On Mon, 2016-09-12 at 13:50 +0300, Devrim Gündüz wrote:   > > - What version of Babel? > > python-babel-0.9.6 Argh. Upgrading it to 1.3 fixed the issue. Sorry for the noise. Cheers, -- Devrim GÜNDÜZ EnterpriseDB: http://www.enterprisedb.com PostgreSQL Danışmanı/Consultant, Red Hat Ce

Re: [pgadmin-hackers] Startup error on RHEL 7

2016-09-12 Thread Devrim Gündüz
Hi Dave, On Mon, 2016-09-12 at 10:05 +0100, Dave Page wrote: > Hmm, not sure. Questions: > > - What version of Babel? python-babel-0.9.6 > - I assume (hope) you haven't changed config.py, but what's in > config_distro.py and config_local.py? $ cat /usr/lib/python2.7/site-packages/pgadmin4-we

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

2016-09-12 Thread Dave Page
On Mon, Sep 12, 2016 at 11:42 AM, Devrim Gündüz wrote: > > Hi Dave, > > On Mon, 2016-09-12 at 09:56 +0100, Dave Page wrote: >> > Any chance to add .desktop file to git, like we did for pgadmin3? >> >> Sure - I'd want to put it alongside the spec file. Have you written one? > > Just committed my ve

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

2016-09-12 Thread Devrim Gündüz
Hi Dave, On Mon, 2016-09-12 at 09:56 +0100, Dave Page wrote: > > Any chance to add .desktop file to git, like we did for pgadmin3? > > Sure - I'd want to put it alongside the spec file. Have you written one? Just committed my version to pgrpms git: https://git.postgresql.org/gitweb/?p=pgrpms.g

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog

2016-09-12 Thread Dave Page
Thanks, applied. On Mon, Sep 12, 2016 at 6:12 AM, Surinder Kumar wrote: > Hi > > Please find attached with following fixes: > > 1) The function 'canCreateProc' that checks if package is auth to create > under catalog gets failed due to improper check of 'type'. Instead check > should be like > no

[pgadmin-hackers] pgAdmin 4 commit: Prevent creation of packages and rules in catalogs. F

2016-09-12 Thread Dave Page
Prevent creation of packages and rules in catalogs. Fixes #1682 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28b7a033bc888cd0ea21dbe3fc9471b2ab36110d Author: Surinder Kumar Modified Files -- .../functions/templates/procedure/js/

[pgadmin-hackers] Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters

2016-09-12 Thread Surinder Kumar
This patch doesn't fix the issue in Procedure node. I will send updated patch. On Mon, Sep 12, 2016 at 3:12 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Please find attached patch with fix. > *Changes:* > 1) Take a list of "function argument types", create a string separ

[pgadmin-hackers] [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters

2016-09-12 Thread Surinder Kumar
Hi, Please find attached patch with fix. *Changes:* 1) Take a list of "function argument types", create a string separated by comma(removing trailing comma). 2) Function arguments in ALTER and GRANT not necessarily to have *argument mode, name, *they are optional. Only type is required. Now GRANT

Re: [pgadmin-hackers] Startup error on RHEL 7

2016-09-12 Thread Dave Page
On Sun, Sep 11, 2016 at 9:33 AM, Devrim Gündüz wrote: > > Hi, > > Just saw this on my RHEL 7 test box. This is pgadmin4 1.0rc1, Python 2.7, > python-flask-babel-0.11.1: > > # /usr/bin/python2 /usr/lib/python2.7/site-packages/pgadmin4-web/pgAdmin4.py > Traceback (most recent call last): > File "/

Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work

2016-09-12 Thread Dave Page
On Sun, Sep 11, 2016 at 10:01 AM, Devrim Gündüz wrote: > > Hi, > > On Fri, 2016-09-09 at 11:26 +0100, Dave Page wrote: > >> For users to run in desktop mode, nothing else should be required, >> except possibly a shortcut to the runtime executable. > > Any chance to add .desktop file to git, like w

Re: [pgadmin-hackers] python-click dependency

2016-09-12 Thread Dave Page
Ah, OK - added to requirements. On Sun, Sep 11, 2016 at 10:27 AM, Ashesh Vashi wrote: > It was added by new flask depndency. > > > On Sep 11, 2016 14:49, "Dave Page" wrote: >> >> I've never even heard of python-click before! >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter:

[pgadmin-hackers] pgAdmin 4 commit: Add click as a python requirement.

2016-09-12 Thread Dave Page
Add click as a python requirement. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=70ea03a87259515f47e23b44c5998305aa0e8d64 Modified Files -- requirements_py2.txt | 1 + requirements_py3.txt | 1 + 2 files changed, 2 insertions(+) -