Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

2016-10-20 Thread Khushboo Vashi
Hi, Please find the attached patch to fix below RMs: 1603: [Web Based] Export database failed if object contains double quotes 1220: Backup database is not working with special characters 1221: Maintenance DB failed if database name contains special characters In Desktop mode, the import/expo

[pgadmin-hackers] patch for RM1863 [pgadmin4]

2016-10-20 Thread Harshal Dhumal
Hi, PFA patch for RM1863. Issue fixed: Correctly interpret composite data type for columns while generating sql. also minor UI improvement in foreign key column tab -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

2016-10-20 Thread Dave Page
On Thu, Oct 20, 2016 at 12:08 PM, Ashesh Vashi wrote: > On Thu, Oct 20, 2016 at 4:26 PM, Khushboo Vashi > wrote: >> >> >> >> On Sat, Oct 15, 2016 at 11:52 AM, Dave Page wrote: >>> >>> >>> >>> On Friday, October 14, 2016, Ashesh Vashi >>> wrote: On Sat, Oct 15, 2016 at 4:59 AM, Dave Pa

[pgadmin-hackers] [pgAdmin4][Patch]: RM1822 - 'ascii' codec can't decode byte

2016-10-20 Thread Surinder Kumar
Hi I am able to reproduce the issue by changing server username to "Суриндер" in russian locale. Steps: 1) Rename server username to "Суриндер" by editing server properties. 2) Double click on sever. Enter password in Prompt dialog. 3) Click OK. Now It will throw "UnicodeDecode Error". I have dec

[pgadmin-hackers] pgAdmin 4 commit: Fixed issue where some parameter like 'Volatility, Le

2016-10-20 Thread Akshay Joshi
Fixed issue where some parameter like 'Volatility, LeakProof , Variables etc..' not visible in SQL definition for functions and trigger functions. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76fb8315540fbdf27d899898e25589f6130cf0c6 Modifie

Re: [pgadmin-hackers] pgAdmin 4 commit: Fixes #1843 Function definition does not match value

2016-10-20 Thread Dave Page
I'm pretty sure I wrote that patch, not Dan :-p On Thu, Oct 20, 2016 at 6:00 AM, Akshay Joshi wrote: > Fixes #1843 Function definition does not match value returned from > pg_get_functiondef() > > Branch > -- > master > > Details > --- > http://git.postgresql.org/gitweb?p=pgadmin4.git;a=

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1843 Function definition does not match value

2016-10-20 Thread Akshay Joshi
Fixes #1843 Function definition does not match value returned from pg_get_functiondef() Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c5d81b6f5c1579c1a2b486adca5cdb8c2daaca8 Author: Dan Vianello Modified Files -- .../schemas/fu

[pgadmin-hackers] [pgAdmin4][Patch]: RM1858 - File Manager does not honour the file type while traversing the directories

2016-10-20 Thread Surinder Kumar
Hi, When a File Manager is closed by clicking cancel button. Its dom element not destroyed.. So on traversing into directories, when it tries to get currently selected file type, it looks into the dom element but it gets dom of previous dialogs not of currently dialog. Now whenever an instance of

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

2016-10-20 Thread Ashesh Vashi
On Thu, Oct 20, 2016 at 4:26 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Sat, Oct 15, 2016 at 11:52 AM, Dave Page wrote: > >> >> >> On Friday, October 14, 2016, Ashesh Vashi >> wrote: >> >>> On Sat, Oct 15, 2016 at 4:59 AM, Dave Page wrote: >>> Hi On Fri

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

2016-10-20 Thread Khushboo Vashi
On Sat, Oct 15, 2016 at 11:52 AM, Dave Page wrote: > > > On Friday, October 14, 2016, Ashesh Vashi > wrote: > >> On Sat, Oct 15, 2016 at 4:59 AM, Dave Page wrote: >> >>> Hi >>> >>> On Friday, October 14, 2016, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi, P

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-20 Thread Fahar Abbas
All, I have not seen any issue in pgAdmin4 on MAC OS X(Python 3.5) Platform as well hence 1849 is resolved. Kind Regards, On Thu, Oct 20, 2016 at 1:35 PM, Fahar Abbas wrote: > Thanks pgAdmin4 Development team! > > User can launch pgAdmin4 with web browser with no issues with fresh setup, > i t

[pgadmin-hackers] [pgAdmin4][Patch]: RM 1574 - sql is not displayed in SQL pane for security label in both PG and EPAS/PPAS server

2016-10-20 Thread Surinder Kumar
Hi, Code to parse security privileges was missing. So, its sql wasn't displayed. Please find attached patch and review. Thanks, Surinder Kumar RM1574.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:

[pgadmin-hackers] [pgAdmin4][Patch]: RM1872 - Not able to open the File Manager

2016-10-20 Thread Surinder Kumar
Hi *Issues fixed:* 1) In Python 3, parameter "*cmp*" is removed from *sorted* method. So File Manager won't open. As we are sorting data on JS side using Natural sort, so on server side sorting is not required. 2) Improvement in Exception handling. Please find attached patch and review. Thank

[pgadmin-hackers] PATCH: To display Security Label control properly in procedure node(pgAdmin4)

2016-10-20 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where behaviour of security label control was different when in CREATE mode & in EDIT mode. RM#1576 *issue:* Corrected the condition for node type checking. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Comp

Re: [pgadmin-hackers] Language node patch

2016-10-20 Thread Navnath Gadakh
Hi Dave, Please find revised patch for languages API test cases. Resolved some PG9.6 compatibility issues. Thanks. On Tue, Oct 18, 2016 at 7:08 PM, Dave Page wrote: > Thanks, applied. > > On Tue, Oct 18, 2016 at 1:48 PM, Priyanka Shendge > wrote: > > Hi Dave, > > > > PFA patch for Langu

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-20 Thread Fahar Abbas
Thanks pgAdmin4 Development team! User can launch pgAdmin4 with web browser with no issues with fresh setup, i tried on Ubuntu 16.04 Linux 64(Python 3.5). Will also try on OS X with Python 3 and will let you know. On Thu, Oct 20, 2016 at 1:03 PM, Fahar Abbas wrote: > Thanks Ashesh for your step

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-10-20 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch for the same. *Issue:* We were not properly fetching result from server in case of direct debugging when we restart debugging of same object. Thanks to Neel for helping in this issue. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-20 Thread Fahar Abbas
Thanks Ashesh for your steps and will also test with new setup( on fresh machine) and our customers can face this problem with new setup and will update the status accordingly. On Thu, Oct 20, 2016 at 12:53 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > You were missing the other plac

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-20 Thread Ashesh Vashi
You were missing the other places, before the function - do_setup(..) call, where we are generating the other keys automatically. I've checked-in the code. Fahar, If you want to test the issue properly, please follow the below steps: - git checkout c4f1b8eb112e99d228c40a412020fa616dbe44f6 This

[pgadmin-hackers] pgAdmin 4 commit: Ensure the auto-generated CSRF_SESSION_KEY, SECRET_KE

2016-10-20 Thread Ashesh Vashi
Ensure the auto-generated CSRF_SESSION_KEY, SECRET_KEY, SECURITY_PASSWORD_SALT keys are decoded as string for python 3 compatibility. Fixes #1871 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4c439d64ae9ba638cb7698a7dd8340b9a0a5857 Modified

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-20 Thread Ashesh Vashi
On Thu, Oct 20, 2016 at 1:00 PM, Fahar Abbas wrote: > Murtaza, > > Once i delete key table from pgAdmin4.db file then i can launch pgAdmin4 > with terminal as well as web browser for existing pgAdmin4 setup. > > > In case of fresh setup once we delete key table and apply latest patch > following

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-20 Thread Fahar Abbas
Murtaza, Once i delete key table from pgAdmin4.db file then i can launch pgAdmin4 with terminal as well as web browser for existing pgAdmin4 setup. In case of fresh setup once we delete key table and apply latest patch following message displayed: python pgAdmin4.py Traceback (most recent call