[pgadmin-hackers] PATCH: To fix the issue where trigger function was not schema qualified in trigger SQL (pgAdmin4)

2016-11-10 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where trigger function was not schema qualified in trigger SQL. RM#1949 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1949.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pga

Re: [pgadmin-hackers] [pgadmin-support] Final pgAdmin III - v1.22.2 Released

2016-11-10 Thread Dave Page
Oops, sorry - that shouldn't have been listed. It wasn't included as it's a new feature and hasn't had any QA. On Thu, Nov 10, 2016 at 4:28 PM, Adam Brusselback wrote: > Regarding: 2016-02-16 DP 1.24.0 Allow multiple SQL editor tabs to be used > in the query tool [Sergey Busel] > > I am not see

Re: [pgadmin-hackers] [pgadmin-support] Final pgAdmin III - v1.22.2 Released

2016-11-10 Thread Adam Brusselback
Regarding: 2016-02-16 DP 1.24.0 Allow multiple SQL editor tabs to be used in the query tool [Sergey Busel] I am not seeing that change in this release. I see the commit on master, but I don't see the changes in the source download for this release tag. Was very much looking forward to having th

[pgadmin-hackers] Final pgAdmin III - v1.22.2 Released

2016-11-10 Thread Dave Page
I've just pushed a final wrap-up build of pgAdmin III to the download site in source, Windows and Mac OS X formats. You can download it from here: https://www.postgresql.org/ftp/pgadmin3/release/v1.22.2/ This will be the final official release of pgAdmin III, produced as a result of a number of r

[pgadmin-hackers] pgAdmin III commit: Tag REL-1_22_2 has been created.

2016-11-10 Thread Dave Page
Tag REL-1_22_2 has been created. View: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=tag;h=refs/tags/REL-1_22_2 Log Message --- Tag 1.22.2, "The Final Chapter" -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.p

[pgadmin-hackers] pgAdmin III commit: Don't show an error on PG 9.6.

2016-11-10 Thread Dave Page
Don't show an error on PG 9.6. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=216f52a5135db3124268a32c553b812547d4b918 Modified Files -- pgadmin/include/pgAdmin3.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent

[pgadmin-hackers] pgAdmin III commit: Bump version

2016-11-10 Thread Dave Page
Bump version Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=63077d9a0e1896f7c2738a910802924638d5d342 Modified Files -- pgadmin/include/version.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via

[pgadmin-hackers] pgAdmin III commit: Don't show an error on PG 9.6.

2016-11-10 Thread Dave Page
Don't show an error on PG 9.6. Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b492f77aa10fe8404fb82024d98fee4af104dc5e Modified Files -- pgadmin/include/pgAdmin3.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

Re: [pgadmin-hackers] QtWebEngine issue

2016-11-10 Thread Neel Patel
Hi, As I am not able to reproduce so i can not do experiment but from Qt documentation, we can try setting below attribute at beginning in pgAdmin4.cpp file before application start ? QCoreApplication::setAttribute(Qt::AA_UseDesktopOpenGL); OR QCoreApplication::setAttribute(Qt::AA_UseOpenGLES);

[pgadmin-hackers] pgAdmin III commit: Fx an issue with funtions on Greenplum

2016-11-10 Thread Dave Page
Fx an issue with funtions on Greenplum Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8e87373dd4554a9f6ef1712fa7622e492ff68796 Author: Andreas 'ads' Scherbaum Modified Files -- pgadmin/schema/pgFunction.cpp | 43 ++

[pgadmin-hackers] pgAdmin III commit: Add classid filter to queries on pg_depend

2016-11-10 Thread Dave Page
Add classid filter to queries on pg_depend There are a number of cases where queries in both pgadmin4 and pgadmin3 are done against pg_depend but falis to constrain the query on classid. In particular, if for example a constraint and a sequence exists with the same oid (which is perfectly valid,

Re: [pgadmin-hackers] QtWebEngine issue

2016-11-10 Thread Dave Page
Hi On Thu, Nov 10, 2016 at 1:28 PM, Neel Patel wrote: > Hi Dave, > > I have tried to reproduce the issues ( crash & black screen) with > QtWebEngine but no luck. > Tried with Windows 7 & Windows 10 with both Qt 5.5 & 5.7. > > I think below links confirm that it is known issue in Qt. > > https://b

Re: [pgadmin-hackers] QtWebEngine issue

2016-11-10 Thread Neel Patel
Hi Dave, I have tried to reproduce the issues ( crash & black screen) with QtWebEngine but no luck. Tried with Windows 7 & Windows 10 with both Qt 5.5 & 5.7. I think below links confirm that it is known issue in Qt. https://bugreports.qt.io/browse/QTBUG-34964

Re: [pgadmin-hackers] PATCH: arguments of Trigger function was not displaying properly (pgAdmin4)

2016-11-10 Thread Navnath Gadakh
Thanks Dave. On Thu, Nov 10, 2016 at 6:19 PM, Dave Page wrote: > Thanks Navnath. Excellent to see you fixing the bugs you find during > QA - that's very helpful. Patch applied. > > On Thu, Nov 10, 2016 at 10:13 AM, Navnath Gadakh > wrote: > > Hi Dave, > > > > While testing I faced TypeError in

Re: [pgadmin-hackers] PATCH: arguments of Trigger function was not displaying properly (pgAdmin4)

2016-11-10 Thread Dave Page
Thanks Navnath. Excellent to see you fixing the bugs you find during QA - that's very helpful. Patch applied. On Thu, Nov 10, 2016 at 10:13 AM, Navnath Gadakh wrote: > Hi Dave, > > While testing I faced TypeError in the triggers (for more details refer > RM#1912). It was small code change I have

[pgadmin-hackers] pgAdmin 4 commit: Fix TypeError.

2016-11-10 Thread Dave Page
Fix TypeError. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7b574b284dfcfaad6c8e3f5b87ddfc32540f8391 Author: Navnath Gadakh Modified Files -- .../server_groups/servers/databases/schemas/tables/triggers/__init__.py | 2 +- 1 file

Re: [pgadmin-hackers] flask-login 0.4.0 has changed functions

2016-11-10 Thread Dave Page
Hi On Thu, Nov 10, 2016 at 10:15 AM, Bruno Friedmann wrote: > With version 0.4.0 installed ( system wide ) > > Traceback (most recent call last): > File "web/pgAdmin4.py", line 46, in > app = create_app() > File "/ioda/home/bruno/git/pgadmin4/web/pgadmin/__init__.py", line 247, in > crea

[pgadmin-hackers] flask-login 0.4.0 has changed functions

2016-11-10 Thread Bruno Friedmann
With version 0.4.0 installed ( system wide ) Traceback (most recent call last): File "web/pgAdmin4.py", line 46, in app = create_app() File "/ioda/home/bruno/git/pgadmin4/web/pgadmin/__init__.py", line 247, in create_app security.init_app(app) File "/usr/lib/python3.5/site-packages

Re: [pgadmin-hackers] PATCH: arguments of Trigger function was not displaying properly (pgAdmin4)

2016-11-10 Thread Navnath Gadakh
Hi Dave, While testing I faced TypeError in the triggers (for more details refer RM#1912). It was small code change I have resolved it. Please find the patch. Thanks. On Wed, Nov 9, 2016 at 8:30 PM, Dave Page wrote: > On Fri, Nov 4, 2016 at 12:51 PM, Murtuza Zabuawala > wrote: > > Hi, > > > >

Re: [pgadmin-hackers] QtWebEngine issue

2016-11-10 Thread Dave Page
On Thu, Nov 10, 2016 at 8:22 AM, Neel Patel wrote: > Hi, > > That means it is an issue with OpenGL drivers and Qt Webengine ? Sounds like it may be. I think any info we can compile should be added to that bug report you found though. > Do we need to compile Qt with Desktop OpenGL which do not ca

Re: [pgadmin-hackers] QtWebEngine issue

2016-11-10 Thread Neel Patel
Hi, That means it is an issue with OpenGL drivers and Qt Webengine ? Do we need to compile Qt with Desktop OpenGL which do not call OpenGL ES 2.0 API OR may be ANGLE ? Thanks, Neel Patel On Wed, Nov 9, 2016 at 10:05 PM, Dave Page wrote: > Incidentally, turning off accelerated graphics in VMwar