Re: [pgadmin-hackers][patch] RM2163 emboldened syntax highlighting

2017-02-08 Thread Murtuza Zabuawala
Hi, It's not a good idea to directly change in main Library, Lets say if newer version of CodeMirror available and we want to pull new version then we need to maintain this change set every time we pull new version. Instead please use, - web/pgadmin/static/css/overrides.css or more specific

Re: [pgadmin-hackers][patch] We can see tables in Greenplum!

2017-02-08 Thread Murtuza Zabuawala
Hello, Regarding test output, *Comment Style-1:* If we comment like """Test Case is used for... """ *Result:* runTest (pgadmin.xxx) *Test case to verify server group (Get server list) ... ok* *Comment Style-2: *If we comment like """ Test Case is used for """ *Result:* runTest run

[pgadmin-hackers][patch] RM2163 emboldened syntax highlighting

2017-02-08 Thread Atira Odhner
Hello Hackers We have made syntax highlighting more visible! -Tira & George commit 44207d83b0e28e1a2c474a35284ea21f7f4a197e Author: George Gelashvili and Tira Odhner Date: Wed Feb 8 17:51:00 2017 -0500 [PATCH] embolden syntax highlighting [RM2163] diff --git a/web/pgadmin/static/css/code

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-02-08 Thread Atira Odhner
Hey Dave, We re-used one of the test helpers for the 'fix-greenplum-show-tables.diff' patch, so here is an updated patch which does not include adding that test helper in case you apply the show-tables patch first. Also, we saw some strange test behavior yesterday where form fields weren't being f

Re: [pgadmin-hackers][patch] change --pkg behavior

2017-02-08 Thread Atira Odhner
Here is the additional patch to exclude one or more packages. On Tue, Feb 7, 2017 at 6:02 PM, George Gelashvili wrote: > Hello Hackers, > > To chase down a set of tests that were failing together, we wanted to run > deeper trees of tests. We changed the behavior of the --pkg argument to > runtes

[pgadmin-hackers] pgAdmin 4 commit: Spit out an exit code when running the regression tes

2017-02-08 Thread Dave Page
Spit out an exit code when running the regression tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9aa479ea2e96816f2160ebb18a0fc63d6298afe0 Modified Files -- web/regression/runtests.py | 12 1 file changed, 12 inse

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Compatibility fixes for Python2.6

2017-02-08 Thread Dave Page
Thanks - applied. On Wed, Feb 8, 2017 at 5:18 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue where user was not able to use query tool > when using Python2.6. > I also fixed "process_executer.py" as it has dict comprehension which is not > supported in Python2.6, so used

[pgadmin-hackers] pgAdmin 4 commit: Python 2.6 compatibility fixes.

2017-02-08 Thread Dave Page
Python 2.6 compatibility fixes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a914ea088c52c08fe62472a736d225d0db24bc0e Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/bgprocess/process_executor.py | 6 +++--- web/pgad

[pgadmin-hackers][patch] We can see tables in Greenplum!

2017-02-08 Thread George Gelashvili
Hello Hackers! We've a fix for displaying table nodes when connected to Greenplum. The salient bit was leaving off tgisinternal from the default template (but leaving the template used for postgres 9.1+ unchanged). We also added a Database helper class in test_utils for setting up and tearing down

[pgadmin-hackers] pgAdmin 4 commit: Fix indentation

2017-02-08 Thread Dave Page
Fix indentation Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e95dc5f895a8373e08c92f9c3302e6686422442e Modified Files -- runtime/TabWindow.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- Sent via pgadmin-hacker