[pgadmin-hackers] Additional CI tests

2017-03-28 Thread Dave Page
All, FYI, jenkins.pgadmin.org is now running additional tests and builds of pgAdmin 4 against all supported Python versions. We're now running: - Python regression tests (API tests, but not feature tests at present) - these run against PG and EPAS 9.2 through 9.6. - Jasmine tests - Doc build - Ru

Re: [pgadmin-hackers] Javascript translations

2017-03-28 Thread Dave Page
On Tue, Mar 28, 2017 at 2:04 PM, Sarah McAlear wrote: > There should be 2 additional lines in the babel.cfg file. We can see them > when we download the patch from the email. The additional lines are > > +[javascript: **/templates/about/**.js] > +[javascript: **/templates/dashboard/**.js] > > Than

[pgadmin-hackers] pgAdmin 4 commit: Fix translation extraction for new client side transl

2017-03-28 Thread Dave Page
Fix translation extraction for new client side translations, and update catalogs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1d27341e21e07b32fdc9cea0006d85aaa1970a8a Author: Sarah McAlear Modified Files -- docs/en_US/translat

Re: [pgadmin-hackers] Javascript translations

2017-03-28 Thread Sarah McAlear
There should be 2 additional lines in the babel.cfg file. We can see them when we download the patch from the email. The additional lines are +[javascript: **/templates/about/**.js] +[javascript: **/templates/dashboard/**.js] Thanks! On Tue, Mar 28, 2017 at 1:56 PM, Dave Page wrote: > Hi > >

Re: [pgadmin-hackers] Javascript translations

2017-03-28 Thread Dave Page
Hi Was that the correct patch? I don't see the changes you describe. On Tue, Mar 28, 2017 at 12:29 PM, Sarah McAlear wrote: > Good catch. We looked into this and it appears that the language > interpretation that is defined in the babel.cfg only picks up one definition > per file. Since we are i

Re: [pgadmin-hackers] Javascript translations

2017-03-28 Thread Sarah McAlear
Good catch. We looked into this and it appears that the language interpretation that is defined in the babel.cfg only picks up one definition per file. Since we are in the process of moving things over to the new gettext() functionality, it looks like we will have to be more specific in the config

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed Ascending/Descending order in backgrid

2017-03-28 Thread Dave Page
Thanks, applied. On Tue, Mar 28, 2017 at 2:41 AM, Khushboo Vashi wrote: > Hi Tira, > > On Mon, Mar 27, 2017 at 9:00 PM, Atira Odhner wrote: >> >> Hi Khushboo, >> >> Matt and I took a look at your patch and noticed that there is code >> duplication between the lines you added and the preceding bl

[pgadmin-hackers] pgAdmin 4 commit: Fix ascending/descending sort order in backgrid while

2017-03-28 Thread Dave Page
Fix ascending/descending sort order in backgrid while clicking on the headers. Fixes #2303 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8745417926c6dfde37217642aa22a439491dca55 Author: Khushboo Vashi Modified Files -- web/pgadm

[pgadmin-hackers] pgAdmin 4 commit: Fix typo in variable name.

2017-03-28 Thread Dave Page
Fix typo in variable name. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=44ce8985e035026a47d3536ddc9cd59ce2c963aa Modified Files -- runtime/Server.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) -- Sent via pgadmi

[pgadmin-hackers] pgAdmin 4 commit: Add header that seems to be needed with Python 3.

2017-03-28 Thread Dave Page
Add header that seems to be needed with Python 3. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=688c8103001559f59bc42b236a6376423eeae029 Modified Files -- runtime/Server.cpp | 4 1 file changed, 4 insertions(+) -- Sent via

[pgadmin-hackers] pgAdmin 4 commit: Fix usage of QString::toUtf8(). Fixes #2299

2017-03-28 Thread Dave Page
Fix usage of QString::toUtf8(). Fixes #2299 Desktop runtime has a couple bugs using already freed memory supplied to embedded python leading to occasional crashes and failures to start maintenance processes (VACUUM, ANALYZE, REINDEX, CLUSTER). This is caused by incorrect usage of QString::toUtf