Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-10 Thread Matthew Kleiman
Hi Dave, Unfortunately I found another regression; I have a test table called > موسيقى (Arabic for music) which if included in a selection of rows, Could you share the queries that: - create this table - populate it with data - access it leading to the regression What user interaction are you

[pgadmin-hackers] Candidate builds for 1.4

2017-04-10 Thread Dave Page
$SUBJECT can be found here: https://developer.pgadmin.org/~dpage/ Please yelp ASAP if there are any serious packaging problems. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent

[pgadmin-hackers] pgAdmin 4 commit: Adjust windows resources so they work consistently.

2017-04-10 Thread Dave Page
Adjust windows resources so they work consistently. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0c435154aca919ee6ff37cd12fc4fb1c9e663be2 Modified Files -- runtime/pgAdmin4.pro | 11 --- 1 file changed, 4 insertions(+), 7

[pgadmin-hackers] pgAdmin 4 commit: Fix application icon in mingw builds.

2017-04-10 Thread Dave Page
Fix application icon in mingw builds. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=665ec460521e875bfd0a6782d616a79a293ab7b7 Modified Files -- runtime/pgAdmin4.pro | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

[pgadmin-hackers] pgAdmin 4 commit: Bump version numbers for release.

2017-04-10 Thread Dave Page
Bump version numbers for release. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fdf292964ba708bfc4fe0d2d80f7e72048e765f0 Modified Files -- runtime/Info.plist | 4 ++-- web/config.py | 4 ++-- 2 files changed, 4 insertions(+),

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-10 Thread Navnath Gadakh
Hi Dave, Please find the revised patch. On Mon, Apr 10, 2017 at 1:43 PM, Dave Page wrote: > Hi > > On Fri, Apr 7, 2017 at 8:01 PM, Navnath Gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hello Joao, >> >> Thanks for review and suggestions. >>

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-10 Thread Murtuza Zabuawala
Sure, https://redmine.postgresql.org/issues/2331 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Apr 10, 2017 at 6:43 PM, Dave Page wrote: > Can you create an RM case for this please? > > Thanks. > > On Mon,

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-10 Thread Dave Page
Can you create an RM case for this please? Thanks. On Mon, Apr 10, 2017 at 2:11 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in browser tree where it was adding new nodes at > wrong place due to wrong conditions in the logic. > > Thanks

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in browser tree

2017-04-10 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in browser tree where it was adding new nodes at wrong place due to wrong conditions in the logic. Thanks to Ashesh for helping me. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git

Re: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.

2017-04-10 Thread Dave Page
Thanks - looks good, applied. On Mon, Apr 10, 2017 at 10:53 AM, Paresh More wrote: > Hello Dave > > I have figured out the issue. > > > For Innosetup we have two downloads available. > > 1) Normal (innosetup-5.5.9.exe) > 2) Unicode

[pgadmin-hackers] pgAdmin 4 commit: Ensure the web/ directory is cleared before upgrading

2017-04-10 Thread Dave Page
Ensure the web/ directory is cleared before upgrading Windows installations. Fixes #2187 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b86fa15dbce58df7be87035ae8cac6cd3f4ee98a Author: Paresh More Modified

[pgadmin-hackers] pgAdmin 4 commit: Recover properly if a database is renamed externally.

2017-04-10 Thread Dave Page
Recover properly if a database is renamed externally. Fixes #2077 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=024b97479dde8ce231532a5f79fb6600cbea0923 Author: RAJASEKAR G Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix a regression framework issue with Python 2.6.

2017-04-10 Thread Dave Page
Fix a regression framework issue with Python 2.6. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79e81478e3fa4d73793179861fe3ffc0e4958569 Author: Navnath Gadakh Modified Files --

Re: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.

2017-04-10 Thread Paresh More
Hello Dave I have figured out the issue. For Innosetup we have two downloads available. 1) Normal (innosetup-5.5.9.exe) 2) Unicode(innosetup-5.5.9-unicode.exe) The error which mentioned comes only for unicode , for normal its working fine. I have made changes to installer.iss.in

Re: [pgadmin-hackers][patch] Column selection on SQLEditor

2017-04-10 Thread Dave Page
Hi Matt, On Fri, Apr 7, 2017 at 10:56 PM, Matthew Kleiman wrote: > Hi Dave, > > I've updated the attached patch to include a change to the "Paste Rows" > button. It will now be enabled only if there are rows on the clipboard. Unfortunately I found another regression; I have

Re: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.

2017-04-10 Thread Dave Page
Attached. On Mon, Apr 10, 2017 at 10:26 AM, Paresh More wrote: > Hello Dave, > > Can you please send me C:\Users\dpage\Documents\pg > admin4\pkg\win32\installer.iss file > > On Mon, Apr 10, 2017 at 2:30 PM, Dave Page wrote: > >> Hi >> >> On Sun,

Re: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.

2017-04-10 Thread Paresh More
Hello Dave, Can you please send me C:\Users\dpage\Documents\ pgadmin4\pkg\win32\installer.iss file On Mon, Apr 10, 2017 at 2:30 PM, Dave Page wrote: > Hi > > On Sun, Apr 9, 2017 at 12:56 PM, Paresh More > wrote: > >> Hello Dave, >> >> This is

Re: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.

2017-04-10 Thread Dave Page
Hi On Sun, Apr 9, 2017 at 12:56 PM, Paresh More wrote: > Hello Dave, > > This is regarding issue # 2187 ( Cleaning up web/* *except* config_local.py) > through installer. https://redmine.postgresql.org/issues/2187 > > > Now Inno installer would clean up web folder

[pgadmin-hackers] pgAdmin 4 commit: Ensure menus are updated after disconnecting a server

2017-04-10 Thread Dave Page
Ensure menus are updated after disconnecting a server. Fixes #2281 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14f3a57d82d2f7f31e105e0dbb36200108273759 Author: RAJASEKAR G Modified Files --

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-04-10 Thread Dave Page
Hi On Fri, Apr 7, 2017 at 8:01 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello Joao, > > Thanks for review and suggestions. > > On Fri, Apr 7, 2017 at 9:08 PM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Hackers, >> We just