Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-28 Thread Matthew Kleiman
Hi Khushboo, That sounds good. Sorry if we weren't clear at first. Have a good holiday weekend! Sarah & Matt On Fri, Apr 28, 2017 at 4:35 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Sarah, > > On Thu, Apr 27, 2017 at 7:38 PM, Sarah McAlear > wrote: > >> Hi Kushboo! >> >

[pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-04-28 Thread Navnath Gadakh
Hi Dave, Please find the patch for OS compatability issue of test-suite. *Code Changes:* 1. Minor code changes done related to os module in *pgadmin4/web/regression/feature_utils/app_starter.py* 2. Code added in pgadmin4/*web/pgadmin/utils/tests/test_versioned_te

[pgadmin-hackers] [pgAdmin4][Patch]: Delete row server error not shown to GUI user

2017-04-28 Thread Surinder Kumar
Hi The variable list_of_rowid doesn't keep track of rows to be deleted. If this list is empty simply return 0 since '_rowid' is being used to highlight the row for which error is occurred in only insert and update operation. Please find attached patch and review. Thanks, Surinder Kumar RM_2356

Re: [pgadmin-hackers] Pains and thoughts about refactoring the Tree Menu using React

2017-04-28 Thread Ashesh Vashi
On Sat, Apr 22, 2017 at 12:17 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > After a conversation with Dave we believe that we need to provide more > context on our pains and what we propose as a first step for implementing > the Tree Menu using React. >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

2017-04-28 Thread Surinder Kumar
Hi Dave, Please find updated patch for RM case and a separate patch for Feature tests. *Python:* - Added [default] label for cells with default values while inserting a new row. - Introduced a FieldValidator function for cells that don't allow null values. If user tries to insert null value, fi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-04-28 Thread Khushboo Vashi
Hi Sarah, On Thu, Apr 27, 2017 at 7:38 PM, Sarah McAlear wrote: > Hi Kushboo! > > We understand your point, but we believe that relying on 2 independent > functions to deliver the same formatting can become a problem if the PG > function changes. Our suggestion is to use a single function in our

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-04-28 Thread Murtuza Zabuawala
Hi Ashesh, PFA updated patch for the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 26, 2017 at 10:29 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > > On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: > >