Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Backup in other langauge

2017-05-04 Thread Dave Page
Thanks, applied. On Thu, May 4, 2017 at 10:56 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in Backup module where it was not working if > user changes its preference language other than english. > RM#2354 > > -- > Regards, > Murtuza Zabua

[pgadmin-hackers] pgAdmin 4 commit: Fix the Backup module where it was not working if use

2017-05-04 Thread Dave Page
Fix the Backup module where it was not working if user changes its preference language other than english. Fixes #2354 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=155348d712da677c6fb77347647e2a9f8cc647dd Author: Murtuza Zabuawala Modifie

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue in NodeAjaxControl caching with cache-no

2017-05-04 Thread Dave Page
Fix an issue in NodeAjaxControl caching with cache-node field and add cache-node field in Trigger & Event trigger node so that whenever the user creates new Trigger Function we get new data from server in NodeAjaxControl. . Fixes #2242 Branch -- master Details --- https://git.postgresq

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with NodeAjaxControl data caching

2017-05-04 Thread Dave Page
Thanks, applied. On Wed, May 3, 2017 at 2:05 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in NodeAjaxControl caching with cache-node > field and I've also added cache-node field in Trigger & Event trigger node > so that whenever user crea

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-04 Thread Navnath Gadakh
Hi Dave, Please find the revised patch. I have added some print statements for debug purpose, so that I can get which line causing this issue. Most probably issue should be in the cleanup process. Please apply the patch and run the regression. Send me your console output and *regression.l

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

2017-05-04 Thread Robert Eckhardt
All, This change in the xss testing is preventing our CI from going green and is also preventing the Dependents and Dependencies tabs in Greenplum from being useful. Can we either merge this or provide feedback as to what needs to change so that it can be merged. Thank you Rob On Tue, May 2, 20

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-04 Thread Dave Page
Hi On Thu, May 4, 2017 at 10:29 AM, Akshay Joshi wrote: > Hi All > > On Wed, May 3, 2017 at 5:35 PM, Dave Page wrote: > >> Great, thanks. >> >> I think it's clear that we need to display the child partitions in the >> treeview. I don't see any other sensible way of enabling those operations >>

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Backup in other langauge

2017-05-04 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in Backup module where it was not working if user changes its preference language other than english. RM#2354 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/backup/templates/ba

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-04 Thread Akshay Joshi
Hi All On Wed, May 3, 2017 at 5:35 PM, Dave Page wrote: > Great, thanks. > > I think it's clear that we need to display the child partitions in the > treeview. I don't see any other sensible way of enabling those operations > without an extremely contrived dialogue design. > > Please now documen

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2315 : Sorting by size is broken

2017-05-04 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Apr 28, 2017 at 7:58 PM, Matthew Kleiman wrote: > Hi Khushboo, > > That sounds good. Sorry if we weren't clear at first. > > Have a good holiday weekend! > > Sarah & Matt > > > On Fri, Apr 28, 2017 at 4:35 AM, Khushboo Vashi

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

2017-05-04 Thread Dave Page
I still see the issue. See the attached screenshot. Killing process 32287 caused the test suite to exit.[image: Inline image 1] On Wed, May 3, 2017 at 1:32 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > It's getting strange now. I just updated my Mac OS from EI Capitan(10.11.6) >