Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-19 Thread Dave Page
On Thu, May 18, 2017 at 4:37 PM, Matthew Kleiman wrote: > Dave, > > Can you try running grunt tests on the command line? > > The tests task will run the eslint and karma grunt tasks, which should > automatically webpack the React components before running the jasmine tests >

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-19 Thread Dave Page
On Thu, May 18, 2017 at 11:41 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi All > > I have started implementation for Declarative Partitioning in pgAdmin4. > Following are the tasks that I have implemented till now: > >- Show partitioned table and it's partitions under the

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

2017-05-19 Thread Surinder Kumar
Hi Please find updated patch and review. On Thu, May 18, 2017 at 7:36 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > We reviewed the PR, and there are a lot of new lines of code in this > patch, are we sure that we can have a good coverage of the

Re: [pgadmin-hackers] Update pgAdmin4 version on pgadmin.org from 1.4 to 1.5

2017-05-19 Thread Dave Page
Thanks, updated. On Fri, May 19, 2017 at 1:21 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > Text 1.4 is not updated to 1.5 on pgadmin.org > > [image: Inline image 2] > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India:

[pgadmin-hackers] Update pgAdmin4 version on pgadmin.org from 1.4 to 1.5

2017-05-19 Thread Harshal Dhumal
Hi Dave, Text 1.4 is not updated to 1.5 on pgadmin.org [image: Inline image 2] -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #118

2017-05-19 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix RE-SQL for rules which got the table name wrong in the header and -- [...truncated 254.56 KB...] runTest

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-05-19 Thread Dave Page
Hi On Thu, May 18, 2017 at 6:57 PM, Shirley Wang wrote: > Hello! > > *Update on style guide location* > We're going to move the agreed upon styles from Figma onto a webpage that > will be accessible by everyone. We've decided to have a static site, with > the html and css

[pgadmin-hackers] pgAdmin 4 commit: Fix RE-SQL for rules which got the table name wrong i

2017-05-19 Thread Dave Page
Fix RE-SQL for rules which got the table name wrong in the header and DROP statement. Fixes #2422 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=04ce72a6aeeacc2bca7f3a7cfa2ab3a97419b2fe Modified Files --

[pgadmin-hackers] pgAdmin 4 v1.5 Released!

2017-05-19 Thread Dave Page
The pgAdmin Development Team are pleased to announce the release of pgAdmin 4 version 1.5. This release of pgAdmin 4 includes over 20 bug fixes and improvements: Bug #2225: Object creation options are visible even if the object type is hidden Bug #2253: Download as CSV often doesn't do anything

[pgadmin-hackers] pgAdmin 4 commit: Tag REL-1_5 has been created.

2017-05-19 Thread Dave Page
Tag REL-1_5 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-1_5 Log Message --- Tag 1.5 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-05-19 Thread Harshal Dhumal
Hi, On Thu, May 18, 2017 at 7:57 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Harshal, > > We review the patch and have some questions: > 1) Is there any particular reason to initialize variables and functions in > the same place? We believe that it would be