[pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

Hi, PFA patch to fix the handling of double precision[] type. RM#1928 Steps to re-produce: Below given query fails to render result in Query tool, SELECT ARRAY[1, 'nan', 3]::float[]; -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff -

[pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi The attribute key for Ok, Save buttons should be mapped to 13(Enter), for Help - 112(F1) and for Cancel - 27(Esc) The above changes are made into all dialog related template files. PFA patch and review. Thanks Surinder Feature_1535.patch Description: Binary data -- Sent via pgadmin-hacker

[pgadmin-hackers] [pgAdmin4][Patch][Feature_1533]: Set focus on first field when new dialog window is presented

Hi PFA patch and review. Thanks Surinder Feature_1533.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

Hello Dave, By the description on the email, it looks like the process is very similar to the Grunt process that we were talking about, but without the patch, it is a bit hard to get more specifics. Can you forward the patch so we can take a look at it. We believe that every effort done to elimina

[pgadmin-hackers] pgAdmin 4 commit: Fix a couple of missing greys.

Fix a couple of missing greys. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88737248ab9d2615ea6a16bef3913634020989f0 Author: Surinder Kumar Modified Files -- web/pgadmin/browser/templates/browser/js/node.js | 4 ++-- 1 file chan

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Thanks, applied. On Wed, Jun 7, 2017 at 3:48 PM, Surinder Kumar wrote: > Hi > > I have used classes 'bg-gray-2 border-gray-3' for styling header and footer > of properties panel which are also used in other places. > > Please find attached patch. > > > On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckha

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

PFA patch after rebase On Wed, Jun 7, 2017 at 6:26 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Please find rebased patch. > > On Wed, Jun 7, 2017 at 6:15 PM, Dave Page wrote: > >> Hi, >> >> Could you rebase this please? >> >> Thanks. >> >> On Tue, Jun 6, 2017 at 9:22 AM

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Hi I have used classes 'bg-gray-2 border-gray-3' for styling header and footer of properties panel which are also used in other places. Please find attached patch. On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt wrote: > Thank you. > > -- Rob > > On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi On Tue, Jun 6, 2017 at 9:15 PM, Sarah McAlear wrote: > Hello, > >> First patch contains changes related to copy row feature which is already >> in process in another thread. Any reason to add those changes in this patch >> as this patch is meant to contain infrastructure changes ? > > > As par

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #137

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2461]: Unable to drop defaut value from the column in table

Thanks, applied. On Tue, Jun 6, 2017 at 11:05 AM, Surinder Kumar wrote: > Hi > > Add drop column syntax for dropping default value of a column if default > value is kept empty. > > Please find attached patch and review. > > Thanks, > Surinder > > > -- > Sent via pgadmin-hackers mailing list (pgad

[pgadmin-hackers] pgAdmin 4 commit: Allow users to remove default values from columns pro

Allow users to remove default values from columns properly. Fixes #2461 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=63c093248dfeaae41057ace0bf32c3ef1024d954 Author: Surinder Kumar Modified Files -- .../schemas/tables/templates

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Thank you. -- Rob On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Sure I will send. > > On Wed, Jun 7, 2017 at 6:54 PM, Dave Page wrote: > >> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > With the latest pull, I found: >>

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Can you rebase this please? I think Ashesh broke it :-p On Tue, Jun 6, 2017 at 7:42 AM, Harshal Dhumal wrote: > Hi, > > On Mon, Jun 5, 2017 at 9:25 PM, Dave Page wrote: >> >> Hi >> >> With this patch applied, it uses the field names instead of the labels >> in error messages - e.g. >> >> 'dirty_

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Sure I will send. On Wed, Jun 7, 2017 at 6:54 PM, Dave Page wrote: > On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar > wrote: > > Hi > > > > With the latest pull, I found: > > The header color of Properties panel disappears and background color of > > footer area in Edit Properties panel is chan

[pgadmin-hackers] pgAdmin 4 commit: Resolve the PG datatype feature test flakiness and ma

Resolve the PG datatype feature test flakiness and make for a nice buttery crust. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f89aec867a3bcac337362889dfb6769188524839 Author: George Gelashvili Modified Files -- .../feature_te

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar wrote: > Hi > > With the latest pull, I found: > The header color of Properties panel disappears and background color of > footer area in Edit Properties panel is changed. Oh, I missed that :-(. Can you come up with a quick fix using the new classes?

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Hi With the latest pull, I found: The header color of Properties panel disappears and background color of footer area in Edit Properties panel is changed. On Wed, Jun 7, 2017 at 6:28 PM, Dave Page wrote: > Thanks, applied. I removed the doc comments from the CSS for now as we > don't have minim

Re: [pgadmin-hackers] [PATCH] extract function from sqleditor

Thanks, applied. On Mon, Jun 5, 2017 at 9:30 PM, George Gelashvili wrote: > Hello Hackers! > > Re. > https://www.postgresql.org/message-id/CAFS4TJb-7VTQQrnOi0g6MaoxMfEK9LzCds2yG%2BByS-mLHwydQA%40mail.gmail.com > > We extracted the function bound to onSelectedRangesChanged from sqleditor! > > - we

[pgadmin-hackers] pgAdmin 4 commit: Extract row staging into it's own module with tests.

Extract row staging into it's own module with tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d8e7dab3c7f3f44690670614d7165474ff2265f Author: George Gelashvili Modified Files -- web/pgadmin/static/js/selection/set_staged_r

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #136

See Changes: [Dave Page] Fix the RE-SQL for for views to properly qualify trigger function names. [Dave Page] List packages in PPAS 9.2-9.4 when creating synonyms. Fixes #1813 [Dave Page] Update the s

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Thanks, applied. I removed the doc comments from the CSS for now as we don't have minimisation for that yet (and one of them seemed to be garbage). On Mon, Jun 5, 2017 at 4:52 PM, Shruti B Iyer wrote: > Hi Hackers > > Attached are two patches for styling improvements. > 1-add-style-guide.patch co

[pgadmin-hackers] pgAdmin 4 commit: Update the styling to use the set of grays defined in

Update the styling to use the set of grays defined in the WIP style guide. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0d05385585d559b13f3eb8bcec83d5c41afeab30 Author: Shruti B Iyer Modified Files -- web/karma.conf.js

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

Hi Please find rebased patch. On Wed, Jun 7, 2017 at 6:15 PM, Dave Page wrote: > Hi, > > Could you rebase this please? > > Thanks. > > On Tue, Jun 6, 2017 at 9:22 AM, Surinder Kumar > wrote: > > Hi All, > > > > Please find updated patch which includes Jasmine test cases for functions > > getHa

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

Hi, Could you rebase this please? Thanks. On Tue, Jun 6, 2017 at 9:22 AM, Surinder Kumar wrote: > Hi All, > > Please find updated patch which includes Jasmine test cases for functions > getHash and calculateColumnWidth > > Thanks, > Surinder > > On Mon, Jun 5, 2017 at 11:38 PM, Shruti B Iyer w

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Synonym node EPAS9.2

Thanks, applied. On Mon, Jun 5, 2017 at 11:38 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in Synonym node for EPAS9.2+ where Packages are > not displaying as a target objects. > RM#1813 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The

[pgadmin-hackers] pgAdmin 4 commit: List packages in PPAS 9.2-9.4 when creating synonyms.

List packages in PPAS 9.2-9.4 when creating synonyms. Fixes #1813 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=495a3cedb05d9097d169d81814af73f3d01a7434 Author: Murtuza Zabuawala Modified Files -- .../templates/synonym/sql/9.2_p

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2381 - "Create Script" for view assigns incorrect schema to trigger functions in "public" schema.

Thanks, patch applied. On Mon, Jun 5, 2017 at 11:26 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix RM 2381: "Create Script" for view > assigns incorrect schema to trigger functions in "public" schema. > > Fixed the trigger function schema name in the view SQL tab. > > >

[pgadmin-hackers] pgAdmin 4 commit: Fix the RE-SQL for for views to properly qualify trig

Fix the RE-SQL for for views to properly qualify trigger function names. Fixes #2381 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b134ae2cb4d0a57833eb93e5fecece669214b16d Author: Khushboo Vashi Modified Files -- .../servers/da

[pgadmin-hackers] [pgAdmin4][Patch][RM_ 2368]: Allow cell editing on single click in edit grid

Hi Please find attached patch and review. Thanks, Surinder RM_2368.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4] To fix the error "ValueError: too many values to unpack" while polling

Hi, PFA minor patch to fix the issue in query tool result polling causing exception, *ValueError: too many values to unpack* RM#2470 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/utils/driver/psycopg2/__init__.py

[pgadmin-hackers] [pgAdmin4] To fix issues in pgAgent's modules

Hi, Please find attached patch to fix the issues in pgAgent's Schedule and Step module. 1) Error on clicking SQL panel when Schedule OR Step node is selected in browser. RM#1888 2) Error while dropping Schedule OR Step node. RM#1889 3) Newly created Schedule/Step node was not displaying in brow

[pgadmin-hackers] pgAdmin 4 commit: Using the client-side translation using the client-si

Using the client-side translation using the client-side 'gettext' implementation. This is the first step towards 'Avoid creating the javascript modules using Jinja templates'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae809766892e3cbca31