[pgadmin-hackers] pgAdmin III commit: Prevent refreshing or dropping an object

2011-08-11 Thread Guillaume Lelarge
Prevent refreshing or dropping an object ... when its property window is opened. Should work with server disconnection, database disconnection, and objects refresh, and objects drop. If an object's properties window is already opened, it'll raise this window, and not open another one. Per many

[pgadmin-hackers] Weird git messages

2011-08-11 Thread Guillaume Lelarge
Hi, When pushing my last commit, I got some weird messages: [master!git.pgadmin3]$ git push Counting objects: 37, done. Delta compression using up to 4 threads. Compressing objects: 100% (19/19), done. Writing objects: 100% (19/19), 3.58 KiB, done. Total 19 (delta 18), reused 0 (delta 0) Auto

Re: [pgadmin-hackers] Weird git messages

2011-08-11 Thread Guillaume Lelarge
On Thu, 2011-08-11 at 22:08 +0200, Guillaume Lelarge wrote: Hi, When pushing my last commit, I got some weird messages: [master!git.pgadmin3]$ git push Counting objects: 37, done. Delta compression using up to 4 threads. Compressing objects: 100% (19/19), done. Writing objects: 100% (19

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-08-11 Thread Guillaume Lelarge
On Thu, 2011-08-11 at 21:16 +0200, Guillaume Lelarge wrote: On Thu, 2011-08-11 at 08:52 +0100, Dave Page wrote: On Wed, Aug 10, 2011 at 11:06 PM, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-08-09 at 00:30 +0200, Guillaume Lelarge wrote: On Sun, 2011-07-24 at 15:09 +0100

[pgadmin-hackers] pgAdmin website commit: We're in beta3 since a few weeks.

2011-08-11 Thread Guillaume Lelarge
We're in beta3 since a few weeks. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=22212649da3cc2e17e0669b84d7960f50d8cf2e5 Modified Files -- download/macosx.php |2 +- download/source.php |2 +- download/windows.php |

[pgadmin-hackers] pgAdmin website commit: Automatic stringmerge using merge script.

2011-08-11 Thread Guillaume Lelarge
Automatic stringmerge using merge script. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=03d91e9a464f21c6abf55378ce3b141ccb64bf87 Modified Files -- locale/cs_CZ/LC_MESSAGES/pgadmin3_website.mo | Bin 139967 - 138854 bytes

[pgadmin-hackers] pgAdmin website commit: Update .pot file.

2011-08-11 Thread Guillaume Lelarge
Update .pot file. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=f70da0f9c7e0deee1c9464a1ebac57c72ea7be38 Modified Files -- locale/pgadmin3_website.pot | 72 +- 1 files changed, 29

[pgadmin-hackers] pgAdmin website commit: Two roadmap items done.

2011-08-11 Thread Guillaume Lelarge
Two roadmap items done. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=f3aa9c5b6c830864e12750c573e5c979d361e4a2 Modified Files -- development/roadmap.php |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Sent

[pgadmin-hackers] pgAdmin III commit: Update .pot file.

2011-08-11 Thread Guillaume Lelarge
Update .pot file. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b0b818594344946d2cd8d169605bc32d04521418 Modified Files -- pgadmin3.pot | 1048 +- 1 files

[pgadmin-hackers] pgAdmin III commit: Automatic merge using stringmerge script.

2011-08-11 Thread Guillaume Lelarge
Automatic merge using stringmerge script. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=0bac37654293a914b9368e2bacbb227c97f01b41 Modified Files -- i18n/af_ZA/pgadmin3.po | 1049 ++-- i18n/ar_SA/pgadmin3.po | 1049 ++--

[pgadmin-hackers] pgAdmin III commit: Update french translation.

2011-08-11 Thread Guillaume Lelarge
Update french translation. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=3d7d6ab9a30868c6f0f005a760e46687b9df822a Modified Files -- i18n/fr_FR/pgadmin3.mo | Bin 317918 - 317929 bytes i18n/fr_FR/pgadmin3.po |22941

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-08-10 Thread Guillaume Lelarge
On Tue, 2011-08-09 at 00:30 +0200, Guillaume Lelarge wrote: On Sun, 2011-07-24 at 15:09 +0100, Dave Page wrote: On Sun, Jul 24, 2011 at 2:23 PM, Guillaume Lelarge guilla...@lelarge.info wrote: On Sun, 2011-07-24 at 14:11 +0200, Guillaume Lelarge wrote: On Sun, 2011-07-24 at 12:58 +0100

[pgadmin-hackers] pgAdmin III commit: Fix Current log selection in the log combobox

2011-08-08 Thread Guillaume Lelarge
Fix Current log selection in the log combobox Before, it displayed the oldest log file. Now, it displays the current one. Per request from Colin Wright. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7964a7a4e72780d1b4da4065bdb0e0472be9d90a

[pgadmin-hackers] pgAdmin III commit: Fix Current log selection in the log combobox

2011-08-08 Thread Guillaume Lelarge
Fix Current log selection in the log combobox Before, it displayed the oldest log file. Now, it displays the current one. Per request from Colin Wright. Branch -- REL-1_14_0_PATCHES Details ---

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-08 Thread Guillaume Lelarge
On Mon, 2011-08-08 at 06:24 +0200, Vladimir Kokovic wrote: Hi, I changed the names of files, so files do not start now with the 'frm' ! In this version, disconnect from the DB server has been fixed. Cannot check that because I have a segfault each time I paste one or more tables in a

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-08-08 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 15:09 +0100, Dave Page wrote: On Sun, Jul 24, 2011 at 2:23 PM, Guillaume Lelarge guilla...@lelarge.info wrote: On Sun, 2011-07-24 at 14:11 +0200, Guillaume Lelarge wrote: On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: The former fix seems more appropriate

Re: [pgadmin-hackers] Enable/Disable save button in the frmQuery.

2011-08-07 Thread Guillaume Lelarge
On Sat, 2011-08-06 at 19:16 -0300, Vinicius Santos wrote: Hello, I believe that when you save a document in the form frmQuery, the Save button should be disabled to become more obvious to the user that the document contains no changes. When user change the document, the button is

[pgadmin-hackers] pgAdmin III commit: Implement enable/disable save button, on text chang

2011-08-07 Thread Guillaume Lelarge
Implement enable/disable save button, on text change. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=200184baf56f1bef00229d9674395fd099441795 Author: Vinicius Santos vinicius.santos.li...@gmail.com Modified Files -- CHANGELOG

Re: [pgadmin-hackers] Enable/Disable save button in the frmQuery.

2011-08-07 Thread Guillaume Lelarge
On Sun, 2011-08-07 at 12:47 -0300, Vinicius Santos wrote: You're welcome to send it there. It should apply cleanly on the master branch. Simple as that. If something is wrong, please let me know. Nope, that's great. It's now pushed. Thank you. -- Guillaume

[pgadmin-hackers] pgAdmin III commit: Update german translation.

2011-08-06 Thread Guillaume Lelarge
Update german translation. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a1045a17a81458473c8a411cf53fcc4a50024ee5 Author: Steffen Kuhn p...@kuhnsteffen.de Modified Files -- i18n/de_DE/pgadmin3.mo | Bin 206804 - 210775 bytes

[pgadmin-hackers] pgAdmin III commit: Update german translation.

2011-08-06 Thread Guillaume Lelarge
Update german translation. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=3f3eb35fc8f98e5bef1b03e79b8a21d0239d3e7e Author: Steffen Kuhn p...@kuhnsteffen.de Modified Files -- i18n/de_DE/pgadmin3.mo | Bin 206804 -

[pgadmin-hackers] pgAdmin III commit: Fix View Last x Rows ordering with multikey pkey

2011-08-06 Thread Guillaume Lelarge
Fix View Last x Rows ordering with multikey pkey Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e1189f7a95d0c36b6106b877a81f852a152015a1 Author: Dave Page dp...@pgadmin.org Modified Files -- pgadmin/frm/frmEditGrid.cpp |6

[pgadmin-hackers] pgAdmin III commit: Fix View Last x Rows ordering with multikey pkey

2011-08-06 Thread Guillaume Lelarge
Fix View Last x Rows ordering with multikey pkey Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=55588459b9a4b44975b2a67f4de4cfd2364ff0cc Author: Dave Page dp...@pgadmin.org Modified Files -- pgadmin/frm/frmEditGrid.cpp

[pgadmin-hackers] pgAdmin III commit: Fix the ordering on View Data

2011-08-06 Thread Guillaume Lelarge
Fix the ordering on View Data According to a report from Erwin Brandstetter Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c557c5874954d952e0251fce8fd12176b7e51051 Modified Files -- pgadmin/include/frm/frmEditGrid.h |

[pgadmin-hackers] pgAdmin III commit: Fix the ordering on View Data

2011-08-06 Thread Guillaume Lelarge
Fix the ordering on View Data According to a report from Erwin Brandstetter Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c1e0b460aa8b9f75dc7b001c3ce520c480befd7d Modified Files -- pgadmin/include/frm/frmEditGrid.h |1 + 1

Re: [pgadmin-hackers] Changed default ordering in tables

2011-08-06 Thread Guillaume Lelarge
On Fri, 2011-07-29 at 10:33 +0100, Dave Page wrote: On Fri, Jul 29, 2011 at 9:14 AM, Erwin Brandstetter brandstet...@falter.at wrote: So, that's two distinct issue: - Last 100 rows broken for multi-column pkeys. - Default sort order DESC for edit grid, where it should be ASC. That one I

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Guillaume Lelarge
On Mon, 2011-08-01 at 06:01 +0200, Vladimir Kokovic wrote: Hi, Added a thread termination control in case of main frame OnClose. Ignore previous two patches ! Tried it. Don't like the big button, I would get rid of it. It behaves much better. I still don't get why you have a frmXXX if

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Guillaume Lelarge
On Sat, 2011-08-06 at 15:33 +0200, Guillaume Lelarge wrote: On Mon, 2011-08-01 at 06:01 +0200, Vladimir Kokovic wrote: Hi, Added a thread termination control in case of main frame OnClose. Ignore previous two patches ! Tried it. Don't like the big button, I would get rid

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Guillaume Lelarge
On Sat, 2011-08-06 at 16:30 +0200, Vladimir Kokovic wrote: Hi, I will fix disconnection problem. Thanks. Tooltip on the toolbar paste icon shows progress. Tooltip isn't a better UI than the status bar. And even that one is not a good one for this matter. -- Guillaume

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Guillaume Lelarge
On Sat, 2011-08-06 at 16:28 +0100, Dave Page wrote: If there's a frmXXX that doesn't implement a separate tool (like the query tool or server status monitor), then that must be moved renamed before commit. I would prefer the tool to show something, but yeah, you're right, if it doesn't show

[pgadmin-hackers] pgAdmin III commit: Use system default background colour instead of whi

2011-08-06 Thread Guillaume Lelarge
Use system default background colour instead of white ... for the nodes' background color in the treeview. Should fix debian bug #635748 (see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=635748). Branch -- master Details ---

[pgadmin-hackers] pgAdmin III commit: Use system default background colour instead of whi

2011-08-06 Thread Guillaume Lelarge
Use system default background colour instead of white ... for the nodes' background color in the treeview. Should fix debian bug #635748 (see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=635748). Branch -- REL-1_14_0_PATCHES Details ---

[pgadmin-hackers] pgAdmin III commit: Follow option on to wether or not display foreign t

2011-08-06 Thread Guillaume Lelarge
Follow option on to wether or not display foreign table menu Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e17c5d49fe25246dda7fe419c45f03d78be0cf79 Modified Files -- pgadmin/schema/pgSchema.cpp |8 ++-- 1 files changed, 2

[pgadmin-hackers] pgAdmin III commit: Follow option on to wether or not display foreign t

2011-08-06 Thread Guillaume Lelarge
Follow option on to wether or not display foreign table menu Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e031f26e478ab7d7832a4d66303ca1aaa8bcc88f Modified Files -- pgadmin/schema/pgSchema.cpp |8 ++-- 1 files

[pgadmin-hackers] pgAgent commit: Update HTTP checkout link for INSTALL file

2011-08-05 Thread Guillaume Lelarge
Update HTTP checkout link for INSTALL file Info from Heikki Linnakangas. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=303ee35b0b151c543a87b2c1c7f5efc3d4ae2a43 Modified Files -- README |2 +- 1 files changed, 1 insertions(+),

[pgadmin-hackers] pgAdmin III commit: Fix issues when using pgadmin with 9.1 or older rel

2011-08-05 Thread Guillaume Lelarge
Fix issues when using pgadmin with 9.1 or older releases We should only get SQL for security labels on 9.1 for local objects and 9.2 for global (shared) objects. Branch -- master Details ---

Re: [pgadmin-hackers] pgAdmin III commit: Support for security labels on global objects

2011-08-05 Thread Guillaume Lelarge
On Tue, 2011-08-02 at 19:04 +0600, Timon wrote: pgadmin crashes after createing second table. steps to reproduce: 1) run pgadmin 2) create table (empty table t1, for example) 3) create one more table (empty table t2, etc...) 4) catch the crash git bisect points to this commit

Re: [pgadmin-hackers] Patch to add support for security labels on local objects

2011-08-05 Thread Guillaume Lelarge
On Tue, 2011-08-02 at 09:49 +0200, Vladimir Kokovic wrote: Hi, All if (seclabelPage) should be if (seclabelPage connection-BackendMinimumVersion(9, 1)) Yes, and the same (but 9.2) for global/shared objects. Fix added. Thanks. -- Guillaume http://blog.guillaume.lelarge.info

[pgadmin-hackers] pgAdmin III commit: Update the VC++ project

2011-07-26 Thread Guillaume Lelarge
Update the VC++ project Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=325ca8db34598660df9c9306b055e082671acb2f Modified Files -- pgadmin/pgAdmin3.vcproj | 12 1 files changed, 12 insertions(+), 0 deletions(-) --

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-07-25 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 21:44 +0100, Dave Page wrote: On Tue, Jul 19, 2011 at 8:06 PM, Guillaume Lelarge guilla...@lelarge.info wrote: There's no Makefile there. Did you forget to check it in? Oops, forgot this one. The fact that Makefile is in the .gitignore file didn't help. So

[pgadmin-hackers] pgAdmin III commit: Support for security labels on global objects

2011-07-25 Thread Guillaume Lelarge
Support for security labels on global objects This is to support a 9.2 feature of PostgreSQL. It adds a new tab to databases, roles, and tablespaces dialogs, that allows one to add security label for each provider they want. I suppose most users will have only one provider, but the patch supports

[pgadmin-hackers] pgAdmin III commit: Support for security labels on local objects

2011-07-25 Thread Guillaume Lelarge
Support for security labels on local objects This patch adds support to a PostgreSQL 9.1 feature called security labels. It adds a new tab to tables, columns, aggregates, domains, foreign tables, functions, languages, sequences, types, and views dialogs, that allows one to add security label for

[pgadmin-hackers] pgAdmin III commit: Support for not valid domain and check constraints

2011-07-25 Thread Guillaume Lelarge
Support for not valid domain and check constraints In 9.2, domains and check constraints can be declared not valid. Their validity can be forced later. This patch adds support for this. Branch -- master Details ---

[pgadmin-hackers] pgAdmin III commit: Adds support for load/save models in the database d

2011-07-25 Thread Guillaume Lelarge
Adds support for load/save models in the database designer Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=271d84f7baaeae8e3ee235dbcf3838e6546bda8d Author: Luis Ochoa ziul1...@gmail.com Modified Files -- CHANGELOG

[pgadmin-hackers] pgAdmin III commit: Update CHANGELOG, and make style

2011-07-25 Thread Guillaume Lelarge
Update CHANGELOG, and make style Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=038f993311f71ffb5496eeff259d217e791221fb Modified Files -- CHANGELOG |4 + pgadmin/ctl/ctlSeclabelPanel.cpp |

[pgadmin-hackers] pgAdmin III commit: Forgot this file.

2011-07-25 Thread Guillaume Lelarge
Forgot this file. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=084e0947b59afc3377ee0e57c047692c9c144e59 Modified Files -- pgadmin/include/images/checkbad.png | Bin 0 - 579 bytes 1 files changed, 0 insertions(+), 0 deletions(-)

[pgadmin-hackers] pgAdmin III commit: Add multiline flag for textbox in domain and server

2011-07-25 Thread Guillaume Lelarge
Add multiline flag for textbox in domain and server dialog Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a81daf94aa063d2d1fa1be66978dcf261eb33eb1 Modified Files -- pgadmin/ui/dlgDomain.xrc |1 +

[pgadmin-hackers] pgAdmin III commit: Add multiline flag for textbox in domain and server

2011-07-25 Thread Guillaume Lelarge
Add multiline flag for textbox in domain and server dialog Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=199b23e3ec5c8062a50e58b266c3fdbe12035c8e Modified Files -- pgadmin/ui/dlgDomain.xrc |1 + pgadmin/ui/dlgServer.xrc |

Re: [pgadmin-hackers] Load/Save feature for the database designer

2011-07-25 Thread Guillaume Lelarge
On Mon, 2011-07-25 at 09:02 +0200, Guillaume Lelarge wrote: Hi, Luis sent me his last patch to support load/save features for the database designer. It's a quite simple patch, and works flawlessly AFAICT. I'd like to commit it this afternoon, so if you want to look at it first, you need

Re: [pgadmin-hackers] Patch to add support for security labels on local objects

2011-07-25 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 21:23 +0200, Guillaume Lelarge wrote: On Sun, 2011-07-24 at 17:40 +0200, Guillaume Lelarge wrote: On Sun, 2011-07-24 at 10:58 +0200, Guillaume Lelarge wrote: Hi, This patch adds support to a PostgreSQL 9.1 feature called security labels. It adds a new tab

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-07-25 Thread Guillaume Lelarge
On Mon, 2011-07-25 at 16:20 +0100, Dave Page wrote: On Mon, Jul 25, 2011 at 8:52 AM, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 21:44 +0100, Dave Page wrote: On Tue, Jul 19, 2011 at 8:06 PM, Guillaume Lelarge guilla...@lelarge.info wrote: There's no Makefile

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-25 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 16:00 +0200, Vladimir Kokovic wrote: Hi, This patch is probably Release Candidate 2! Fixed copy / paste of tables that do not have columns. Everything functions as provided except for one detail that I have no explanation or solution. Functionality: 1. copy /

Re: [pgadmin-hackers] Handling connection loss

2011-07-25 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 21:12 +0100, Dave Page wrote: On Tue, Jul 19, 2011 at 7:47 PM, Guillaume Lelarge guilla...@lelarge.info wrote: I tried something else today. Suppose a database with two schemas. Both have objects in them, let's say two tables in each schema. Connect to the database

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-07-25 Thread Guillaume Lelarge
On Mon, 2011-07-25 at 20:39 +0100, Dave Page wrote: On Mon, Jul 25, 2011 at 8:33 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Something like the attached? (lightly tested!) Oh yeah, thanks, it works right out of the box for me. Sweet :-) So I guess we have it all

[pgadmin-hackers] pgAdmin III commit: Use sphinx documentation system

2011-07-25 Thread Guillaume Lelarge
Use sphinx documentation system With a big help from Dave, especially with the autoconf system. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=2d85533a2699c687d95b4b8f5ed0b9fcd844ede2 Modified Files -- CHANGELOG

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-07-25 Thread Guillaume Lelarge
On Mon, 2011-07-25 at 21:01 +0100, Dave Page wrote: On Mon, Jul 25, 2011 at 8:59 PM, Guillaume Lelarge guilla...@lelarge.info wrote: You mean something like this? diff --git a/Makefile.am b/Makefile.am index 677ec5c..d1d19f3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -34,7 +34,8

[pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Guillaume Lelarge
Hi, There is at least one bug that I know since I started to use pgAdmin, and I've seen no work on it. When someone connects to a database, the treeview is built from informations gathered in the database. Not only do we fill the treeview, but we also create a lot of pgObject objects (pgTable,

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: The former fix seems more appropriate. Operations in frmMain shouldn't cause dialogues to close. Fine with me. That should be simpler to do. Simple fix seems to be to store a pointer to the dialog in pgObject; if not null, disallow drop,

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 14:11 +0200, Guillaume Lelarge wrote: On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: The former fix seems more appropriate. Operations in frmMain shouldn't cause dialogues to close. Fine with me. That should be simpler to do. Simple fix seems

[pgadmin-hackers] pgAdmin III commit: Fix altering comments on an existing function

2011-07-24 Thread Guillaume Lelarge
Fix altering comments on an existing function Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f7ebe911e7bf02557fdad3bb57e1783a926439e7 Modified Files -- pgadmin/dlg/dlgFunction.cpp |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [pgadmin-hackers] Patch to add support for security labels on local objects

2011-07-24 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 10:58 +0200, Guillaume Lelarge wrote: Hi, This patch adds support to a PostgreSQL 9.1 feature called security labels. It adds a new tab to tables, columns, aggregates, domains, foreign tables, functions, languages, sequences, types, and views dialogs, that allows one

Re: [pgadmin-hackers] Patch to add support for not valid domain and check constraint

2011-07-23 Thread Guillaume Lelarge
On Fri, 2011-07-22 at 23:55 +0100, Thom Brown wrote: On 22 July 2011 23:43, Guillaume Lelarge guilla...@lelarge.info wrote: Hi, In 9.2, domains and check constraints can be declared not valid. Their validity can be forced later. This patch adds support for this new feature. Comments

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-22 Thread Guillaume Lelarge
On Fri, 2011-07-22 at 06:19 +0200, Vladimir Kokovic wrote: Hi, This time, the patch is probably Release Candidate 1 ! I'm afraid that won't be the last. It still crashes a lot. I still have the previous issue when copying more than one table (with one table, it works). It doesn't like

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-22 Thread Guillaume Lelarge
On Fri, 2011-07-22 at 21:53 +0200, Guillaume Lelarge wrote: On Fri, 2011-07-22 at 06:19 +0200, Vladimir Kokovic wrote: Hi, This time, the patch is probably Release Candidate 1 ! I'm afraid that won't be the last. It still crashes a lot. I still have the previous issue when copying

[pgadmin-hackers] pgAdmin III commit: Always add parenthesis, even if there is no columns

2011-07-22 Thread Guillaume Lelarge
Always add parenthesis, even if there is no columns The CREATE TABLE statement should always have parenthesis, even if there is no column or option between them. Branch -- REL-1_14_0_PATCHES Details ---

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-22 Thread Guillaume Lelarge
On Fri, 2011-07-22 at 21:54 +0200, Guillaume Lelarge wrote: On Fri, 2011-07-22 at 21:53 +0200, Guillaume Lelarge wrote: On Fri, 2011-07-22 at 06:19 +0200, Vladimir Kokovic wrote: Hi, This time, the patch is probably Release Candidate 1 ! I'm afraid that won't be the last

[pgadmin-hackers] Patch to add support for not valid domain and check constraint

2011-07-22 Thread Guillaume Lelarge
00:00:00 2001 From: Guillaume Lelarge guilla...@lelarge.info Date: Sat, 9 Jul 2011 15:15:33 +0200 Subject: [PATCH] Support for not valid domain and check constraints In 9.2, domains and check constraints can be declared not valid. Their validity can be forced later. This patch adds support

Re: [pgadmin-hackers] Altering column collation

2011-07-21 Thread Guillaume Lelarge
On Wed, 2011-07-20 at 10:56 +0100, Thom Brown wrote: On 19 July 2011 21:04, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 20:43 +0100, Thom Brown wrote: On 19 July 2011 08:32, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 00:48 +0100, Thom

[pgadmin-hackers] pgAdmin III commit: Fix collation change

2011-07-21 Thread Guillaume Lelarge
Fix collation change Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=6a71362c40c54d1a6fc515ec23badf7e377ffebb Modified Files -- pgadmin/dlg/dlgColumn.cpp | 20 ++-- pgadmin/dlg/dlgTable.cpp | 16

[pgadmin-hackers] pgAdmin III commit: Fix collation change

2011-07-21 Thread Guillaume Lelarge
Fix collation change Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=05d0044b8a7704960fc4acb8bb9a63e55ea2e182 Modified Files -- pgadmin/dlg/dlgColumn.cpp | 17 - pgadmin/dlg/dlgTable.cpp | 16 +--- 2

Re: [pgadmin-hackers] Altering column collation

2011-07-21 Thread Guillaume Lelarge
On Thu, 2011-07-21 at 21:44 +0200, Guillaume Lelarge wrote: On Wed, 2011-07-20 at 10:56 +0100, Thom Brown wrote: On 19 July 2011 21:04, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 20:43 +0100, Thom Brown wrote: On 19 July 2011 08:32, Guillaume Lelarge guilla

Re: [pgadmin-hackers] Altering column collation

2011-07-21 Thread Guillaume Lelarge
On Thu, 2011-07-21 at 22:54 +0200, Guillaume Lelarge wrote: On Thu, 2011-07-21 at 21:44 +0200, Guillaume Lelarge wrote: On Wed, 2011-07-20 at 10:56 +0100, Thom Brown wrote: On 19 July 2011 21:04, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 20:43 +0100, Thom

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-20 Thread Guillaume Lelarge
On Wed, 2011-07-20 at 06:11 +0200, Vladimir Kokovic wrote: Hi, I can not reproduce! For me it works successfully. 1. create schema vk1 2. CREATE TABLE vk1.t1 (c1 bigint); 3. create schema vk2 4. copy schema tables vk1 5. paste into vk2 -- OK 6. paste into vk1 -- OK Because you

Re: [pgadmin-hackers] Idea: check SQL before copying to SQL dialogue.

2011-07-20 Thread Guillaume Lelarge
On Wed, 2011-07-20 at 19:05 +0100, Dave Page wrote: On Wed, Jul 20, 2011 at 6:05 PM, Erwin Brandstetter brandstet...@falter.at wrote: Aloha! A lot of work has been put into when and where to refresh the browser window. From my experience it is often a _good_ thing, that changes via

Re: [pgadmin-hackers] Idea: check SQL before copying to SQL dialogue.

2011-07-20 Thread Guillaume Lelarge
On Wed, 2011-07-20 at 21:41 +0200, Erwin Brandstetter wrote: On 20.07.2011 20:26, Guillaume Lelarge wrote: On Wed, 2011-07-20 at 19:05 +0100, Dave Page wrote: On Wed, Jul 20, 2011 at 6:05 PM, Erwin Brandstetter brandstet...@falter.at wrote: Aloha! A lot of work has been put into when

[pgadmin-hackers] pgAdmin III commit: Fix weird behaviour when changing column's collatio

2011-07-19 Thread Guillaume Lelarge
Fix weird behaviour when changing column's collation If a user opens a table properties dialog, and tries to change the collation of a column, he gets a DROP COLUMN followed by a ADD COLUMN statements. If a user opens a column properties dialog (without the table properties dialog first), and

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: [...] Attached is a patch which fixes #328. Currently if you change a column's collation, it actually drops the column. This changes it so that it issues an ALTER TYPE to adjust the collation instead. Pushed on master. Thanks for yet

Re: [pgadmin-hackers] Website

2011-07-19 Thread Guillaume Lelarge
On Mon, 2011-07-18 at 23:48 +0200, Jasmin Dizdarevic wrote: OK, my dear twins ;) I've excepted an similar answer from you Dave, so I changed the design based on Guillaume's suggestions. 2011/7/18 Dave Page dp...@pgadmin.org On Sun, Jul 17, 2011 at 2:59 PM, Jasmin Dizdarevic

Re: [pgadmin-hackers] Website

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 09:47 +0100, Dave Page wrote: On Tue, Jul 19, 2011 at 9:38 AM, Jasmin Dizdarevic jasmin.dizdare...@gmail.com wrote: [...] @Guillaume: I never saw somebody complaining about google, but they did a redesign. Because of marketing reasons, it's important to do this from

Re: [pgadmin-hackers] Handling connection loss

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 09:53 +0100, Dave Page wrote: On Mon, Jul 18, 2011 at 9:11 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Did some tests and found something weird. I connect pgadmin to a database, I look into some objects with pgAdmin's browser. Then, I stop PostgreSQL

Re: [pgadmin-hackers] Handling connection loss

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 10:56 +0100, Dave Page wrote: On Tue, Jul 19, 2011 at 10:19 AM, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 09:53 +0100, Dave Page wrote: On Mon, Jul 18, 2011 at 9:11 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Did some tests

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 10:51 +0100, Dave Page wrote: On Fri, Jul 15, 2011 at 10:41 PM, Guillaume Lelarge guilla...@lelarge.info wrote: On Fri, 2011-07-15 at 21:43 +0200, Guillaume Lelarge wrote: On Fri, 2011-07-15 at 11:41 +0530, Ashesh Vashi wrote: Sorry - I was checking master, did

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 20:00 +0100, Dave Page wrote: On Tue, Jul 19, 2011 at 7:50 PM, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 10:51 +0100, Dave Page wrote: On Fri, Jul 15, 2011 at 10:41 PM, Guillaume Lelarge guilla...@lelarge.info wrote: On Fri, 2011-07-15

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 09:32 +0200, Guillaume Lelarge wrote: On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: [...] Attached is a patch which fixes #328. Currently if you change a column's collation, it actually drops the column. This changes it so that it issues an ALTER TYPE

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 20:43 +0100, Thom Brown wrote: On 19 July 2011 08:32, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: [...] Attached is a patch which fixes #328. Currently if you change a column's collation, it actually drops

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-19 Thread Guillaume Lelarge
On Sun, 2011-07-17 at 23:17 +0200, Vladimir Kokovic wrote: OK Now that we can copy on the same schema, it shouldn't ask for an extension, but for the complete name. I do not know how to do when the table has objects that each has a name! CREATE TABLE gk_vrsta_naloga_vk --NAME1 (

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 21:07 +0100, Dave Page wrote: On Tue, Jul 19, 2011 at 8:27 PM, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 09:32 +0200, Guillaume Lelarge wrote: On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: [...] Attached is a patch which fixes

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 21:44 +0100, Dave Page wrote: On Tue, Jul 19, 2011 at 8:06 PM, Guillaume Lelarge guilla...@lelarge.info wrote: There's no Makefile there. Did you forget to check it in? Oops, forgot this one. The fact that Makefile is in the .gitignore file didn't help. So

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 22:32 +0100, Dave Page wrote: On Tuesday, July 19, 2011, Guillaume Lelarge guilla...@lelarge.info wrote: On Tue, 2011-07-19 at 21:44 +0100, Dave Page wrote: On Tue, Jul 19, 2011 at 8:06 PM, Guillaume Lelarge guilla...@lelarge.info wrote: There's no Makefile

Re: [pgadmin-hackers] Ticket 298: bug on pg_hba.conf editor

2011-07-18 Thread Guillaume Lelarge
On Mon, 2011-07-18 at 09:41 +0100, Dave Page wrote: On Sun, Jul 17, 2011 at 4:13 PM, Guillaume Lelarge guilla...@lelarge.info wrote: On Sun, 2011-07-17 at 11:30 +0200, Guillaume Lelarge wrote: On Sun, 2011-07-17 at 10:12 +0100, Dave Page wrote: On Saturday, July 16, 2011, Guillaume

Re: [pgadmin-hackers] Ticket 298: bug on pg_hba.conf editor

2011-07-18 Thread Guillaume Lelarge
On Mon, 2011-07-18 at 14:40 +0200, Guillaume Lelarge wrote: On Mon, 2011-07-18 at 09:41 +0100, Dave Page wrote: On Sun, Jul 17, 2011 at 4:13 PM, Guillaume Lelarge guilla...@lelarge.info wrote: On Sun, 2011-07-17 at 11:30 +0200, Guillaume Lelarge wrote: On Sun, 2011-07-17 at 10:12 +0100

Re: [pgadmin-hackers] Handling connection loss

2011-07-18 Thread Guillaume Lelarge
On Mon, 2011-07-18 at 15:18 +0100, Dave Page wrote: I've been sufficiently annoyed by Josh's discovery that the reconnection changes in 1.14 are still broken in some situations that I've spent most of the day hacking on this. It's become pretty clear to me that the current code structure

Re: [pgadmin-hackers] Prevent duplicate attributes

2011-07-18 Thread Guillaume Lelarge
On Mon, 2011-07-18 at 21:06 +0100, Thom Brown wrote: On 14 July 2011 10:31, Thom Brown t...@linux.com wrote: On 14 July 2011 10:24, Guillaume Lelarge guilla...@lelarge.info wrote: So, you're working on fixing it, right? Possibly ;) : http://code.pgadmin.org/trac/ticket/329 I haven't

[pgadmin-hackers] pgAdmin III commit: Prevent duplicate members' names in a composite typ

2011-07-18 Thread Guillaume Lelarge
Prevent duplicate members' names in a composite type When adding columns in the column dialogue window, it allows you to add a column with the same name as an existing one, which will result in SQL which will fail to run. Branch -- master Details ---

Re: [pgadmin-hackers] Prevent duplicate attributes

2011-07-18 Thread Guillaume Lelarge
On Mon, 2011-07-18 at 22:15 +0100, Thom Brown wrote: On 18 July 2011 21:55, Guillaume Lelarge guilla...@lelarge.info wrote: On Mon, 2011-07-18 at 21:06 +0100, Thom Brown wrote: On 14 July 2011 10:31, Thom Brown t...@linux.com wrote: On 14 July 2011 10:24, Guillaume Lelarge guilla

[pgadmin-hackers] pgAdmin III commit: Add new authentication, and database options

2011-07-17 Thread Guillaume Lelarge
Add new authentication, and database options Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=693cd1d6cc573e40f202fa3bb6e145690d4a76be Modified Files -- pgadmin/dlg/dlgHbaConfig.cpp | 43 +++--

[pgadmin-hackers] pgAdmin III commit: In the pg_hba.conf editor, always displays groups a

2011-07-17 Thread Guillaume Lelarge
In the pg_hba.conf editor, always displays groups and users Before, we used to only display groups, unless the option ShowUsersForPrivileges is set to true. But this dialog has nothing to do with privileges. Branch -- REL-1_14_0_PATCHES Details ---

[pgadmin-hackers] pgAdmin III commit: Add new authentication, and database options

2011-07-17 Thread Guillaume Lelarge
Add new authentication, and database options Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=20b13c4009a8624312ccdbf0d70c83e5ed1298e1 Modified Files -- pgadmin/dlg/dlgHbaConfig.cpp | 43

Re: [pgadmin-hackers] Ticket 298: bug on pg_hba.conf editor

2011-07-17 Thread Guillaume Lelarge
On Sun, 2011-07-17 at 10:12 +0100, Dave Page wrote: On Saturday, July 16, 2011, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-16 at 21:11 +0100, Dave Page wrote: On Sat, Jul 16, 2011 at 1:12 PM, Guillaume Lelarge guilla...@lelarge.info wrote: Hi, I worked a bit

Re: [pgadmin-hackers] Website

2011-07-17 Thread Guillaume Lelarge
On Sun, 2011-07-17 at 12:50 +0200, Jasmin Dizdarevic wrote: 2011/7/17 Dave Page dp...@pgadmin.org On Saturday, July 16, 2011, Guillaume Lelarge guilla...@lelarge.info wrote: On Sat, 2011-07-16 at 22:53 +0200, Jasmin Dizdarevic wrote: Hi

<    4   5   6   7   8   9   10   11   12   13   >