Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-10-28 Thread Linreg
ew comments > and send the updated patch ? Yes. Okay. > Thanks, > Neel Patel > > On Fri, Oct 25, 2013 at 12:04 PM, Neel Patel > wrote: > > Hi, > > > > On Thu, Oct 24, 2013 at 2:59 PM, Linreg wrote: > >> ** > >&g

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-10-28 Thread Linreg
Hi, > > 1.) > > > > it is system dependent. On my SUSE system pibpg-header to be > > installed under the pgsql directory. > > > > Example: /usr/include/pgsql/libpq-fe.h > > As we discussed we should remove the pgsql/ prefix. of course, i will correct it. > > > 2.) > > > > I changed tmpnam to

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-10-24 Thread Linreg
Hi, I'll change it. (without prefix!) Thomas > > > 1.) > > > > > > it is system dependent. On my SUSE system pibpg-header to be installed > > > > under > > > > > the pgsql directory. > > > > > > Example: /usr/include/pgsql/libpq-fe.h > > > > What did the previous code do? That worked. Typic

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-10-24 Thread Linreg
Am Donnerstag, 24. Oktober 2013, 11:11:21 schrieb Neel Patel: > Hi, > > Below are the review comments. Compile and tested in Linux. > > 1) During compilation we got the following error in "connection.h" > > error: pgsql/libpq-fe.h: No such file or directory > > To solve the above error we chang

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-09-19 Thread Linreg
Am Donnerstag, 19. September 2013, 13:34:47 schrieb Dave Page: > On Tue, Sep 17, 2013 at 1:59 PM, Linreg wrote: > > Hi Dave, > > > > > > > > Connection Pooling: > > > > okay. I will reimplementing the connection pool. > > > > A

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-09-17 Thread Linreg
Hi Dave, Connection Pooling: okay. I will reimplementing the connection pool. Am Sonntag, 15. September 2013, 15:02:03 schrieb Dave Page: > > > Another problem that I've noticed is that you've unconditionally > > > > > > changed the logging format to be pipe delimited. This is also not > > >

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-09-15 Thread Linreg
Hi Dave, > > This change is unrelated to porting to pure C++, and needs to be > discussed and (if acceptable) implemented as a separate patch. I'm not > convinced it's an appropriate change at all - I certainly work with > customer who do not use a connection pooler for various reasons, and > rely

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-09-13 Thread Linreg
Hi Dave, > > - You seem to have hard-coded the exit code from Windows batch job > > > > steps to 1. Why? > > > > > > > > => i changed back to git-head version. i believe it come from old 3.3.0 > > source code version. I will never make such things. > > I'm working on git-head (d6c5a807110a7e

Re: [pgadmin-hackers] pgAgent: I want to make a port to C++ Only

2013-09-10 Thread Linreg
Hello Dave, + move pgagent schema in separat database (better access rights...) this need a patch for pgadmin > > That's very unlikely to be accepted - we intentionally use the > maintenance database for that, rather than forcing the user to use a > different one. > I regard the postgres databas

Re: [pgadmin-hackers] pgAgent: I want to make a port to C++ Only

2013-09-09 Thread Linreg
Am Montag, 9. September 2013, 08:31:11 schrieb Dave Page: > On Mon, Sep 9, 2013 at 7:49 AM, Linreg wrote: > > Hello @All, > > > > i want to make a port away from wxWidgets to a c++ only job scheduler. > > > > Why: > > > > I want to reduce depend

[pgadmin-hackers] pgAgent: I want to make a port to C++ Only

2013-09-08 Thread Linreg
Hello @All, i want to make a port away from wxWidgets to a c++ only job scheduler. Why: I want to reduce dependencies. A framework like wxWidgets should not installed to server systems without GUI (linux or windows server) C++ libs are already installed in most cases. i want to push / support t