Re: [pgadmin-hackers] PATCH/s: RM#1387 - Bad handling of missing connection database server

2016-08-24 Thread Murtuza Zabuawala
ire page now click on expand server-group, loading/expanding server group goes infinite. Thanks, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Aug 24, 2016 at 2:17 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com >

[pgadmin-hackers] PATCH: id and pid is not being sent in response (pgAdmin4)

2016-08-24 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where when user creates new domain, it missing id & pid in response. RM#1586 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1586.patch Description: Binary data -- Sent

Re: [pgadmin-hackers] Fixed RM #1209 Trigger issues through right click

2016-08-23 Thread Murtuza Zabuawala
efer: server_groups.js for custom dialog size (width: '650px' should work) Thanks, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Aug 23, 2016 at 12:38 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi All >

Re: [pgadmin-hackers] Fixed RM #1209 Trigger issues through right click

2016-08-23 Thread Murtuza Zabuawala
Sure. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Aug 24, 2016 at 10:15 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Murtuza, > > Can you please review it? > > -- > > Thanks

[pgadmin-hackers] PATCH: Remove hard coded string 'localhost' (pgAdmin4)

2016-08-23 Thread Murtuza Zabuawala
Hi, PFA minor patch to remove hard coded message from console *Starting pgAdmin 4. Please navigate to http://localhost:5050 in your browser.* -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company misc_changed_hardcoded_msg.patch Description

Re: [pgadmin-hackers] PATCH: SlickGrid integration in query tool (pgAdmin4)

2016-08-23 Thread Murtuza Zabuawala
Hi, PFA minor add-on patch on previous Slickgrid v2 patch to remove console log messages from JS.. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Aug 23, 2016 at 3:47 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-18 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch with auto scrolling & also fixed duplicate messages issue. Please review. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Aug 17, 2016 at 7:09 PM, Dave Page <dp...@pgad

[pgadmin-hackers] PATCH: To fix the issue in configuration error message (pgAdmin4)

2016-08-18 Thread Murtuza Zabuawala
ages. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/backup/templates/backup/js/backup.js b/web/pgadmin/tools/backup/templates/backup/js/backup.js index ea2dbb3..a13a31c 100644 --- a/web/pgadmin/tools/backup/templ

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-16 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Aug 16, 2016 at 8:16 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Tue, Aug 16, 2016 at 7:10 AM, Murtuza Zabuawala &g

[pgadmin-hackers] PATCH: To fix the issue in table node displaying catalog tables (pgAdmin4)

2016-08-16 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where system level catalog are also displayed in PPAS server under relation of create new table like option. RM#1530 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

Re: [pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-16 Thread Murtuza Zabuawala
Hi Dave, PFA patch with incremental messages. RM#1523 Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Aug 9, 2016 at 6:58 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Tue, Aug 9, 2016 at

[pgadmin-hackers] PATCH: To fix the of foreign tables (pgAdmin4)

2016-08-16 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in foreign tables node where it was displaying catalog tables in inherits options causing internal server error. RM#1520 Additionally also moved hard coded sql for fetching types in template. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com

[pgadmin-hackers] PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4)

2016-08-09 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where message panel was showing incomplete info. We may still miss some messages from Psycopg2 driver due to limited size of notices queue. (RM#1523) Regards, Murtuza diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py

[pgadmin-hackers] PATCH: To handle numeric type display (pgAdmin4)

2016-08-04 Thread Murtuza Zabuawala
Hi, Please find minor patch to handle numeric/float type display. RM#1463 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1463.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

Re: [pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-08-01 Thread Murtuza Zabuawala
Hi Dave, We have to added it because postgres format_type() function do not provide us type with 'public' schema prefix to it, due to which wrong SQL's are getting generated. Rest other types are pre fixed with their respective schema as required. Thanks, Murtuza -- Regards, Murtuza Zabuawala

[pgadmin-hackers] PATCH: Fixed typo in security labels macro (pgAdmin4)

2016-07-29 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix typo in security labels macro. RM#1457 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fixed_typo_SecLabls_macro.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-07-28 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch to fix issue in functions which was due to improper handing of nested quoting of types in templates. I also fixed it in Table/Column node. Please review. Regards, Murtuza misc_fixes_encoding_and_ident.patch Description: Binary data -- Sent via pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-07-27 Thread Murtuza Zabuawala
Okay, Let me check on that. Meanwhile I'm attaching patch for making Provider optional in security labels control. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 27, 2016 at 5:04 PM, Dave Page <

Re: [pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-07-26 Thread Murtuza Zabuawala
kets, RM#1307 RM#1479 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Fix_encoding_all_nodes.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to

[pgadmin-hackers] PATCH: To disable SQLALCHEMY to tracking (pgAdmin4)

2016-07-26 Thread Murtuza Zabuawala
Hi All, PFA patch which will disable SQLALCHEMY track modification feature as it put overhead on system. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company disable_sqlalchemy_tracking.patch Description: Binary data -- Sent via pgadmin

[pgadmin-hackers] PATCH: Encoding issue with qtLiteral function (pgAdmin4)

2016-07-22 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue when we use qtLiteral function and user enters special characters(like emojis) which it fails to handle. RM#1307 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1307.patch Description: Binary data

[pgadmin-hackers] PATCH: To fix the issue where AJAX request do not get fired second time (pgAdmin4)

2016-07-20 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where AJAX request do not get fired second time. (RM#1462) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1462.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers

[pgadmin-hackers] PATCH: To fix adding/updating Security Labels in various nodes (pgAdmin4)

2016-07-19 Thread Murtuza Zabuawala
; Fixed ROLE--> Fixed SCHEMA --> Fixed SEQUENCE--> Fixed TYPE--> Fixed VIEW--> Fixed EVENT TRIGGER --> Fixed FOREIGN TABLE --> Fixed FUNCTION--> Fixed LANGUAGE--> Fixed Please

Re: [pgadmin-hackers] PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4)

2016-07-18 Thread Murtuza Zabuawala
Hi Dave, Please find patch to fix the issue for interval type casting. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 15, 2016 at 4:31 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > >

Re: [pgadmin-hackers] PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

2016-07-15 Thread Murtuza Zabuawala
by this patch, so I'll commit that as there's > a ticket for the other bit already). > > On Fri, Jul 15, 2016 at 12:49 PM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: > > ++ FYI, > > > > If you provide alias, it'll give you proper result :)

Re: [pgadmin-hackers] PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

2016-07-15 Thread Murtuza Zabuawala
++ FYI, If you provide alias, it'll give you proper result :) SELECT CURRENT_TIMESTAMP as ts, CAST ( CURRENT_TIMESTAMP AS text ) as ts_as_text; -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 15, 2016 at 5:14 PM, Murtuza

Re: [pgadmin-hackers] PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

2016-07-15 Thread Murtuza Zabuawala
Hi Dave, Yes, I am aware of that, but the issue you mentioned is due to psycopg2 DictCursor issue which I have already mentioned earlier (RM#1409) https://github.com/psycopg/psycopg2/issues/454. The patch is for different issue (RM#1438). -- Regards, Murtuza Zabuawala EnterpriseDB: http

[pgadmin-hackers] PATCH: security label is not being added/updated for MATERIALIZED VIEW

2016-07-14 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in MATERIALIZED VIEW node where user was not able to add/update security label. (RM#1458) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1458.patch Description: Binary data -- Sent via pgadmin

[pgadmin-hackers] PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

2016-07-14 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where if user use cast function and it causes freeze in query tool. (RM#1438) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1438.patch Description: Binary data -- Sent via pgadmin-hackers mailing

[pgadmin-hackers] PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4)

2016-07-14 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in timestamp datatype(s) displaying with time as 00:00 (RM#1437) The issue was with backgrid datetime cell which do not fully support ISO-8601 datetime format. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgadmin-hackers] PATCH: To fix issue using PUBLIC as role (pgAdmin4)

2016-07-13 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where user was not able to select 'PUBLIC' as role in privileges. (RM#1416) This issue was due to previous commit: b78b3904cd7e5a8edf -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1416.patch

[pgadmin-hackers] Regarding issue in psycopg2 driver handling duplicate field names in query (pgAdmin4)

2016-07-13 Thread Murtuza Zabuawala
Hi, I was looking into RM#1409 and found that it is issue with psycopg2 driver handling DictCursor result which is not handling duplicate field names. I have also raised issue for the same https://github.com/psycopg/psycopg2/issues/454 -- Regards, Murtuza Zabuawala EnterpriseDB: http

[pgadmin-hackers] PATCH: Comments are not visible in Language node (pgAdmin4)

2016-07-12 Thread Murtuza Zabuawala
Hi, PFA patch to fix RM#1412, where comments are not visible in sql pane for Languages node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1421.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Murtuza Zabuawala
Please refer, http://stackoverflow.com/questions/3828723/why-should-we-not-use-sys-setdefaultencodingutf-8-in-a-py-script -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 12, 2016 at 4:18 PM, Surinder Kumar < surinder

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Murtuza Zabuawala
May be because of Python2.7 but if you try in Python3. It works. we can use PEP 0263 <http://www.python.org/dev/peps/pep-0263/> to fix this issue. // # -*- coding: utf-8 -*- -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tu

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Murtuza Zabuawala
Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 12, 2016 at 3:27 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *What is happening in code?* > Database is creat

[pgadmin-hackers] PATCH: Unable to create procedure (pgAdmin4)

2016-07-12 Thread Murtuza Zabuawala
Hi, PFA patch to fixed the issue in procedure node where user were not able to create new procedure when they provide arguments. (RM#1449) To fix the issue we used qtTypeIdent in sql template for datatype, earlier it was qtIdent which was causing issue. -- Regards, Murtuza Zabuawala

[pgadmin-hackers] PATCH: To update table dialog column definition

2016-07-12 Thread Murtuza Zabuawala
tion in the grid cannot be toggled without opening advanced options.* This has been fixed already RM#1235, Once user provides column name it will gets enable. *3) Fields are missing from the grid: length, precision, not null. Inherited from should not be there.* Fixed Please review. -- Regards, Mur

Re: [pgadmin-hackers] PATCH: To fix salt generation in session.py

2016-07-11 Thread Murtuza Zabuawala
Hi, Tested, I'm able to login now. Thanks, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > Hi Murtuza, > > Can you please

Re: [pgadmin-hackers] PATCH: To fix salt generation in session.py

2016-07-11 Thread Murtuza Zabuawala
Hi, Please hold on in this patch, Need additional changes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > W

[pgadmin-hackers] PATCH: To fix salt generation in session.py

2016-07-11 Thread Murtuza Zabuawala
= ''.join(random.sample(string.lowercase+string.digits, 20))* *AttributeError: module 'string' has no attribute 'lowercase'* -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Fix_sessions.patch Description: Binary data -- Sent via pgadm

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-07-03 Thread Murtuza Zabuawala
Hi Dave, I'm unable to reproduce the issue mentioned by you on my side, would you please provide console log/error ? Regards, Murtuza On 30-Jun-2016 6:26 PM, Dave Page <dp...@pgadmin.org> wrote: > > Hi > > On Thu, Jun 30, 2016 at 11:37 AM, Murtuza Zabuawala

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-06-30 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. Tested with json/json[]/jsonb/jsonb[] (on browsers & runtime). Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 30, 2016 at 1:26 PM, Dave Page <dp...@pgadmin.org> wrote:

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-06-30 Thread Murtuza Zabuawala
Hi Dave, text type works fine even if it has json data. Regards, Murtuza > On 30-Jun-2016, at 1:21 pm, Dave Page <dp...@pgadmin.org> wrote: > > On Thu, Jun 30, 2016 at 8:11 AM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: >> Hi, >> &

Re: [pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-06-30 Thread Murtuza Zabuawala
Hi, PFA updated patch, we have created backgrid jsonb type cell which will work within browser & runtime. Regards, Murtuza On 29-Jun-2016, at 3:54 pm, Dave Page <dp...@pgadmin.org> wrote: Hi On Wed, Jun 29, 2016 at 10:32 AM, Murtuza Zabuawala <murtuza.zabuaw...@enterprisedb.co

Re: [pgadmin-hackers] PATCH: 'serial' like types were missing while creating table/column (pgAdmin4)

2016-06-29 Thread Murtuza Zabuawala
Apologies, Please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 29, 2016 at 4:49 PM, Dave Page <dp...@pgadmin.org> wrote: > That's the same patch! > > On Wed, Jun 29, 2016 at 11:54 AM, Mu

Re: [pgadmin-hackers] PATCH: 'serial' like types were missing while creating table/column (pgAdmin4)

2016-06-29 Thread Murtuza Zabuawala
Hi Dave, As suggested please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 29, 2016 at 3:37 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Tue, Jun 28, 2016 at 12:30 PM, Mu

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-06-29 Thread Murtuza Zabuawala
:40 pm, Dave Page <dp...@pgadmin.org> wrote: > > On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: >> Yes Dave, I agree that downloading files has been supported in browsers >> since long . >> >> But in ge

[pgadmin-hackers] PATCH: to fix jsonb type rendering in runtime (pgAdmin4)

2016-06-29 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue of jsonb type rendering issue in runtime. RM#1404 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1404.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers

[pgadmin-hackers] PATCH: 'serial' like types were missing while creating table/column (pgAdmin4)

2016-06-28 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where 'serial' like types were not listed under type combobox while creating new table/column. RM#1393 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1393.patch Description: Binary data -- Sent via

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-06-28 Thread Murtuza Zabuawala
ent side in browser itself. > On 28-Jun-2016, at 2:44 pm, Dave Page <dp...@pgadmin.org> wrote: > > On Tue, Jun 28, 2016 at 7:08 AM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: >> Hi Dave, >> >> Yes, Safari is exception case because it do

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-06-28 Thread Murtuza Zabuawala
only working on Chrome and with this patch it will work with Chrome/Firefox/IE. Regards, Murtuza > On 27-Jun-2016, at 9:35 pm, Dave Page <dp...@pgadmin.org> wrote: > > Hi > > On Mon, Jun 27, 2016 at 1:08 PM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com&

[pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-06-27 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue for downloading query output as CSV not working in Firefox & IE. Also fixes the issue that HTML tags were also appended in columns title in CSV header. Browser side fix for -> RM#1405 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterpris

Re: [pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

2016-06-24 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue RM#1292. Earlier patch was not handling spaces properly. e.g- If user creates any objects which has spaces in its name then it fails to parse it next time user select it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [pgadmin-hackers] PACTH: To fix the issue while selecting primary key in table (pgAdmin4)

2016-06-24 Thread Murtuza Zabuawala
Hi Dave, I have fixed the issue with Switch control, now it's working as expected along with DepsCell functionality. PFA patch RM#1235 with Switch Cell. While debugging the issue I have found typo in "index.js" which is also fixed with patch. -- Regards, Murtuza Zabuawala Enterpri

[pgadmin-hackers] PATCH: To add Maintenance support on Index/Primary key/Unique (pgAdmin4)

2016-06-24 Thread Murtuza Zabuawala
Hi, PFA patch to add Maintenance support on Index/Primary key/Unique constraint. RM#1390 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1390.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers

Re: [pgadmin-hackers] PATCH:Treeview item sorting (pgAdmin4)

2016-06-23 Thread Murtuza Zabuawala
Hi Dave, Ashesh picked up on this task. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 23, 2016 at 3:18 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > Can you please check this is still relevant, an

[pgadmin-hackers] PATCH: Statistics for Tablespace (pgAdmin4)

2016-06-23 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in tablespace stats, earlier it was not displaying any stats. RM#1196 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1196.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] PATCH: Allow default ACLs to be specified when creating a schema (pgAdmin4)

2016-06-23 Thread Murtuza Zabuawala
Hi, PFA patch, This will allow us to set default ACLs to be specified while creating a schema. (RM#1108) Additionally misc changes in templates for SQL indentation. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1108.patch

[pgadmin-hackers] PACTH: To fix the issue while selecting primary key in table (pgAdmin4)

2016-06-22 Thread Murtuza Zabuawala
Hi, PFA minor patches to fix two issues mentioned in RM#1235 & RM#1234. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py b/web/pgadmin/bro

Re: [pgadmin-hackers] PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)

2016-06-22 Thread Murtuza Zabuawala
Hi Dave, I checked the code it's already implemented, pgAdmin4.py will upgrade schema automatically on subsequent run. Thanks, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 22, 2016 at 2:10 PM, Murtuza Zabuawala

Re: [pgadmin-hackers] PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)

2016-06-22 Thread Murtuza Zabuawala
Sure. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 22, 2016 at 1:35 PM, Dave Page <dp...@pgadmin.org> wrote: > On Wed, Jun 22, 2016 at 7:14 AM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com

[pgadmin-hackers] PATCH: Do not allow to drop current maintenance DB

2016-06-22 Thread Murtuza Zabuawala
Hi PFA patch to fix the issue mentioned in RM#1382. To fix the issue we will not display drop option on maintenance db. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases

[pgadmin-hackers] PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)

2016-06-22 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in server port check constraint validation which was not allowing user to save port 65535. (RM#1388) We have changed in server table definition hence user has to run "setup.py" again to fix the issue. -- Regards, Murtuza Zabuawala Enterpri

Re: [pgadmin-hackers] PATCH: To fix the issue in Exclusion constraint (pgAdmin4)

2016-06-21 Thread Murtuza Zabuawala
++ Typo corrected. > On 21-Jun-2016, at 4:15 pm, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: > > Hi, > > PFA patch to fix the issue in Exclusion constraint where we were missing > validation of operator field for column, causing incomp

[pgadmin-hackers] PATCH: To fix the issue in exclude constraint (pgAdmin4)

2016-06-21 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in exclude constraint where we were missing validation of operator field for column, causing incomplete create sql. (RM#1301) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1301.patch Description

[pgadmin-hackers] PATCH: Unable to open Query tool (pgAdmin4)

2016-06-21 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in query tool where it was not able to handle special characters in editor title. (RM#1381) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1381.patch Description: Binary data -- Sent via pgadmin

[pgadmin-hackers] PATCH: To fix the issue in role node (pgAdmin4)

2016-06-20 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where save button was not getting enable when user revoke ADMIN option from Role privileges. Issue: validation callback was missing in the control model. (RM#1302) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgadmin-hackers] PATCH: To fixed the issue in Materialized view (pgAdmin4)

2016-06-20 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue in Materialized view where user was not able to create Materialized view with PPAS 9.5 due to incorrect template path. (RM#1379) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1379.patch

[pgadmin-hackers] PATCH: To fix the issue in Restore/Backup dialog

2016-06-17 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in backup/restore while selecting section-> data option, it was throwing error. RM#1219 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1219.patch Description: Binary data -- Sent via pgadmin-hack

[pgadmin-hackers] PATCH: To fix incorrect start date in Backup/Restore dialog (pgAdmin4)

2016-06-17 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue which was showing incorrect datetime in Backup/Restore dialog. (RM#1377) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1377.patch Description: Binary data -- Sent via pgadmin-hackers mailing

Re: [pgadmin-hackers] PATCH: Patch to fix issue in trigger function (pgAdmin4)

2016-06-17 Thread Murtuza Zabuawala
++ Issue: Error was due to wrong ‘edbspl’ language selection, we have now exclude it for trigger function creation. > On 17-Jun-2016, at 3:50 pm, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: > > Hi, > > PFA minor patch to fix the issue where we

[pgadmin-hackers] PATCH: Patch to fix issue in trigger function (pgAdmin4)

2016-06-17 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where we were getting 'index out of range' while creating trigger function. (RM#1212) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1212.patch Description: Binary data -- Sent via pgadmin

[pgadmin-hackers] PATCH: To fix the issue in date validation in role

2016-06-16 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue of date validation while creating new role. RM#1370 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1370.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers

[pgadmin-hackers] PATCH: To fix the issue using complex password

2016-06-16 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue while connecting server using complex password in pgAdmin4. RM#1371 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1371.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] PATCH: To fix error displaying bytea field (pgAdmin4)

2016-06-16 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where query tool was not able to show/handle bytea field. This patch will two issues, - RM#1350 (To handle bytea) - RM#1309 (To handle NaN) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] Re: [pgadmin-hackers] PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4)

2016-06-15 Thread Murtuza Zabuawala
Hi, PFA updated patch for comments given over last patch. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 14, 2016 at 7:25 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Mon, Jun 13,

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-15 Thread Murtuza Zabuawala
Hi, PFA patch to add stats on Sequences/Function/Trigger functions collection nodes. Please review. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 14, 2016 at 1:49 PM, Murtuza Zabuawala < murtuza.zab

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-14 Thread Murtuza Zabuawala
Hi Dave, I copied pgAdmin3 behaviour, I’ll implement it in pgAdmin4 :) Thanks, Murtuza > On 13-Jun-2016, at 5:51 pm, Dave Page <dp...@pgadmin.org> wrote: > > On Mon, Jun 13, 2016 at 12:29 PM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: >>

[pgadmin-hackers] PATCH: To have validation messages on status panel only (pgAdmin4)

2016-06-14 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue mentioned in RM#1281, We have removed error messages from standard Backform control rather display validation error messages only on status panel. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-13 Thread Murtuza Zabuawala
un-2016, at 8:56 pm, Dave Page <dp...@pgadmin.org> wrote: > > On Thu, Jun 9, 2016 at 9:21 AM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: >> Hi Ashesh/Dave, >> >> I tried setting 'track_functions' to false in postgresql.conf. but then I a

[pgadmin-hackers] PATCH: To fixed the issue in server node (pgAdmin4)

2016-06-13 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue for RM#1144. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1144.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes

[pgadmin-hackers] PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4)

2016-06-13 Thread Murtuza Zabuawala
Hi, PFA patch to add "Move objects..” functionality in tablespace node. (RM#1286) Additionally I have removed pre_9.1 sql's & align SQL line indentation as well. Please review. Regards, Murtuza RM_1286.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] PATCH: To fixed uncomment issue (pgAdmin4)

2016-06-13 Thread Murtuza Zabuawala
Hi, PFA patch to fix the uncommenting issue with various nodes, due to this user was not able to remove comments from objects. Please review. (RM#1331) Regards, Murtuza fixed_uncommenting_issue.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] Pgadmin4: emoji in comments

2016-06-10 Thread Murtuza Zabuawala
a fresh venv right? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com <http://pgsnake.blogspot.com/> > Twitter: @pgsnake > > EnterpriseDB UK:http://www.enterprisedb.com <http://www.enterprisedb.com/> > The Enterprise PostgreSQL Company > > On

Re: [pgadmin-hackers] Pgadmin4: emoji in comments

2016-06-10 Thread Murtuza Zabuawala
object as parameter and using that we can prepare "adapt" for encoding used by current connection but this will affects almost every module (sql template related changes). Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreS

Re: [pgadmin-hackers] PATCH: Reset view/layout (pgAdmin4)

2016-06-09 Thread Murtuza Zabuawala
Hi, PFA updated patch, I have shifted it to File menu. Please review. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 8, 2016 at 5:19 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On W

Re: [pgadmin-hackers] PATCH: TO fix issue in Role node (pgAdmin4)

2016-06-09 Thread Murtuza Zabuawala
Hi, Apologies, It was partial patch, missed JS side changes in last patch. Please review updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 8, 2016 at 5:35 PM, Dave Page <dp...@pgadmin.org> wrote: > On

[pgadmin-hackers] PATCH: Reset view/layout (pgAdmin4)

2016-06-08 Thread Murtuza Zabuawala
causing strange errors which is already fixed by Surinder .(Patch Link <https://www.postgresql.org/message-id/CAM5-9D-ve7VSPHpjroHMxUr0C_YBAvS4tSnkZoqk70TA-tG8Wg%40mail.gmail.com> ) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company R

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-07 Thread Murtuza Zabuawala
Please fix the patch so that in such cases the pgAdmin 3 behaviour is followed, i.e. the table header is shown, but no rows (bug #1316). Also, please look at #1315 which you're at it :-) Thanks again. On Tue, Jun 7, 2016 at 12:27 PM, Murtuza Zabuawala <murtuza.zabuaw...@enterprisedb.com> wrot

[pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-07 Thread Murtuza Zabuawala
patches, 1) To update validation of object before using it (file: statistics.js) 2) To fix incorrect condition checking for privileges. Thanks to Surinder for reporting this issue. (file: privilege.js) Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com

Re: [pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

2016-06-06 Thread Murtuza Zabuawala
Hi, This will not work, this is generic issue and not specific to database name only, we need to do proper unescaping of special character for every object name. ( eg: create a schema with name as 'test\’ not go to table node and try to create table by selecting 'test\’ schema, it will fail

[pgadmin-hackers] PATCH: Security label was not properly handled (pgAdmin4)

2016-06-06 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in security label model validation where it was not properly throwing error on partial inputs. Additionally, I have updated tablespace required fields validation which not proper. (RM#1110) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com

[pgadmin-hackers] PATCH: TO fix issue in Role node (pgAdmin4)

2016-06-03 Thread Murtuza Zabuawala
Hi, PFA patch to fix an issue while creating role if user has set expire date. Current implements works only if datestyle is set to ISO,MDY in database for others it fails. (RM#1134) Additionally I've fixed unwanted space indentation issue in Database node. Please review. -- Regards, Murtuza

[pgadmin-hackers] PATCH: To fix issue in table node (pgAdmin4)

2016-06-03 Thread Murtuza Zabuawala
[on dashboard page], search icon was displaying on other dialog. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Fixed_Backgrid_seach.patch Description: Binary data RM_1300.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] PATCH: To fix the issue in Sequence node (pgAdmin4)

2016-06-03 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in Sequence node where it was not displaying ACL properly in SQL panel. RM#1298 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1298.patch Description: Binary data -- Sent via pgadmin-hackers mailing

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

2016-06-02 Thread Murtuza Zabuawala
Hi Dave/Ashesh, Please find patch for the dashboard issue, Please review it. I tried with both config options "threaded=True" & "threaded=False", In both cases this fix working fine. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enter

Re: [pgadmin-hackers] PATCH: To fix minor patches (pgAdmin4)

2016-06-02 Thread Murtuza Zabuawala
Hi, PFA updated patch for RM#1234. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 2, 2016 at 3:38 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote: > > On Wed, Jun 1, 2016 at 1:23

[pgadmin-hackers] PATCH: Fixed issue in Index node (pgAdmin4)

2016-06-02 Thread Murtuza Zabuawala
Hi, PFA patches to fixed the issue mentioned in RM#1283 RM#1285 RM#1287 Additionally I have fixed the issue where Columns collection was not disable in edit mode, adding new column was disabled but we were able to change the value of existing columns. -- Regards, Murtuza Zabuawala EnterpriseDB

Re: [pgadmin-hackers] PATCH: Fix the issue in JSON decoding (pgAdmin4)

2016-06-02 Thread Murtuza Zabuawala
n 2, 2016 at 12:04 PM, Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com > <mailto:murtuza.zabuaw...@enterprisedb.com>> wrote: > Hi, > > PFA patch to fix the issue in json decoding while dealing with date format, > causing QueryTool to fail to render data. &g

<    1   2   3   4   5   >