Re: [pgadmin-hackers] wxWidgets 2.9.2 compatibility

2011-07-15 Thread Peter Geoghegan
rself and writing a patch. It's probably simple enough. > I'll see if anything happens over the next few days, and if not, > commit the hack so we can proceed with the other issues (I figured out > the label-over-buttons thing - that's an easy, albeit somewhat tedious > fix)

Re: [pgadmin-hackers] wxWidgets 2.9.2 compatibility

2011-07-13 Thread Peter Geoghegan
y and produce a test-case, and send it to the wx guys. They're fairly responsive, I found. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make ch

Re: [pgadmin-hackers] wxWidgets 2.9.2 compatibility

2011-07-13 Thread Peter Geoghegan
hought was weird. Anyway, I think it's going to be tough for me to diagnose the problem without a Mac. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.or

Re: [pgadmin-hackers] Replication references

2011-06-20 Thread Peter Geoghegan
hat's likely to be in a language that isn't so widely spoken - it certainly won't be French or German. I'd be willing to live with a poor machine translation for a little while for those languages. If someone complains, the complaint is likely to be all we need to fix the proble

[pgadmin-hackers] wxWidgets 2.9 build - new incompatibilities

2011-04-12 Thread Peter Geoghegan
Looks like there is a new slew of incompatibilities that are inclined to break pgAdmin compilation against wxWidgets SVN head. I'll work on it throughout the week. Thanks for accommodating me by applying your patches early Guillaume. -- Peter Geoghegan       http://www.2ndQuadran

Re: [pgadmin-hackers] Planning for 1.14 Beta 1

2011-04-10 Thread Peter Geoghegan
On 10 April 2011 21:58, Guillaume Lelarge wrote: > FYI, I have four patches to push. I intended to do that tuesday evening, > but I can do that on monday evening if you prefer. This way, you could > work tuesday with almost all the code for 1.14. Okay, let's do that. -- P

Re: [pgadmin-hackers] Planning for 1.14 Beta 1

2011-04-10 Thread Peter Geoghegan
I would like to have "experimental support for wxWidgets 2.9" as a feature for this release - it might encourage some curious person to build against 2.9. I'll make sure that support hasn't broken tomorrow. It needs to be maintained going forward. -- Peter Geoghe

Re: [pgadmin-hackers] pgAdmin and pg_service.conf

2011-04-04 Thread Peter Geoghegan
ion a double, rather than an integer as returned by PQserverVersion()? Seems brittle, considering that some incredibly common values cannot be exactly represented as floating point numbers, such as 0.1 . -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

[pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token

2011-03-14 Thread Peter Geoghegan
alloc calls. Any ideas on this? > > Can you check that it still works on Windows and Mac OS X with this patch? This would of course explain the inconsistent behaviour across platforms - it was undefined. This is the the classic "strlen() doesn't include null terminated byte"

[pgadmin-hackers] Re: [pgadmin-hackers] Re: [pgadmin-hackers] error: expected initializer before ‘!’ token

2011-03-12 Thread Peter Geoghegan
xcept_png!->IsOk()) { ico_ex_hash_setop_except_png! = new wxIcon(); ico_ex_hash_setop_except_png!->CopyFromBitmap(*ex_hash_setop_except_png!_bmp); } return ico_ex_hash_setop_except_png!; } -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Dev

[pgadmin-hackers] error: expected initializer before ‘!’ token

2011-03-11 Thread Peter Geoghegan
location of the previous definition ../pgadmin/include/images/ex_hash_setop_except.pngc:4:52: error: expected initializer before ‘!’ token ../pgadmin/include/images/ex_hash_setop_except.pngc:182:41: error: expected initializer before ‘!’ token No doubt this has something to do with the XPM/PNG thing.

Re: [pgadmin-hackers] [pgAdmin III] #306: Visual feedback of disabled triggers

2011-03-06 Thread Peter Geoghegan
This is something we should have had a long time ago. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Updated OGL licence

2011-02-28 Thread Peter Geoghegan
quot; where inappropriate. -- Regards, Peter Geoghegan diff --git a/pgadmin/frm/frmEditGrid.cpp b/pgadmin/frm/frmEditGrid.cpp index 0cc9bd0..181eb9c 100644 --- a/pgadmin/frm/frmEditGrid.cpp +++ b/pgadmin/frm/frmEditGrid.cpp @@ -1671,7 +1671,6 @@ void sqlGridTextEditor::DoBeginEdit(const wxStri

[pgadmin-hackers] Re: wxWidgets 2.9 compatibility: Fix for sefault on table editor under GTK

2011-02-26 Thread Peter Geoghegan
You can remove the new "// pure virtual in wx 2.9+, doesn't exist in prior versions" comments, because wxGridCellTextEditor is intended to be a concrete class. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make

[pgadmin-hackers] wxWidgets 2.9 compatibility: Fix for sefault on table editor under GTK

2011-02-25 Thread Peter Geoghegan
r inheriting classes, but I left it there in anticipation of it becoming true and for consistency with sqlGridBoolEditor. -- Regards, Peter Geoghegan diff --git a/pgadmin/frm/frmEditGrid.cpp b/pgadmin/frm/frmEditGrid.cpp index edf403f..b1a861d 100644 --- a/pgadmin/frm/frmEditGrid.cpp +++ b/pgadmin/frm/f

Re: [pgadmin-hackers] Building with wx2.9 on Mac

2011-02-24 Thread Peter Geoghegan
On 24 February 2011 09:13, Dave Page wrote: > Clang compiles it just fine. So you still see the ambiguous overload error on GCC, but you don't see it on Clang? That strikes me as very unusual. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin

Re: [pgadmin-hackers] Building with wx2.9 on Mac

2011-02-23 Thread Peter Geoghegan
ited abnormally with code 1 at Thu Feb 24 03:07:36 -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Building with wx2.9 on Mac

2011-02-23 Thread Peter Geoghegan
You have pgAdmin compiling (though still not linking) with clang on your laptop, right? I suggest you use that to get a non-crappy error message. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http

Re: [pgadmin-hackers] Building with wx2.9 on Mac

2011-02-23 Thread Peter Geoghegan
http://trac.wxwidgets.org/ticket/6601 indicates that that flag is obsolete, and it's 7 years old. Does the absence of the flag have any noticeable behavioural effect? I doubt that it does. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-18 Thread Peter Geoghegan
alls from calling my write(bool) declaration, as they prefer that to write(const wxString&, const wxString&) . Anyway, none of the old declarations were called, and I saw no linker errors. -- Regards, Peter Geoghegan diff --git a/pgadmin/debugger/dlgDirectDbg.cpp b/pgadmin/debugger/dlgDirectD

Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-18 Thread Peter Geoghegan
be a problem for you. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-18 Thread Peter Geoghegan
occur with Read() overloads as things stand. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-18 Thread Peter Geoghegan
do you think? By the way, this isn't that much trouble. I've already finished with the write() overloads. We're mostly using the inline wrapper functions in sysSettings. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make cha

Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-17 Thread Peter Geoghegan
ython bindings. That's probably not that hard to do, and is a better, safer interface for us to use, considering that these calls are fairly prevalent. Objections? -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your su

Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-17 Thread Peter Geoghegan
On 17 February 2011 11:33, Dave Page wrote: > Hi Peter; > > Just so you're aware of this... I don't mind, but I also don't understand. How could changing the name of the function possibly affect the sort of datatype stored in the registry? -- Regards, Peter Geogheg

Re: [pgadmin-hackers] pgAdmin III commit: Ensure the embedded version of OGL builds properly

2011-02-16 Thread Peter Geoghegan
declaration and definition, as they apparently were for the poster of that bug report. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxOGL licence change

2011-02-16 Thread Peter Geoghegan
from displaying dirty big |\r| things everywhere. Objections? Actually, maybe this could be the justification for assigning portions of the copyright of each source file to the pgAdmin development team. :-) -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@pos

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-16 Thread Peter Geoghegan
Do you think you can produce a Cocoa build? How much of a difference will that have on pgAdmin's look and feel on Mac? It would be nice to see a few screenshots of that. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make chang

[pgadmin-hackers] wxOGL licence change

2011-02-16 Thread Peter Geoghegan
OGL source files incorrectly indicate that they're wxWindows licensed. How would you like to fix this? -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-16 Thread Peter Geoghegan
On 16 February 2011 19:59, Dave Page wrote: > Thanks applied - and then fixed on Windows :-) > > Next step - try a build with 2.9! > Cool. Don't forget - you need to build against wx SVN head. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] pgAdmin III commit: Include a variant of sysSettings::Write() that take

2011-02-16 Thread Peter Geoghegan
t about ctlListView? The fact that its AppendYesNoItem() member function doesn't overload AppendItem() is, as I said at the time, logical, because you aren't actually appending a true or false value - you're appending a "Yes" or a "No". -- Regards, Peter Geoghegan --

Re: [pgadmin-hackers] pgAdmin III commit: Include a variant of sysSettings::Write() that take

2011-02-16 Thread Peter Geoghegan
h of those classes. The only reason that a call like this doesn't work with my code presently: sysSettings foo; foo.Write(true); is because we have an ambiguous conversion error (should it be a long or an int?). -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadm

Re: [pgadmin-hackers] pgAdmin III commit: Somehow forgot to commit this.

2011-02-16 Thread Peter Geoghegan
superset of this patch. There will be merge conflicts. Would you like me to produce a new patch without merge conflicts for your convenience? -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.

Re: [pgadmin-hackers] pgAdmin III commit: Somehow forgot to commit this.

2011-02-16 Thread Peter Geoghegan
sel, (wxClientData *)newconn); -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-15 Thread Peter Geoghegan
On 15 February 2011 08:39, Dave Page wrote: > Not sure about the first error offhand, but to get you going, the > second one is probably the result of not regenerating xrcdialogs.cpp > using the embed-xrc script. Ah yes, that's fixed it. -- Regards, Peter Geoghegan -- Se

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-14 Thread Peter Geoghegan
I've already removed all wxRESIZE_BOX and wxTHICK_FRAME flags, which fixed lots of these errors on the debug build, so I've currently no idea why this happens. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-11 Thread Peter Geoghegan
rlier patch. It's very difficult to >> predict how long it will take to figure this out. > Done. I guess it was a misunderstanding. It doesn't matter now though. I'll concentrate on producing a new patch that includes everything we've already done. -- Regards, Peter G

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-11 Thread Peter Geoghegan
On 11 February 2011 19:44, Dave Page wrote: > On Fri, Feb 11, 2011 at 6:57 PM, Peter Geoghegan > wrote: >> I'm building it now. >> >> Should the OGL headers really be in a wx directory of their own? My >> instinct is "no". > > I just did that to

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-11 Thread Peter Geoghegan
I'm building it now. Should the OGL headers really be in a wx directory of their own? My instinct is "no". -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/m

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-11 Thread Peter Geoghegan
Can you try again please? That appears to just be an empty file. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-11 Thread Peter Geoghegan
n proceeding until we have consensus. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-11 Thread Peter Geoghegan
On 11 February 2011 03:34, Dave Page wrote: > Or just what he sent - it didn't take long to fix it up last time. I > see it now though anyway... thanks! Are you going to integrate it into our tree, or do you just want to see what I see? -- Regards, Peter Geoghegan -- Sent via pgad

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-10 Thread Peter Geoghegan
patch with any of that yet. You have. Changes look like this: 2 -2 5 I remove the row per the suggestion of the wx error message. That has no apparent effect, other than making the error go away. -- Regar

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-10 Thread Peter Geoghegan
ndependently did that yourself anyway, right? By the way, I missed one of the "(consider omitting number of rows or columns)" problems on the options dialog earlier. I may have missed others, but obviously that won't affect 2.8 builds. -- Regards, Peter Geoghegan -- Sent via pgadmi

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-10 Thread Peter Geoghegan
On 10 February 2011 22:22, Dave Page wrote: > D'oh! Please send that over. It's included in the patch. I did the "git stash; git pull; git stash pop" trick. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-10 Thread Peter Geoghegan
By the way, your earlier commit "Implement a more reliable method for detecting changes to the focussed" broke 2.9 compatibility, which I've fixed. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscrip

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-08 Thread Peter Geoghegan
ainst wxWidgets SVN head, so it's essential that we work from that. For your convenience: svn checkout http://svn.wxwidgets.org/svn/wx/wxWidgets/trunk wxWidgets -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscrip

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-08 Thread Peter Geoghegan
practical use until wxWidgets 3.0 packages are available on popular platforms. Also, the ticket that reported this bug and included a patch is six months old. It doesn't appear as if the wx guys can be bothered producing many point releases for development branches. -- Regards, Peter Geoghega

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-07 Thread Peter Geoghegan
t check if they're null or not there. They're now explicitly initialised to NULL. Styles were removed without any apparent side effects, except making the error go away. I've isolated the table view segfault. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mail

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-07 Thread Peter Geoghegan
it and see"? -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-02 Thread Peter Geoghegan
t we're past the worst of it though. I'd like to close phase 2 by having a pgAdmin III that builds against 2.9 with no obvious defects, but doesn't yet have OGL in the tree. We'll then have something to commit before moving on to phase 3, bringing OGL into the pgAdmin tree an

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-02 Thread Peter Geoghegan
On 2 February 2011 15:33, Peter Geoghegan wrote: Now just a single linker error: undefined reference to `wxBitmapComboBox::Insert(wxString const&, wxBitmap const&, unsigned int, void*) I've now appended adv to pgadmin3_LDADD, and am building again... -- Regards, Peter Geoghegan

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-02 Thread Peter Geoghegan
On 2 February 2011 15:26, Dave Page wrote: > On Wed, Feb 2, 2011 at 3:18 PM, Peter Geoghegan > wrote: >> Find attached linker errors when building against 2.9. >> >> This doesn't look OGL related. They are all related to wxAUI classes. >> Are we mis

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-02 Thread Peter Geoghegan
tter of > minutes, much as we will replace the bakefile. > > Will you use the code that Julian sent you, or stick with the original? I'm going to work with Julian's new code. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-01 Thread Peter Geoghegan
emained self-contained and could easily be used by third parties. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Quick fix for a registry datatype issue on Windows,

2011-02-01 Thread Peter Geoghegan
I take it that you don't see any C4800 warnings on this, because the overload doesn't cause the same problems that we saw with ctlListView? -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscrip

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-31 Thread Peter Geoghegan
. Good, done. >> I would like to see us tie up all the loose ends with the work done to >> date and to get it committed. I feel that we need to draw a line under >> it before really moving on to OGL and the Flex/Bison problem. > > OK - please send the updated patch and

Re: [pgadmin-hackers] Bug in master when refreshing constraints node (though only when collapsed and with --enable-debug)

2011-01-31 Thread Peter Geoghegan
ike to have a go. I'll put it on the backburner. :-) -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Bug in master when refreshing constraints node (though only when collapsed and with --enable-debug)

2011-01-31 Thread Peter Geoghegan
ck to last February 3rd, just shy of a year ago, to see if the problem is present there. I'm afraid that it is. I then went back to May 11 the year before. Once again, the problem is there. I find it very hard to believe that the problem has been around for that long, and that only myself a

[pgadmin-hackers] Bug in master when refreshing constraints node (though only when collapsed and with --enable-debug)

2011-01-31 Thread Peter Geoghegan
ovember last year. The problem is present way back then, which makes it not such a good candidate for a git bisect after all. Does anyone have any idea why I might see this problem? -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.or

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-31 Thread Peter Geoghegan
en us we can draft an email to > sent to those people, and if any of them respond in a less than clear > fashion, we can figure out how to deal with them individually. > > Sound OK? I'm happy with that. I agree with the need to keep something that sensitive off-list. I will gather those names. I would like to see us tie up all the loose ends with the work done to date and to get it committed. I feel that we need to draw a line under it before really moving on to OGL and the Flex/Bison problem. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-29 Thread Peter Geoghegan
round work. Will I go ahead with it? The problem with asking me to do it is that I will split hairs to be on the very safe side, which may not be necessary. I suppose I can just consult you if I hit a snag. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-26 Thread Peter Geoghegan
he result is undefined. See http://www2.research.att.com/~bs/bs_faq2.html#evaluation-order for more information. My problem here is that the evaluation order isn't just undefined to the compiler :-) I've changed my mind about fixing the Flex/Bison problem prior to committing anything. -

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-26 Thread Peter Geoghegan
an already fairly extensive patch. I'll fix them though. BTW, pgscript developer docs indicate that Flex 2.5.33+ is supported, so it obviously isn't that sensitive. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-25 Thread Peter Geoghegan
8); #else return str.mbc_str(); #endif } This appears to work fine. Objections? -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-25 Thread Peter Geoghegan
give up on doing anything with the grammar for now? My inclination is to try and tackle the problem, and just don't address OGL issues in this initial patch. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-23 Thread Peter Geoghegan
actually reviewed anything :-) Okay, good. By the way, I'm seeing lots of warnings like this: ./dlg/dlgSequence.cpp:114:6: warning: suggest explicit braces to avoid ambiguous ‘else’ Worth fixing? -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-23 Thread Peter Geoghegan
as no member named ‘set_debug_level’ The class pgsParser very clearly does not have a member named set_debug_level, so it's hard to argue with that. How would everyone feel about committing my work without Flex/Bison changes, and without worrying about how we'll eventually handle OGL?

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-22 Thread Peter Geoghegan
. > > That should make life much easier, as we could just add the code to > our source tree, and use our own build system. +1. Is this something that you've actually made some headway on? -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@pos

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-22 Thread Peter Geoghegan
;t install headers anywhere. I guess that there's an expectation that the end-user should manage that. It's not particularly clear what we should do about this. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subsc

Re: [pgadmin-hackers] Support for Slony 2.0?

2011-01-22 Thread Peter Geoghegan
handful of high level things - the single well defined tasks that most Slonik scripts do, such as creating a new cluster while creating a new replication set, adding/removing a new node to/from an existing one or executing a script. I'm pretty sure that it'll be possible to do all of t

Re: [pgadmin-hackers] Support for Slony 2.0?

2011-01-20 Thread Peter Geoghegan
this really helping with complicated Slony setups involving daisy-chaining. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Support for Slony 2.0?

2011-01-20 Thread Peter Geoghegan
or any person, not just a person who has a general preference for using command line tools. If you don't agree with this, try managing Slony replication for more than 2 or 3 nodes using PgAdmin. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgre

Re: [pgadmin-hackers] Support for Slony 2.0?

2011-01-20 Thread Peter Geoghegan
nik script. It probably makes maintaining an existing cluster easier though. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-19 Thread Peter Geoghegan
d 2.9. There's a similar situation with switch statements having to be cast to integer types - when we stop supporting 2.8, we can remove the casts and call GetValue() on the proxy object. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-19 Thread Peter Geoghegan
Using flex 2.5.33 hasn't helped :-( -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-19 Thread Peter Geoghegan
run them themselves. In this regard, the PgAdmin tree is similar to official releases of Postgres that are shipped with that crud, but not the Postgres tree itself. Looks like Magnus just committed a fix... -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgr

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-19 Thread Peter Geoghegan
I'm going to try it with Flex 2.5.33. It stands to reason that whatever the problem is, it is down to a problem in the original grammar rather than the tiny changes I made to the embedded C++ code. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-ha

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-18 Thread Peter Geoghegan
ggested in ./pgadmin3/pgadmin/pgscript/README? -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-18 Thread Peter Geoghegan
g defined - it's difficult to imagine a new wx version having this effect. On the other hand, I don't know much about lexx and yacc. Does anyone know what the problem might be? When I'm done with this, I'll run the pgscript unit tests. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-18 Thread Peter Geoghegan
as documented by "Potential Unicode Pitfalls" is often a bit on the ugly side. Trying to get OGL built now. Makefile seems to have been made with a fairly old version of bakefile. I think at the very least, we should be able to get it officially supported with 2.9. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-17 Thread Peter Geoghegan
nt, including using a const_cast to cast away constness from a handle (wxChar*) to the internal buffer used by wxString. -- Regards, Peter Geoghegan make all-recursive make[1]: Entering directory `/home/peter/pgadmin3' Making all in branding make[2]: Entering directory `/home/peter/pgadmin3/branding&

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-17 Thread Peter Geoghegan
On 16 January 2011 22:39, Dave Page wrote: > On Sun, Jan 16, 2011 at 6:47 PM, Peter Geoghegan > From what I can see in a quick glance at the docs, the only conversion > operator is to const char* in 2.8, so I guess that is a legacy thing > as you suggest. There are good reasons for t

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-16 Thread Peter Geoghegan
ore ‘ATTRIBUTE_PRINTF_1’ ATTRIBUTE_PRINTF_1 isn't #define'd. It's called WX_ATTRIBUTE_PRINTF_1 is 2.9, so I've written a new macro called COMPAT_ATTRIBUTE_PRINTF_1 that is conditionally #define'd as either variant. I'm going to go out now. I'll take anothe

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-15 Thread Peter Geoghegan
to Cocoa will be a separate patch. I don't own a Mac, so someone else will have to write that. An awful lot of the errors are in inline functions as it happens, so we get to see them in every TU that the relevant header is included in. -- Regards, Peter Geoghegan -- Sent via pgadmin

[pgadmin-hackers] wxWidgets 2.9 build

2011-01-15 Thread Peter Geoghegan
e it's down to Wx 2.9's new unicode handling (see http://docs.wxwidgets.org/trunk/overview_changes_since28.html). I'll take another look tomorrow. -- Regards, Peter Geoghegan -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscr