Hi,
I have resolved the issue and patch is attached with this mail.
Please do review it and let me know if any changes required.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
-- Forwarded message --
From: <redm...@postgresql.org>
Date: Mon, Jun 13, 2016 at 3
Hi,
PFA the revised patch to resolve this issue which consists the change in
control formatter.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Jun 13, 2016 at 3:12 PM, <redm...@postgresql.org> wrote:
> Issue #1292 has been updated by Dave Page.
>
>-
Hi,
PFA the patch for integration of minimap in graphical explain.
It will show minimap on left top corner of graphical explain.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/misc/__init__.py b/web/pgadmin/misc/__init__.py
index 2081822..6b307e3 100644
Hi,
I have resolved the issue and patch is attached with this mail.
Please review it and let me know in case any issues.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Jun 6, 2016 at 4:23 PM, <redm...@postgresql.org> wrote:
> Issue #1292 has been updated by San
Hi,
Please find the patch for pgadmin4 RM 1113 attached with this mail.
Please review it and commit.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/sql/9.1_plus/nodes.sql b/web/pgadmin/browser
Hi,
I will start working on it once I will complete PEM 6.0.1 issues.
Now there is only 1 issue remaining in that bucket which I am currently
working on
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, May 27, 2016 at 4:44 PM, Dave Page <dp...@pgadmin.org> wrote:
On Wed, May 18, 2016 at 12:42 PM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:
> On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta <
> sanket.me...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA the revised patch.
>> Response is lnline.
>>
Hi,
PFA the revised patch.
Response is lnline.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, May 17, 2016 at 12:54 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi Sanket,
>
> Please find my review comments below:
>
> 1. In create mode i
when creating a trigger. "()" should be appended to
function name in SQL.
It gives error while creating a trigger
- "+" sign is visible in browser tree in front of trigger. either On
expanding trigger, it should show the trigger function name or that "+"
Hi,
Revised patch is attached with this mail.
My response is inline.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, May 13, 2016 at 6:20 PM, Akshay Joshi <akshay.jo...@enterprisedb.com
> wrote:
> Hi Sanket
>
> Below are my review comments:
>
>
>
dialog.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, May 13, 2016 at 3:55 PM, Sanket Mehta <sanket.me...@enterprisedb.com
> wrote:
> Hi,
>
> Revised patch is attached
> Response in inline.
>
>
> Regards,
> Sanket Mehta
> Sr Software engineer
Hi All,
Last patch for FTS configuration does not contain node.ui.js file
Kindly ignore it.
Here is the new revised patch attached with this mail.
Please do review it and let me know if any changes required
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, May 12, 2016 at 4:38 PM
Hi,
PFA the revised patch.
Please do review it and let me know if anything is not proper.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, May 5, 2016 at 8:19 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> + patch link
>
>
> http://www.postgre
Hi,
PFA the patch for minor typo issue in fts dictionary node.
Please do review it and commit if found proper.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/templates/fts_dictionary/sql/9.1_plus
Congratulations Akshay...way to go...!!!
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, May 6, 2016 at 2:25 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Congrats Akshay... Well deserved... keep it up
>
> Thanks
> Surinder Kumar
>
> On
Hi,
This patch includes the patch sent earlier for stand alone graphical
explain.
And also "horizontal lines are not proper" bug is fixed in the same which
was reported by Dave in previous patch.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, Apr 21, 2016 at 8:38
do review it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/js/casts.js b/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/js/casts.js
index 690a6d5..0010222 100644
--- a/web
On Wed, Apr 20, 2016 at 6:12 PM, Dave Page <dp...@pgadmin.org> wrote:
>
>
> On Tuesday, April 19, 2016, Sanket Mehta <sanket.me...@enterprisedb.com>
> wrote:
>
>> Hi,
>>
>> On Mon, Apr 18, 2016 at 5:38 PM, Dave Page <dp...@pgadmin.org> wrote:
>
Hi,
On Mon, Apr 18, 2016 at 5:38 PM, Dave Page <dp...@pgadmin.org> wrote:
>
>
> On Monday, April 18, 2016, Sanket Mehta <sanket.me...@enterprisedb.com>
> wrote:
>
>> Hi Dave,
>>
>> Regarding your second comment,
>> Almost all the libraries t
Thanks for reviewing it Dave.
I will resolve these issues ASAP.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, Apr 15, 2016 at 1:27 AM, Dave Page <dp...@pgadmin.org> wrote:
> On Thu, Apr 14, 2016 at 3:41 PM, Sanket Mehta
> <sanket.me...@enterprisedb.com
quot;name"
LINE 2: RENAME TO user name car;
Please do review the patch and send review comments if any.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_parser/templates/fts_parser/sql/9.1_plus/up
Hi,
PFA patch for FTS Dictionaries.
Please do review it and let me know in case of any issues.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/__init__.py b/web/pgadmin/browser/server_groups/servers
Hi,
PFA the revised patch.
response is inline.
Please do review the patch and revert with comments if any.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Apr 4, 2016 at 1:24 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com>
wrote:
> On Mon, Mar 28, 2016 at 2:32 P
Hi,
Sorry about that issue,
Its resolved now.
PFA the right patch with this mail.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, Apr 7, 2016 at 2:39 PM, Dave Page <dp...@pgadmin.org> wrote:
> Hi
>
> On Mon, Mar 28, 2016 at 10:01 AM, Sanket Meh
Hi,
PFA the patch for FTS parser node for review.
Please do review it and provide the comments.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_parser/__init__.py b/web/pgadmin/browser/server_groups/servers
proceed further.
I was not getting this issue as I was using python 3.0
I have resolved this issue and some other typo errors in comments and patch
is attached with this mail.
Please do review it and let me know in case of any issues.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue
,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Mar 16, 2016 at 12:43 PM, Sanket Mehta <
sanket.me...@enterprisedb.com> wrote:
> Hi Dave,
>
> PFA the patch for cast module incorporating changes regarding showing
> system objects.
> Apart from support for showing system o
Mehta
Sr Software engineer
Enterprisedb
On Fri, Mar 4, 2016 at 4:33 PM, Dave Page <dp...@pgadmin.org> wrote:
> Thanks, patch applied.
>
> On Tue, Mar 1, 2016 at 7:20 AM, Sanket Mehta
> <sanket.me...@enterprisedb.com> wrote:
> > Hi,
> >
> > There was
Hi,
Sorry its misunderstanding from my side.
That node refresh on tree issue has been resolved.
Patch is attached with this mail.
Please do review it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Mar 14, 2016 at 7:27 PM, Dave Page <dp...@pgadmin.org> wrote:
> On
,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, Mar 11, 2016 at 6:41 PM, Dave Page <dp...@pgadmin.org> wrote:
> Hi
>
> On Thu, Mar 10, 2016 at 6:28 AM, Sanket Mehta
> <sanket.me...@enterprisedb.com> wrote:
> > Hi,
> >
> > PFA the patch for fts tem
,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Mar 1, 2016 at 4:56 PM, Sanket Mehta <sanket.me...@enterprisedb.com>
wrote:
> Hi Dave,
>
> For your first comment,
>
> "When creating a new template, errors in the dialogue are not cleared -
> e.g. the "Nam
Hi Dave,
All comments are resolved.
PFA the revised patch.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, Feb 25, 2016 at 7:37 PM, Dave Page <dp...@pgadmin.org> wrote:
> Hi
>
> On Tue, Feb 23, 2016 at 1:44 PM, Sanket Mehta <
> sanket.me...@enterprised
Hi,
There was an error in cast module while fetching its dependency and
dependent.
Below is the patch which resolves this issue.
Please review and commit it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Feb 24, 2016 at 10:17 PM, Dave Page <dp...@pgadmin.org>
Hi,
PFA the revised patch for fts template node which includes dependency and
dependent route handling code.
Please do review it and if found proper please do commit it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, Jan 28, 2016 at 7:21 PM, Sanket Mehta <sanket
Hi,
PFA the revised patch as per your comments.
Please review it and let me know the feedback.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Feb 23, 2016 at 4:10 PM, Dave Page <dp...@pgadmin.org> wrote:
> Hi
>
> I've attached an update to this patch, in which
Hi Dave,
PFA the revise patch.
It includes changes according to your review comments as well as
dependency/dependent part also.
Let me know in case anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Feb 15, 2016 at 10:25 PM, Dave Page <dp...@pgadmin.
Hi,
PFA the revised patch with all the required comments.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Feb 15, 2016 at 4:18 PM, Dave Page <dp...@pgadmin.org> wrote:
>
>
> On Mon, Feb 15, 2016 at 8:10 AM, Sanket Mehta <
> sanket.me...@enterprisedb.com
Hi Dave,
Regarding your suggestion of putting some comments in javascript, I think I
have already put some comments regarding model data and their controls if
any extended.
Can you please let me know where exactly you think more comments are
required?
Regards,
Sanket Mehta
Sr Software engineer
Hi Akshay,
PFA the updated patch.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, Feb 11, 2016 at 12:09 PM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
> Hi Sanket
>
> Most of the review comments has been resolved but I found some issues with
> this p
Hi Akshay,
PFA the revised patch.
All the comments are inline.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, Feb 5, 2016 at 12:43 PM, Akshay Joshi <akshay.jo...@enterprisedb.com
> wrote:
> Hi Sanket
>
> Below are the review comments
>
>- A
Hi Akshay,
PFA the latest patch for Cast module.
Please do review it and let me know if anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Jan 20, 2016 at 5:03 PM, Sanket Mehta <sanket.me...@enterprisedb.com
> wrote:
> Hi Neel.
>
> PFA the revi
Hi,
I have created patch for "FTS Template" node in pgadmin4.
Please do review it and let me know in case anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_templates/__init__.py b/w
with this mail.
Please do review it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/utils/driver/psycopg2/__init__.py b/web/pgadmin/utils/driver/psycopg2/__init__.py
index c6c87f1..d4205d2 100644
--- a/web/pgadmin/utils/driver/psycopg2/__init__.py
+++ b/web/pgadmin/utils
Hi Neel.
PFA the revised patch which has changed according to your comments.
Please do review it and let me know in case anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Jan 20, 2016 at 10:20 AM, Neel Patel <neel.pa...@enterprisedb.com>
wrote:
>
ld comparison should
be like this :
proargtypes[1] (if present) should be compared to 23 (int4),
and proargtypes[2] (if present) should be compared to 16 (bool).
I have resolved the issue and patch is attached with this mail.
Please do review it and let me know in case of anything is missing.
Rega
Hi,
PFA updated patch for cast module as per check list provided by Neel.
Please do review it and let me know in case of anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Jan 18, 2016 at 7:16 PM, Sanket Mehta <sanket.me...@enterprisedb.com
> wrote:
Hi,
PFA patch for cast module.
Please do review it and let me know in case of any issue.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/browser/server_groups/servers/databases/casts/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/casts
executing next steps.
I have resolved this issue and patch is attached with this mail for review.
Please do review the patch and let me know in case anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/job.cpp b/job.cpp
index f3eaa03..9864f57 100644
--- a/job.cpp
anges made:*
Changes made to generate sql as per current implementation in PostgreSQL.
Please do review and commit it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/pgadmin/dlg/dlgMoveTablespace.cpp b/pgadmin/dlg/dlgMoveTablespace.cpp
index cc78a71..677023b 100644
--- a/p
Hi Ashesh,
PFA the updated patch which includes the changes you have suggested.
Please do review and commit it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Oct 12, 2015 at 4:55 PM, Sanket Mehta <sanket.me...@enterprisedb.com
> wrote:
> Hi Ashesh,
>
> I have
Hi John/Ashesh,
I have reviewed the patch and it seems fine to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Sep 23, 2015 at 11:08 AM, John Obaterspok <john.obaters...@gmail.com
> wrote:
> Hi Sanket,
>
> Did you give the patch a try? I would really like it
Hi John,
Patch is not proper.
I got below error when I try to apply the patch:
error: patch failed: pgadmin/frm/frmQuery.cpp:2435
error: pgadmin/frm/frmQuery.cpp: patch does not apply
Please do provide the proper patch.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Sep 14
Sure Ashesh,
I will review the patch.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com
> wrote:
> Sanket,
>
> Can you please take a look at it?
>
> --
>
> Thanks & Regards,
>
&
Hi,
In this case patch looks good to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, Aug 6, 2015 at 2:22 PM, Dave Page dp...@pgadmin.org wrote:
On Wed, Aug 5, 2015 at 6:20 PM, Sanket Mehta
sanket.me...@enterprisedb.com wrote:
Hi,
I have reviewed the patch and below
thoughts on it?
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Aug 3, 2015 at 11:07 AM, Sanket Mehta sanket.me...@enterprisedb.com
wrote:
Sure Ashesh.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Aug 3, 2015 at 10:49 AM, Ashesh Vashi
ashesh.va
Sure Ashesh.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Aug 3, 2015 at 10:49 AM, Ashesh Vashi ashesh.va...@enterprisedb.com
wrote:
Sanket,
Can you please review it?
--
Thanks Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
http
Hi,
I have reviewed the patch.
It looks good to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Sat, Jul 4, 2015 at 3:22 PM, Dmitriy Olshevskiy olshevski...@bk.ru
wrote:
hello. could you see this patch with several typos in comments and
messages?
--
Dmitriy Olshevskiy
Hi,
Patch looks good to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Sat, Jul 4, 2015 at 4:07 PM, Dmitriy Olshevskiy olshevski...@bk.ru
wrote:
hello again.
method dlgDefaultSecurityProperty::OnChangeSize contains the repeated
expressions with l_size.GetWidth
is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Jul 1, 2015 at 8:47 PM, Dave Page dp...@pgadmin.org wrote:
Ashesh, can you review/commit please?
Thanks.
On Tue, Jun 30, 2015 at 2:27 PM, Sanket Mehta
sanket.me...@enterprisedb.com wrote:
Hi,
While connecting
Hi,
While connecting to PostgreSQL 9.5 serve using pgadmin, we have faced an
error column not found in pgSet: tolcatupdate.
We have resolved this issue and the patch is attached to this mail.
Please do review it and let me know if any thing is missing.
Regards,
Sanket Mehta
Sr Software
Hi John,
PFA the new patch.
Please check and let me know if it still crashes.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Jun 23, 2015 at 12:03 AM, John Obaterspok john.obaters...@gmail.com
wrote:
Hello,
It still crashes on the wxIsalpha. Uncommenting the /* (size_t
Hi John,
are you sending any other icons for the same?
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Jun 23, 2015 at 1:47 PM, Dave Page dp...@pgadmin.org wrote:
Hi
On Mon, Jun 22, 2015 at 2:02 PM, John Obaterspok
john.obaters...@gmail.com wrote:
Dave,
Regarding I
Hi,
we had found some other issues in autocommit code and resolved it.
Here is the patch attached with this mail.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Jun 16, 2015 at 12:59 PM, John Obaterspok john.obaters...@gmail.com
wrote:
Hello,
I forgot to mention
Hi,
We were using wxWidgets 2.8.12 so that may be the issue.
I will now try with wxwidgets 3.0.2 and let you know.
Btw apart from this issue, we have also resolved other issues in the code,
i will soon send a new patch for the same.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
Sure Dave.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Jun 16, 2015 at 4:55 PM, Dave Page dp...@pgadmin.org wrote:
Sanket, can you look at this please?
Sent from my iPad
On 15 Jun 2015, at 16:33, John Obaterspok john.obaters...@gmail.com
wrote:
Hello
Hi John,
I have tried the same, I am not getting any out of the bounds error, it
simply comes out of the while loop.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Sun, Jun 14, 2015 at 2:00 PM, John Obaterspok john.obaters...@gmail.com
wrote:
Hello Sanket,
Just enter rollback
Hi John,
I have tried to reproduce the scenario but not able to reproduce the crash
in my system.
can you please provide your steps which causes crash on your machine?
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, Jun 12, 2015 at 11:50 AM, Sanket Mehta
sanket.me
Hi Dave,
Sure I will.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, May 21, 2015 at 3:08 PM, Dave Page dp...@pgadmin.org wrote:
Sanket, could you review this please?
Thanks.
On Wed, May 20, 2015 at 8:26 PM, Dmitriy Olshevskiy olshevski...@bk.ru
wrote:
Hello.
Please
Hi Dave,
Patch looks good to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, May 21, 2015 at 3:14 PM, Sanket Mehta sanket.me...@enterprisedb.com
wrote:
Hi Dave,
Sure I will.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Thu, May 21, 2015 at 3:08 PM
with this mail.
Please review it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Apr 22, 2015 at 3:25 PM, Sanket Mehta sanket.me...@enterprisedb.com
wrote:
Hi,
Sure, I will do the required changes.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Apr 22, 2015
Hi,
Sure, I will do the required changes.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Apr 22, 2015 at 3:09 PM, Ashesh Vashi ashesh.va...@enterprisedb.com
wrote:
On Wed, Apr 22, 2015 at 1:23 PM, Dave Page dp...@pgadmin.org wrote:
On Wed, Apr 22, 2015 at 8:40 AM
Hi,
Sure I will review it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Apr 20, 2015 at 12:04 PM, Ashesh Vashi
ashesh.va...@enterprisedb.com wrote:
On Mon, Apr 20, 2015 at 12:25 AM, J.F. Oster jinfros...@mail.ru wrote:
Hi!
Explicitly set focus on the browser tree
Hi Ashesh,
I have reviewed the patch on Ubuntu.
It is getting focus on start up after applying the patch.
So patch is working fine.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Apr 20, 2015 at 12:45 PM, Sanket Mehta
sanket.me...@enterprisedb.com wrote:
Hi,
Sure I
change is that we std errors should get logged in file every time
irrespective of output string is empty or not. so I have removed the
condition if(output == wxEmptyString) .
I have attached the new patch here.
Please test and let me know if you think any changes requires.
Regards,
Sanket Mehta
Sr
, the patch is working fine on windows and
Ubuntu 14.04 platform.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Apr 14, 2015 at 4:28 PM, Sanket Mehta sanket.me...@enterprisedb.com
wrote:
Hi Ashesh,
On Tue, Apr 14, 2015 at 2:37 PM, Prasad prasa...@mail.com wrote:
Ashesh,
You
Hi,
I have reviewed the patch.
You are right Mehmet, previously 2nd time stderr was not coming to file.
With this patch that issue is resolved.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Wed, Apr 15, 2015 at 3:27 PM, Mehmet Emin KARAKAŞ emin...@gmail.com
wrote:
Hi,
We
Hi,
I have reviewed the patch.
It is working fine.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Apr 6, 2015 at 7:30 PM, Mehmet Emin KARAKAŞ emin...@gmail.com
wrote:
Hi,
What is the last situation? I want to remove my repo and continue original
repo.
Thanks
Hi Ashesh,
Yes you are right.
It will be still in transaction till user executes COMMIT/ROLLBACK/END.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Apr 7, 2015 at 11:02 AM, Ashesh Vashi ashesh.va...@enterprisedb.com
wrote:
On Wed, Apr 1, 2015 at 2:31 PM, Sanket Mehta
() which is defined in
sysSettings class.
I have attached the new patch with this mail.
Please review it and do the needful.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Mar 31, 2015 at 9:43 PM, Ashesh Vashi ashesh.va...@enterprisedb.com
wrote:
Hi Sanket,
In your patch
queries.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
Hi,
I have developed the *Autocommit* feature in pgadmin and its patch is
attached with this mail.
Please do review and commit it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Mar 17, 2015 at 2:01 AM, Sanket Mehta sanket.me...@enterprisedb.com
wrote
dialog, memory leak occurred.
*4.pgadmin/ogl/canvas.cpp:*
*Scenario:*
This memory leak was found in OGL module as m_shapeDiagram was not being
deleted in destructor of canvas class.
Please review this patch and let me know in case anything is missing.
Regards,
Sanket Mehta
Sr Software
in case i find more memory leaks.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
memory_leak_pgadmin.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin
, Nov 26, 2014 at 3:27 PM, Sanket Mehta
sanket.me...@enterprisedb.com wrote:
Hi Akshay,
On Tue, Nov 25, 2014 at 2:57 PM, Akshay Joshi
akshay.jo...@enterprisedb.com wrote:
Hi Sanket
On Mon, Nov 24, 2014 at 5:18 PM, Sanket Mehta
sanket.me...@enterprisedb.com wrote:
Hi Akshay,
On Wed
constructor if
testing is done.
Above issues are resolved.
PFA the revised patch.
On Tue, Nov 18, 2014 at 6:10 PM, Sanket Mehta
sanket.me...@enterprisedb.com wrote:
Hi,
Below are the thing I have taken care in this patch:
1. While creating the new table using table wizard, when any
Hi Akshay,
PFA the patch.
Please review it and let me know if anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Nov 11, 2014 at 7:21 PM, Ashesh Vashi ashesh.va...@enterprisedb.com
wrote:
Hi Sanket,
Apart from variable persistence issue taken care in your
then
privileges and security labels in column dialog are not being persistent
for new changes.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Nov 18, 2014 at 5:54 PM, Sanket Mehta sanket.me...@enterprisedb.com
wrote:
Hi Akshay,
PFA the patch.
Please review it and let me know
on *sql tab* of new table wizard.
I have resolved that issue and created the patch for the same.
Patch is attached with this mail. Please review it and if it looks good,
please commit the code.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Nov 4, 2014 at 1:16 PM, Sanket Mehta
Sure Ashesh,
I will check and get back.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Nov 4, 2014 at 1:03 PM, Ashesh Vashi ashesh.va...@enterprisedb.com
wrote:
Sanket,
Can you take a look at it?
--
Thanks,
Ashesh Vashi
On 4 Nov 2014 12:54, liuyuanyuan liuyuanyuang
Hi J.F.,
Thank you for the explanation.
I have reviewed the patch.
It resolves both issues mentioned in the explanation.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Oct 28, 2014 at 10:16 PM, J.F. Oster jinfros...@mail.ru wrote:
Hello Sanket,
Steps to reveal issues:
1
Hi,
I have reviewed this patch.
It looks good to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Oct 27, 2014 at 4:16 PM, Dave Page dp...@pgadmin.org wrote:
Ashesh, can you review/commit this please?
On Fri, Oct 24, 2014 at 10:57 PM, Mads Jensen m...@inducks.org wrote
Hi
I have reviewed this patch.
This looks good to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Oct 27, 2014 at 4:16 PM, Dave Page dp...@pgadmin.org wrote:
Ashesh, can you review/commit this please?
On Sun, Oct 26, 2014 at 5:51 AM, J.F. Oster jinfros...@mail.ru wrote
Hi,
As per my understanding below is the bug scenario.
- open any file in sql editor..
- now open a second file in same editor and try undo.
- it will show you previous file content again.
Let me know if my understanding is correct so that i can go ahead and
review the patch.
Regards,
Sanket
Hi,
Can you please explain in which case it will create issue if bug is not
applied?
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Oct 27, 2014 at 4:14 PM, Dave Page dp...@pgadmin.org wrote:
Ashesh, can you review/commit this please?
On Fri, Oct 24, 2014 at 8:12 PM, J.F
Hi J.F.
Thank you for the clarification.
I have reviewed the patch.
It seems working fine.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Tue, Oct 28, 2014 at 9:38 PM, J.F. Oster jinfros...@mail.ru wrote:
Hello Sanket,
SM As per my understanding below is the bug scenario
Hi Dave,
I have reviewed the older patch, it looked good to me except one issue that
I have fixed.
I have attached the revised patch with this mail.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Oct 27, 2014 at 3:16 PM, Akshay Joshi akshay.jo...@enterprisedb.com
wrote
Hi,
I have reviewed the patch.
It looks good to me.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Mon, Oct 27, 2014 at 4:14 PM, Dave Page dp...@pgadmin.org wrote:
Ashesh, can you review/commit this please?
On Fri, Oct 24, 2014 at 6:02 PM, J.F. Oster jinfros...@mail.ru wrote
if anything is missing.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, Oct 10, 2014 at 9:24 PM, Dave Page dp...@pgadmin.org wrote:
On Fri, Oct 10, 2014 at 1:35 PM, Sanket Mehta
sanket.me...@enterprisedb.com wrote:
Hi Dave,
There is one issue with pgadmin while viewing
column name in case db server is PPAS.
I have removed that condition and tested it. It works fine now.
I have attached the same patch with this mail for your reference.
Please review it and if it looks good to you please do the needful.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
(.*) \\$trigger')) *
Above logic has worked with PPAS and PG both. Attached is the patch file.
Please review it and if it looks good to you then please do commit the code
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
ppas_trigger_when_issue.patch
Description: Binary data
--
Sent via pgadmin
1 - 100 of 102 matches
Mail list logo
