Re: [pgadmin-hackers][patch] Raise InternalServerError while retrieving table DDL

2017-03-24 Thread Ashesh Vashi
On Fri, Mar 24, 2017 at 7:19 PM, Atira Odhner wrote: > When we were working on the DDL story, we found that some methods were > returning the internal_server_error json, but the code that called those > methods was not expecting that type of object. So, instead of returning > that json to the use

Re: [pgadmin-hackers][patch] Raise InternalServerError while retrieving table DDL

2017-03-24 Thread Atira Odhner
When we were working on the DDL story, we found that some methods were returning the internal_server_error json, but the code that called those methods was not expecting that type of object. So, instead of returning that json to the user, the code would try to treat the json as a different type of

Re: [pgadmin-hackers][patch] Raise InternalServerError while retrieving table DDL

2017-03-24 Thread Ashesh Vashi
On Fri, Mar 24, 2017 at 5:07 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > > On Thu, Mar 23, 2017 at 3:49 PM, Joao Pedro De Almeida Pereira > wrote: > > Hi Hackers, > > > > While doing the DDL patch we found out that the code was not working > > properly when errors happene

Re: [pgadmin-hackers][patch] Raise InternalServerError while retrieving table DDL

2017-03-24 Thread Dave Page
Ashesh, can you review/commit this please? On Thu, Mar 23, 2017 at 3:49 PM, Joao Pedro De Almeida Pereira wrote: > Hi Hackers, > > While doing the DDL patch we found out that the code was not working > properly when errors happened during SQL execution: > > One example of this can be found in the

[pgadmin-hackers][patch] Raise InternalServerError while retrieving table DDL

2017-03-23 Thread Joao Pedro De Almeida Pereira
Hi Hackers, While doing the DDL patch we found out that the code was not working properly when errors happened during SQL execution: One example of this can be found in the file: web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py The function '*_formatter*' that retu