Thanks for the patch.
Pushed to the master branch.
On Mon, Jan 13, 2014 at 9:51 AM, Ashesh Vashi wrote:
>
> On Mon, Jan 13, 2014 at 5:13 AM, Kaarel Moppel wrote:
>
>> Hi Ashesh,
>>
>> Got a "candidate expects 0 arguments, 1 provided".
>>
> Thanks.
> I will check-in the code.
>
>>
>> Changed thi
On Mon, Jan 13, 2014 at 5:13 AM, Kaarel Moppel wrote:
> Hi Ashesh,
>
> Got a "candidate expects 0 arguments, 1 provided".
>
Thanks.
I will check-in the code.
>
> Changed this so it should be final now.
>
> - settings->FlushChanges(false);
> + settings->FlushChanges();
>
>
>
> On Thu, Jan 9, 2014
Hi Ashesh,
Got a "candidate expects 0 arguments, 1 provided".
Changed this so it should be final now.
- settings->FlushChanges(false);
+ settings->FlushChanges();
On Thu, Jan 9, 2014 at 10:34 AM, Ashesh Vashi wrote:
> Dave,
>
> In that case, we should not change the inheritance mode.
>
> Ka
Dave,
In that case, we should not change the inheritance mode.
Kaarel,
I've attached the patch as per Dave's comment.
Can you please test it at your end?
On Thu, Jan 9, 2014 at 2:35 PM, Dave Page wrote:
>
>
>
> On Thu, Jan 9, 2014 at 4:41 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com>
On Thu, Jan 9, 2014 at 4:41 AM, Ashesh Vashi
wrote:
> Looking good to me.
> If nobody has any objection, then I can check-in.
>
> NOTE:
> I don't know the reason for the class sysSettings to inherit the wxConfig
> privately in original implementation.
> It was done by Dave in this commit:
> cfbae7
Looking good to me.
If nobody has any objection, then I can check-in.
NOTE:
I don't know the reason for the class sysSettings to inherit the wxConfig
privately in original implementation.
It was done by Dave in this commit:
cfbae7d378766ab8cf138123186a024afffc061e.
On Thu, Jan 9, 2014 at 5:42 A
Ok, got it. Corrected version in attach now.
On Mon, Jan 6, 2014 at 12:29 PM, Ashesh Vashi wrote:
> Hi Kaarel,
>
> I think - everything looks good except:
> 1. Please use TAB instead of 4 spaces
> 2. You don't require to define Flush function after inheriting the
> wxConfig class publicly.
>
Hi Kaarel,
I think - everything looks good except:
1. Please use TAB instead of 4 spaces
2. You don't require to define Flush function after inheriting the wxConfig
class publicly.
Or,
Define it only if you keep the wxConfig inherited protectively.
On Mon, Jan 6, 2014 at 3:48 AM, Kaarel
Ashesh, can you look at this please?
Thanks.
On Sun, Jan 5, 2014 at 10:18 PM, Kaarel Moppel wrote:
> Hi,
>
> Sending some 3 small fixes in separate emails for issues that me and my
> colleagues found really annoying. This is my first try at Pgadmin and I
> haven't done too much C++ though so in
Sure..
On Mon, Jan 6, 2014 at 4:39 PM, Dave Page wrote:
> Ashesh, can you look at this please?
>
> Thanks.
>
> On Sun, Jan 5, 2014 at 10:18 PM, Kaarel Moppel
> wrote:
> > Hi,
> >
> > Sending some 3 small fixes in separate emails for issues that me and my
> > colleagues found really annoying. T
Hi,
Sending some 3 small fixes in separate emails for issues that me and my
colleagues found really annoying. This is my first try at Pgadmin and I
haven't done too much C++ though so in case something should be corrected
let me know and I'd be happy to do that.
Cheers,
Kaarel
From f5a6a227e3417d
11 matches
Mail list logo
