Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-08 Thread Murtuza Zabuawala
Hi Shirley, The new UI looks awesome :) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 8, 2017 at 6:58 PM, Shirley Wang wrote: > Hi Murtuza, > > This was before we had checkboxes removed and added column and row > highlight

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-08 Thread Shirley Wang
Hi Murtuza, This was before we had checkboxes removed and added column and row highlighting. Try looking at this now with the query results grid updates and let me know what you think. On Thu, Jun 8, 2017 at 1:19 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > I t

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Dave Page
Thanks, applied. On Wed, Jun 7, 2017 at 3:48 PM, Surinder Kumar wrote: > Hi > > I have used classes 'bg-gray-2 border-gray-3' for styling header and footer > of properties panel which are also used in other places. > > Please find attached patch. > > > On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckha

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Surinder Kumar
Hi I have used classes 'bg-gray-2 border-gray-3' for styling header and footer of properties panel which are also used in other places. Please find attached patch. On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt wrote: > Thank you. > > -- Rob > > On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Robert Eckhardt
Thank you. -- Rob On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Sure I will send. > > On Wed, Jun 7, 2017 at 6:54 PM, Dave Page wrote: > >> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > With the latest pull, I found: >>

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Surinder Kumar
Sure I will send. On Wed, Jun 7, 2017 at 6:54 PM, Dave Page wrote: > On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar > wrote: > > Hi > > > > With the latest pull, I found: > > The header color of Properties panel disappears and background color of > > footer area in Edit Properties panel is chan

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Dave Page
On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar wrote: > Hi > > With the latest pull, I found: > The header color of Properties panel disappears and background color of > footer area in Edit Properties panel is changed. Oh, I missed that :-(. Can you come up with a quick fix using the new classes?

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Surinder Kumar
Hi With the latest pull, I found: The header color of Properties panel disappears and background color of footer area in Edit Properties panel is changed. On Wed, Jun 7, 2017 at 6:28 PM, Dave Page wrote: > Thanks, applied. I removed the doc comments from the CSS for now as we > don't have minim

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Dave Page
Thanks, applied. I removed the doc comments from the CSS for now as we don't have minimisation for that yet (and one of them seemed to be garbage). On Mon, Jun 5, 2017 at 4:52 PM, Shruti B Iyer wrote: > Hi Hackers > > Attached are two patches for styling improvements. > 1-add-style-guide.patch co

[pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-05 Thread Shruti B Iyer
Hi Hackers Attached are two patches for styling improvements. 1-add-style-guide.patch contains the initial css from the style guide. As we make further style changes, this file will be updated. 2-change-grays.patch changes the gray color elements in the app to the ones in the new style guide. Tha