Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid column resize triggers column select

2017-05-05 Thread Murtuza Zabuawala
Sure. --Murtuza On Fri, May 5, 2017 at 8:55 PM, Sarah McAlear wrote: > Hi Murtuza and Ashesh! > > We are currently working on a number of features related to the query > results grid. Some of the changes we are working on is that the checkboxes > are going away. The

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid column resize triggers column select

2017-05-05 Thread Sarah McAlear
Hi Murtuza and Ashesh! We are currently working on a number of features related to the query results grid. Some of the changes we are working on is that the checkboxes are going away. The implementation of this patch will have to change based on this. We noticed that 5 Javascript Tests are

[pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid column resize triggers column select

2017-05-05 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where in SlickGrid column resize also triggers 'onHeaderClick' event and triggers column selection, In this scenario before drag event which column is under mouse gets selected, So to fix the issue we will check if header checkbox is clicked. RM#2348 Please review.