Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

2017-05-15 Thread Dave Page
And... done. On Mon, May 15, 2017 at 10:10 AM, Dave Page wrote: > Hi > > Hmm, OK - well I still can't reproduce it (using a table), but the change > is clearly an appropriate check so I'll get it committed. > > Thanks. > > On Mon, May 15, 2017 at 9:53 AM, Murtuza Zabuawala

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

2017-05-15 Thread Dave Page
Hi Hmm, OK - well I still can't reproduce it (using a table), but the change is clearly an appropriate check so I'll get it committed. Thanks. On Mon, May 15, 2017 at 9:53 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > As there were no proper steps given in

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

2017-05-15 Thread Murtuza Zabuawala
Hi Dave, As there were no proper steps given in RM to re-produce the issue, I assumed that user tried to delete schema and then click on the table, hence he got that error. So I checked the code notice that validation was missing at a location of error trace mentioned in RM, it assumed that we

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

2017-05-15 Thread Dave Page
Hi On Mon, May 15, 2017 at 7:14 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to add object validation in table node for SQL and > Properties tab . > RM#2395 > I don't see how this relates to the issue reported which is related to dropping a schema

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

2017-05-15 Thread Murtuza Zabuawala
Hi, PFA minor patch to add object validation in table node for SQL and Properties tab . RM#2395 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py