Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1674 - Reverse engineered SQL for functions with default values is incorrect

On Wed, Sep 14, 2016 at 11:23 AM, Surinder Kumar wrote: > On Wed, Sep 14, 2016 at 3:30 PM, Dave Page wrote: >> >> Thanks - committed with a couple of minor formatting tweaks: >> >> - Remove the leading space before arguments (e.g. s/, /\r\t/

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1674 - Reverse engineered SQL for functions with default values is incorrect

On Wed, Sep 14, 2016 at 3:30 PM, Dave Page wrote: > Thanks - committed with a couple of minor formatting tweaks: > > - Remove the leading space before arguments (e.g. s/, /\r\t/ instead > of s/,/\r\t/) > - Put the first argument on a new line as well. ​It seems fine except

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1674 - Reverse engineered SQL for functions with default values is incorrect

Thanks - committed with a couple of minor formatting tweaks: - Remove the leading space before arguments (e.g. s/, /\r\t/ instead of s/,/\r\t/) - Put the first argument on a new line as well. Please double-check I didn't break anything that I've missed! On Tue, Sep 13, 2016 at 12:41 PM,

[pgadmin-hackers] [pgAdmin4][Patch]: RM1674 - Reverse engineered SQL for functions with default values is incorrect

Hi *Patch with following changes:* 1) In SQL pane, the signature in comments had arguments with name and type, Now it will show arguments with type only. 2) There is no indent+newline between arguments (there isn't even a space). - Fixed 3) The default value for the last argument is omitted. -