Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 11:47 AM, Surinder Kumar wrote: > On Tue, Jun 13, 2017 at 4:05 PM, Dave Page wrote: >> >> On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar >> wrote: >> > >> > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: >> >> >> >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi >>

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 4:05 PM, Dave Page wrote: > On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar > wrote: > > > > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > >> > >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi > >> wrote: > >> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote:

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar wrote: > > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: >> >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi >> wrote: >> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: >> >> >> >> And then I find a problem. Sigh. >> >> >> >> When runni

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi > wrote: > > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: > >> > >> And then I find a problem. Sigh. > >> > >> When running in the desktop runtime, under QtWekKit (the forked, > >> updated ve

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

-- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: > On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vas

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi wrote: > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: >> >> And then I find a problem. Sigh. >> >> When running in the desktop runtime, under QtWekKit (the forked, >> updated version that is by far the best of the browser engines we've >> used),

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: > And then I find a problem. Sigh. > > When running in the desktop runtime, under QtWekKit (the forked, > updated version that is by far the best of the browser engines we've > used), we get the attached error at startup. I don't see this under >

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi On Mon, Jun 12, 2017 at 7:22 PM, Shruti B Iyer wrote: > Hi Dave, > > We regenerated the patch to add new tasks to package.json to compile react > code for development and to not minimize it. This should fix the error you > captured in the screenshot. > > The new task to lint and bundle everyth

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Dave, We regenerated the patch to add new tasks to package.json to compile react code for development and to not minimize it. This should fix the error you captured in the screenshot. The new task to lint and bundle everything for development is: yarn run bundle:dev The new task only bundle e

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

To add to that; running the JS tests gives: ERROR in ./regression/javascript/history/query_history_entry_spec.jsx Module not found: Error: Can't resolve 'jasmine-enzyme' in '/Users/dpage/git/pgadmin4/web/regression/javascript/history' @ ./regression/javascript/history/query_history_entry_spec.jsx

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Shruti On Mon, Jun 12, 2017 at 3:24 PM, Shruti B Iyer wrote: > > Hello Dave, > > Thanks for making those fixes and sharing them with us. We tried applying > the patch and it looks like there are some missing file changes from your > patch that were present in ours, like the Make.bat file chang

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hello Dave, Thanks for making those fixes and sharing them with us. We tried applying the patch and it looks like there are some missing file changes from your patch that were present in ours, like the Make.bat file changes. But we will add them when we send you the new patches. While trying to g

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi George On Wed, Jun 7, 2017 at 10:21 PM, George Gelashvili wrote: > Hi Dave, > > I split the linting out into an intermediate commit, and rebased on top of > master. Unfortunately, it still doesn't apply: error: patch failed: web/regression/javascript/test-main.js:1 error: removal patch leave

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi On Tue, Jun 6, 2017 at 9:15 PM, Sarah McAlear wrote: > Hello, > >> First patch contains changes related to copy row feature which is already >> in process in another thread. Any reason to add those changes in this patch >> as this patch is meant to contain infrastructure changes ? > > > As par

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Review comments: 1) First patch contains changes related to copy row feature which is already in process in another thread. Any reason to add those changes in this patch as this patch is meant to contain infrastructure changes ? 2) Can the changes related to FeatureTest or Jasmine test be sep

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hey Surinder, Is it possible to run the task listed above by configuring them in > "scripts" in package.json file and running concurrently ? That would be cleaner than what we proposed. We could use the yarn run feature to do just what you are suggesti

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Wed, May 31, 2017 at 12:01 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > The motivation is simple - we want a solution that works for the whole >> app, can handle debug vs. release execution, pluggable modules, and >> installations in read-only directories. > > With

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

> > The motivation is simple - we want a solution that works for the whole > app, can handle debug vs. release execution, pluggable modules, and > installations in read-only directories. With the current configuration of Grunt, all the requirements you mention are available. The tasks on Grunt sho

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi On Tue, May 30, 2017 at 2:47 PM, Matthew Kleiman wrote: > Hi Dave, > > We are currently using the Grunt taskrunner to run the following tasks: > > lint the javascript code > start javascript tests > invoke webpack to transpile and bundle js and jsx files > minify javascript > > In order to rem

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Dave, We are currently using the Grunt taskrunner to run the following tasks: - lint the javascript code - start javascript tests - invoke webpack to transpile and bundle js and jsx files - minify javascript In order to remove Grunt from the application, we will need some other to

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Sorry guys - can you please remove the Grunt part of this until we've decided whether or not we want to use it at all? (see the thread discussing optimisation with Surinder). For now, let's just drop the required packages into the vendor directory. I'm happy to have that populated by yarn to avoid

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi That fixed the JS tests, however, the feature tests are completely broken now - the browser fails to load the app, so they just timeout: == ERROR: runTest (pgadmin.feature_tests.connect_to_server_feature_test.ConnectsToServer

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Dave, This one is our bad! We didn't create a grunt task to run the tests only once, as you would in CI. grunt tests currently runs the tests and continues to watch for changes, running the tests again each time the source code is modified. We will create a task that is suitable to run in CI.

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Tue, May 23, 2017 at 12:12 PM, Joao Pedro De Almeida Pereira wrote: > Okay > > Can you try removing web/node_modules and web/yarn.lock, and running > $ yarn install > $ grunt tests > > We think this might be due to a bad version of phantomjs-prebuilt. > > If that still fails, can you try runnin

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Okay Can you try removing web/node_modules and web/yarn.lock, and running $ yarn install $ grunt tests We think this might be due to a bad version of phantomjs-prebuilt. If that still fails, can you try running grunt as "yarn run grunt tests"? Joao and George On Fri, May 19, 2017 at 10:27 AM,

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On Thu, May 18, 2017 at 4:37 PM, Matthew Kleiman wrote: > Dave, > > Can you try running grunt tests on the command line? > > The tests task will run the eslint and karma grunt tasks, which should > automatically webpack the React components before running the jasmine tests > in karma. > > If it st

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Dave, Can you try running grunt tests on the command line? The tests task will run the eslint and karma grunt tasks, which should automatically webpack the React components before running the jasmine tests in karma. If it still fails, send us the output of that. Thanks, Matt On Thu, May 18, 20

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi On Thu, May 18, 2017 at 9:56 AM, Murtuza Zabuawala wrote: > > Go to 'pgadmin4/web' directory > > Try running, > > run 'yarn install' > > (if you have installed globally) > then run 'grunt' > OR > run './node_modules/grunt-cli/bin/grunt' > > > Then run pgAdmin4 > OK, that worked - though pgAd