Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Thanks - committed. On Tue, Feb 23, 2016 at 11:07 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > PFA patch with changes suggested by Dave > > Please review the patch and let me know for any comments. > > On Mon, Feb 15, 2016 at 4:37 PM, Dave Page

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi, PFA patch with changes suggested by Dave Please review the patch and let me know for any comments. On Mon, Feb 15, 2016 at 4:37 PM, Dave Page wrote: > Hi > > On Mon, Feb 15, 2016 at 9:55 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi, >> >> PFA

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi On Mon, Feb 15, 2016 at 9:55 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > PFA patch with following changes: > >1. Added "Create Extension" menu item in context menu of Database node. >2. Added a new method "node_node" in ExtensionModule class. If a node >

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi, PFA patch with following changes: 1. Added "Create Extension" menu item in context menu of Database node. 2. Added a new method "node_node" in ExtensionModule class. If a node has child, returns True, otherwise False. 3. Fixed an issue in which icon won't display in create

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi, New patch is working fine. Ashesh - Can you please review it? If it looks good then we can commit the extension module. Thanks, Neel Patel On Thu, Feb 4, 2016 at 11:40 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Neel, > > Please find the patch with following changes:

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi Neel, Please find the patch with following changes: 1. Removed Whitespace from files. 2. Fixed an issue in which json object converted into [object object] string. 3. Fixed python3 issue of unicode type where code breaks at "isinstance(SQL, str)" in python3 if str is unicode, because python no

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi Surinder, While applying the patch, we are getting below warnings. extension_v3.patch:362: trailing whitespace. This function will generate sql for sql panel extension_v3.patch:646: trailing whitespace. -- Extension: {{ conn|qtIdent(data.name) }} warning: 2 lines add whitespace

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi, I've fixed the issues given in review comments. Please find the attached updated patch for extension module, review it and let me know for any comments. On Mon, Jan 18, 2016 at 5:44 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Thanks Neel for reviewing. I'll send the

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi Please find the updated patch with following fixes: 1. Missing `owner` column under properties for `extensions collection`. Add cell: 'string' property for owner fixed it 2. Schema object identifier should be wrapped with in function qtIdent . Using function `qtIdent` for schema in create.sql

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi Surinder, We have applied/tested the patch and below are the review comments. 1. When we select the extension "plpython3u", "plperl", "plperu" etc. then it gives 'TypeError' in Javascript. TypeError: d.version is undefined 'version': (!_.isNull(d.version[0]) ? d.version[0]: '') We are

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Thanks Neel for reviewing. I'll send the patch with the fixes suggested. On Mon, Jan 18, 2016 at 4:52 PM, Neel Patel wrote: > Hi Surinder, > > We have applied/tested the patch and below are the review comments. > > 1. When we select the extension "plpython3u",

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Please find the updated patch with following changes: 1. corrected copyright. 2. Added proper comment for script_module function in __init__.py file. 3. Renamed collection Node's label to Extensions in extensions.js file. On Tue, Jan 12, 2016 at 12:44 PM, Surinder Kumar <

[pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi, Please find attached patch for the extension module. Please review it and Let me know for any comments. Thanks, Surinder Kumar diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/extensions/__init__.py