Thanks, applied.
On Mon, Aug 22, 2016 at 3:23 PM, Harshal Dhumal
wrote:
> Hi Dave,
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Aug 22, 2016 at 5:45 PM, Dave Page wrote:
>>
>> Hi
>>
>> On Mon, Aug
Hi Dave,
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Aug 22, 2016 at 5:45 PM, Dave Page wrote:
> Hi
>
> On Mon, Aug 22, 2016 at 1:04 PM, Harshal Dhumal
> wrote:
> > Hi,
> > PFA patch for wrong header and bo
Hi
On Mon, Aug 22, 2016 at 1:04 PM, Harshal Dhumal
wrote:
> Hi,
> PFA patch for wrong header and body were generated.
>
> Fixed the header and body sql parsing issue.
Won't this break if I have a package called issues.foo or anything
else that matches the ' is' or ' as'?
--
Dave Page
Blog: htt
Hi,
PFA patch for wrong header and body were generated.
Fixed the header and body sql parsing issue.
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Aug 22, 2016 at 5:10 PM, Khushboo Vashi <
khushboo.va...@enterp
On Mon, Aug 22, 2016 at 3:10 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
> PFA updated patch for packages
>
> --
> *Harshal Dhumal*
> *Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Aug 18, 2016 at 12:
Thanks - applied with some minor tweaks to groupings.
On Mon, Aug 22, 2016 at 10:40 AM, Harshal Dhumal
wrote:
> Hi,
>
> PFA updated patch for packages
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Au
Hi Harshal,
Please see below review comments.
1. Please make one line space between every SQL block as per pgAdmin 4
standard.
2. The RE SQL of package is not correct. The package name is displayed
twice as shown below
CREATE OR REPLACE PACKAGE enterprisedb.empinfo
IS
edb.empinfo is
emp_name
On Wed, Aug 17, 2016 at 4:35 PM, Dave Page wrote:
> Hi,
>
> I did some quick testing, and found the following issues:
>
> - Package ACL is not shown in properties
>
> - Package header and body are not shown in properties
>
> - System package? is not shown in properties
>
> - The header for the RE
Hi,
I did some quick testing, and found the following issues:
- Package ACL is not shown in properties
- Package header and body are not shown in properties
- System package? is not shown in properties
- The header for the RE SQL on a package procedure should read:
-- Package Procedure
(not
