Re: [pgadmin-hackers] Altering column collation

2011-07-21 Thread Thom Brown
On 21 July 2011 21:58, Guillaume Lelarge wrote: > On Thu, 2011-07-21 at 22:54 +0200, Guillaume Lelarge wrote: >> On Thu, 2011-07-21 at 21:44 +0200, Guillaume Lelarge wrote: >> > On Wed, 2011-07-20 at 10:56 +0100, Thom Brown wrote: >> > > On 19 July 2011 21:04, Guillaume Lelarge wrote: >> > > > On

Re: [pgadmin-hackers] Altering column collation

2011-07-21 Thread Guillaume Lelarge
On Thu, 2011-07-21 at 22:54 +0200, Guillaume Lelarge wrote: > On Thu, 2011-07-21 at 21:44 +0200, Guillaume Lelarge wrote: > > On Wed, 2011-07-20 at 10:56 +0100, Thom Brown wrote: > > > On 19 July 2011 21:04, Guillaume Lelarge wrote: > > > > On Tue, 2011-07-19 at 20:43 +0100, Thom Brown wrote: > >

Re: [pgadmin-hackers] Altering column collation

2011-07-21 Thread Guillaume Lelarge
On Thu, 2011-07-21 at 21:44 +0200, Guillaume Lelarge wrote: > On Wed, 2011-07-20 at 10:56 +0100, Thom Brown wrote: > > On 19 July 2011 21:04, Guillaume Lelarge wrote: > > > On Tue, 2011-07-19 at 20:43 +0100, Thom Brown wrote: > > >> On 19 July 2011 08:32, Guillaume Lelarge wrote: > > >> > On Tue,

Re: [pgadmin-hackers] Altering column collation

2011-07-21 Thread Guillaume Lelarge
On Wed, 2011-07-20 at 10:56 +0100, Thom Brown wrote: > On 19 July 2011 21:04, Guillaume Lelarge wrote: > > On Tue, 2011-07-19 at 20:43 +0100, Thom Brown wrote: > >> On 19 July 2011 08:32, Guillaume Lelarge wrote: > >> > On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: > >> >> [...] > >> >> At

Re: [pgadmin-hackers] Altering column collation

2011-07-20 Thread Thom Brown
On 19 July 2011 21:04, Guillaume Lelarge wrote: > On Tue, 2011-07-19 at 20:43 +0100, Thom Brown wrote: >> On 19 July 2011 08:32, Guillaume Lelarge wrote: >> > On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: >> >> [...] >> >> Attached is a patch which fixes #328.  Currently if you change a >>

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 21:07 +0100, Dave Page wrote: > On Tue, Jul 19, 2011 at 8:27 PM, Guillaume Lelarge > wrote: > > On Tue, 2011-07-19 at 09:32 +0200, Guillaume Lelarge wrote: > >> On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: > >> > [...] > >> > Attached is a patch which fixes #328. Cur

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Dave Page
On Tue, Jul 19, 2011 at 8:27 PM, Guillaume Lelarge wrote: > On Tue, 2011-07-19 at 09:32 +0200, Guillaume Lelarge wrote: >> On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: >> > [...] >> > Attached is a patch which fixes #328.  Currently if you change a >> > column's collation, it actually drop

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 20:43 +0100, Thom Brown wrote: > On 19 July 2011 08:32, Guillaume Lelarge wrote: > > On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: > >> [...] > >> Attached is a patch which fixes #328. Currently if you change a > >> column's collation, it actually drops the column. T

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Thom Brown
On 19 July 2011 08:32, Guillaume Lelarge wrote: > On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: >> [...] >> Attached is a patch which fixes #328.  Currently if you change a >> column's collation, it actually drops the column.  This changes it so >> that it issues an ALTER TYPE to adjust the

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 09:32 +0200, Guillaume Lelarge wrote: > On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: > > [...] > > Attached is a patch which fixes #328. Currently if you change a > > column's collation, it actually drops the column. This changes it so > > that it issues an ALTER TYP

Re: [pgadmin-hackers] Altering column collation

2011-07-19 Thread Guillaume Lelarge
On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote: > [...] > Attached is a patch which fixes #328. Currently if you change a > column's collation, it actually drops the column. This changes it so > that it issues an ALTER TYPE to adjust the collation instead. > Pushed on master. Thanks for ye

[pgadmin-hackers] Altering column collation

2011-07-18 Thread Thom Brown
Hi, Attached is a patch which fixes #328. Currently if you change a column's collation, it actually drops the column. This changes it so that it issues an ALTER TYPE to adjust the collation instead. Regards -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #5