Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-11-01 Thread Guillaume Lelarge
On Thu, 2011-10-13 at 06:22 +0200, Vladimir Kokovic wrote: > Hi, > > I finally found the time to make a new version ! > > > * When I copy a table, and then paste it, I can not paste it once more. > > Why is that? > Fixed > OK. > > * If I paste a table and there is an error (for example, the ta

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-10-03 Thread Guillaume Lelarge
On Sat, 2011-09-24 at 17:43 +0200, Guillaume Lelarge wrote: > On Sun, 2011-09-18 at 15:48 +0200, Vladimir Kokovic wrote: > > Hi, > > > > After a while, here's a new patch for Copy/Paste table(s) functions. > > > > Sorry for not replying sooner. This quick mail to tell you that I'll > work on it

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-09-24 Thread Guillaume Lelarge
On Sun, 2011-09-18 at 15:48 +0200, Vladimir Kokovic wrote: > Hi, > > After a while, here's a new patch for Copy/Paste table(s) functions. > Sorry for not replying sooner. This quick mail to tell you that I'll work on it ASAP. Perhaps tomorrow. Anyway, I didn't forget your patch, I'm just fighti

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-23 Thread Guillaume Lelarge
On Tue, 2011-08-23 at 22:55 +0200, Guillaume Lelarge wrote: > On Tue, 2011-08-23 at 22:32 +0200, Vladimir Kokovic wrote: > > Hi, > > > > Here is the 'drag and drop' ! > > > > Don't get me wrong on this, this is great to add drag and drop support. > But if you keep fixing bugs *and* adding featur

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-23 Thread Guillaume Lelarge
On Tue, 2011-08-23 at 22:32 +0200, Vladimir Kokovic wrote: > Hi, > > Here is the 'drag and drop' ! > Don't get me wrong on this, this is great to add drag and drop support. But if you keep fixing bugs *and* adding features on this patch, we will never be able to commit it. What we need now is a

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-08 Thread Guillaume Lelarge
On Mon, 2011-08-08 at 06:24 +0200, Vladimir Kokovic wrote: > Hi, > > I changed the names of files, so files do not start now with the 'frm' ! > > In this version, disconnect from the DB server has been fixed. > Cannot check that because I have a segfault each time I paste one or more tables in

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Dave Page
Just showing something would almost certainly make it a dialog. I can't see frmXXX being correct here however it's spun. On Saturday, August 6, 2011, Guillaume Lelarge wrote: > On Sat, 2011-08-06 at 16:28 +0100, Dave Page wrote: >> If there's a frmXXX that doesn't implement a separate tool (like

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Guillaume Lelarge
On Sat, 2011-08-06 at 16:28 +0100, Dave Page wrote: > If there's a frmXXX that doesn't implement a separate tool (like the query > tool or server status monitor), then that must be moved & renamed before > commit. > I would prefer the tool to show something, but yeah, you're right, if it doesn't

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Dave Page
If there's a frmXXX that doesn't implement a separate tool (like the query tool or server status monitor), then that must be moved & renamed before commit. On Saturday, August 6, 2011, Guillaume Lelarge wrote: > On Mon, 2011-08-01 at 06:01 +0200, Vladimir Kokovic wrote: >> Hi, >> >> Added a threa

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Guillaume Lelarge
On Sat, 2011-08-06 at 16:30 +0200, Vladimir Kokovic wrote: > Hi, > > I will fix disconnection problem. > Thanks. > Tooltip on the toolbar paste icon shows progress. > Tooltip isn't a better UI than the status bar. And even that one is not a good one for this matter. -- Guillaume http://b

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Vladimir Kokovic
Hi, I will fix disconnection problem. Tooltip on the toolbar paste icon shows progress. Best regards, Vladimir Kokovic, DP senior, Belgrade, Serbia On 8/6/11, Guillaume Lelarge wrote: > On Sat, 2011-08-06 at 15:33 +0200, Guillaume Lelarge wrote: >> On Mon, 2011-08-01 at 06:01 +0200, Vladimir

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Guillaume Lelarge
On Sat, 2011-08-06 at 15:33 +0200, Guillaume Lelarge wrote: > On Mon, 2011-08-01 at 06:01 +0200, Vladimir Kokovic wrote: > > Hi, > > > > Added a thread termination control in case of main frame OnClose. > > > > Ignore previous two patches ! > > > > Tried it. Don't like the big button, I would g

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-08-06 Thread Guillaume Lelarge
On Mon, 2011-08-01 at 06:01 +0200, Vladimir Kokovic wrote: > Hi, > > Added a thread termination control in case of main frame OnClose. > > Ignore previous two patches ! > Tried it. Don't like the big button, I would get rid of it. It behaves much better. I still don't get why you have a frmXXX

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-25 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 16:00 +0200, Vladimir Kokovic wrote: > Hi, > > This patch is probably Release Candidate 2! > > Fixed copy / paste of tables that do not have columns. > > Everything functions as provided except for one detail that I have no > explanation or solution. > > Functionality: > 1

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-22 Thread Guillaume Lelarge
On Fri, 2011-07-22 at 21:54 +0200, Guillaume Lelarge wrote: > On Fri, 2011-07-22 at 21:53 +0200, Guillaume Lelarge wrote: > > On Fri, 2011-07-22 at 06:19 +0200, Vladimir Kokovic wrote: > > > Hi, > > > > > > This time, the patch is probably Release Candidate 1 ! > > > > > > > I'm afraid that won'

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-22 Thread Guillaume Lelarge
On Fri, 2011-07-22 at 21:53 +0200, Guillaume Lelarge wrote: > On Fri, 2011-07-22 at 06:19 +0200, Vladimir Kokovic wrote: > > Hi, > > > > This time, the patch is probably Release Candidate 1 ! > > > > I'm afraid that won't be the last. It still crashes a lot. I still have > the previous issue whe

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-22 Thread Guillaume Lelarge
On Fri, 2011-07-22 at 06:19 +0200, Vladimir Kokovic wrote: > Hi, > > This time, the patch is probably Release Candidate 1 ! > I'm afraid that won't be the last. It still crashes a lot. I still have the previous issue when copying more than one table (with one table, it works). It doesn't like t

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-21 Thread Vladimir Kokovic
Hi, Please, ignore the last patch - Thu, Jul 21, 2011 at 5:19 AM ! I will send new one today. Best regards, Vladimir Kokovic, DP senior, Belgrade, Serbia On 7/21/11, Vladimir Kokovic wrote: > Hi, > > Another try to make final version. > > Best regards, > Vladimir Kokovic, DP senior, Belgrade,

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-19 Thread Guillaume Lelarge
On Wed, 2011-07-20 at 06:11 +0200, Vladimir Kokovic wrote: > Hi, > > I can not reproduce! > For me it works successfully. > > 1. create schema vk1 > 2. CREATE TABLE vk1.t1 (c1 bigint); > 3. create schema vk2 > 4. copy schema tables vk1 > 5. paste into vk2 -- OK > 6. paste into vk1 -- OK > Becau

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-19 Thread Vladimir Kokovic
Hi, I can not reproduce! For me it works successfully. 1. create schema vk1 2. CREATE TABLE vk1.t1 (c1 bigint); 3. create schema vk2 4. copy schema tables vk1 5. paste into vk2 -- OK 6. paste into vk1 -- OK Best regards, Vladimir Kokovic, DP senior, Belgrade, Serbia On 7/19/11, Guillaume Lelar

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-19 Thread Guillaume Lelarge
On Sun, 2011-07-17 at 23:17 +0200, Vladimir Kokovic wrote: > OK > > > Now that we can copy on the same schema, it shouldn't ask for an > > extension, but for the complete name. > > I do not know how to do when the table has objects that each has a name! > > CREATE TABLE gk_vrsta_naloga_vk --NAME

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-17 Thread Vladimir Kokovic
OK > Now that we can copy on the same schema, it shouldn't ask for an > extension, but for the complete name. I do not know how to do when the table has objects that each has a name! CREATE TABLE gk_vrsta_naloga_vk --NAME1 ( id bigint NOT NULL DEFAULT nextval('"''id_gk_vrsta_naloga''"'::regcla

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-17 Thread Guillaume Lelarge
On Sun, 2011-07-17 at 21:44 +0200, Guillaume Lelarge wrote: > On Sun, 2011-07-17 at 20:41 +0200, Vladimir Kokovic wrote: > > I do not know what happened, but I am quite sure that it is not a > > frmPasteObject.cpp! > > > > OK, I did more testing, and the schema stuff is actually a bug I > introdu

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-17 Thread Guillaume Lelarge
On Sun, 2011-07-17 at 20:41 +0200, Vladimir Kokovic wrote: > I do not know what happened, but I am quite sure that it is not a > frmPasteObject.cpp! > OK, I did more testing, and the schema stuff is actually a bug I introduced earlier. And while doing this, I found another one. Grest evening :-/

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-17 Thread Vladimir Kokovic
I do not know what happened, but I am quite sure that it is not a frmPasteObject.cpp! 1. Copy operations are in a new thread (the GUI is not blocked) 2. Copy operations do not use the GUI objects 3, Source objects are on a new connection (does not affect the status of the browser) 4. Target object

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-07-17 Thread Guillaume Lelarge
On Sat, 2011-07-16 at 15:45 +0200, Vladimir Kokovic wrote: > Hi, > > Again, patch for Copy/Paste table(s) functions. > > Done the following: > 1. Copy table/schema in the same schema > 2. Thread implementation for copy table(s) operations > There's a really big bug (as in "segfault bug"). Try t

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-06-27 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 20:11 +0200, Vladimir Kokovic wrote: > Hi, > > Again, patch for Copy/Paste table(s) functions. > I tried it, there are some improvements, but, still, here are my comments. I already asked this, but had no answer. I'll ask again :) Why should the schema be different? you sh

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-06-27 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 17:25 +0200, Vladimir Kokovic wrote: > Hi, > > I don't know who and why keeps source code for copy/paste of > schema/table that I have sent. Probably because I didn't have time when you sent your patch, and that you sent another mail in the same thread about a bug you found.

[pgadmin-hackers] Copy/Paste table(s) functions

2011-06-27 Thread Vladimir Kokovic
Hi, I don't know who and why keeps source code for copy/paste of schema/table that I have sent. That works correctly at my company since April this year. Best regards, Vladimir Kokovic, DP senior, Belgrade, Serbia -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-04-18 Thread Guillaume Lelarge
Le 18/04/2011 11:04, Vladimir Kokovic a écrit : > Hi, > > 1.Select server > 2.Select database > 3.select schema > 4.select table with primary key which contains character varying.field > 5.look in SQL pane line for the primary key definition > If your selected server is PostgreSQL 9.1, primary key

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-04-18 Thread Vladimir Kokovic
Hi, 1.Select server 2.Select database 3.select schema 4.select table with primary key which contains character varying.field 5.look in SQL pane line for the primary key definition If your selected server is PostgreSQL 9.1, primary key looks like: CONSTRAINT edi_razmena_pkey PRIMARY KEY (godina COL

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-04-18 Thread Guillaume Lelarge
Le 18/04/2011 09:15, Vladimir Kokovic a écrit : > Hi, > > Problem is in the text which is returned with pgTable.getSql ! > Without patch primary key contains word 'COLLATE' which PostgreSQL > does not expect. > Yeah, you already said that. I didn't reproduce it. And your patch doesn't forbid it.

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-04-17 Thread Guillaume Lelarge
Le 18/04/2011 05:27, Vladimir Kokovic a écrit : > [...] > Here is patch for TABLE PRIMARY KEY CONSTRAINT on PostgreSQL 9.1 > That doesn't answer my question on how to reproduce it. Or it doesn't have anything to me with my previous answer, but in this case, it would help to have some kind of an e

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-04-17 Thread Vladimir Kokovic
Hi, Here is patch for TABLE PRIMARY KEY CONSTRAINT on PostgreSQL 9.1 Best regards, Vladimir Kokovic, DP senior, Belgrade, Serbia pgIndex.cpp.diff Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-04-17 Thread Guillaume Lelarge
Le 14/04/2011 10:21, Vladimir Kokovic a écrit : > Hi, > > During copy/paste testing I've found that on 9.1 'COLLATE' should be > omitted from table constraints definitions..Look in my PostgreSQL log: > > 2011-04-14 10:04:28 CEST asoft 127.0.0.1(41254) 5357 0 LOG: > statement: SELECT relname FROM

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-04-14 Thread Vladimir Kokovic
Hi, During copy/paste testing I've found that on 9.1 'COLLATE' should be omitted from table constraints definitions..Look in my PostgreSQL log: 2011-04-14 10:04:28 CEST asoft 127.0.0.1(41254) 5357 0 LOG: statement: SELECT relname FROM pg_namespace n LEFT JOIN pg_class c ON n.oid=c.relnamespace AN

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-04-12 Thread Vladimir Kokovic
Hi, Here's a new version of copy / paste table(s)! I hope this is much better than the previous one.. Best regards, Vladimir Kokovic, DP senior, Belgrade, Serbia frm-module.mk.diff Description: Binary data frmMain.cpp.diff Description: Binary data frmMain.h.diff Description: Binary data //

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-04-02 Thread Guillaume Lelarge
Le 31/03/2011 13:31, Vladimir Kokovic a écrit : > Hi, > > Finally I've made Copy/Paste table(s) operations ! > Great. > Usage is very simple and intuitive: > on right mouse menu for selected connected table or schema select > 'Copy table(s)' and than on other connected schema on right mouse men

[pgadmin-hackers] Copy/Paste table(s) functions

2011-03-31 Thread Vladimir Kokovic
Hi, Finally I've made Copy/Paste table(s) operations ! Usage is very simple and intuitive: on right mouse menu for selected connected table or schema select 'Copy table(s)' and than on other connected schema on right mouse menu select 'Paste table(s). Source target server-db might be different b