Re: [pgadmin-hackers] Dialogs Review new patch

2008-08-26 Thread Dave Page
On Tue, Aug 26, 2008 at 3:22 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Guillaume Lelarge a écrit : >> New patch is available on: >> http://developer.pgadmin.org/~guillaume/dialogreview_20080825.patch.bz2 >> >> It'll be commited tomorrow afternoon (if no one objects). >> > > Done. :-) -

Re: [pgadmin-hackers] Dialogs Review new patch

2008-08-26 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : > [...] > I'll only commit some pieces of my patch. Here are the dialogs that > won't be commited: > > * dlgFunction (status bar, OK and cancel buttons don't display >correctly on Mac) > * dlgLanguage (strange error about wxChoice::GetString on Mac... >strange

Re: [pgadmin-hackers] Dialogs Review new patch

2008-08-25 Thread Guillaume Lelarge
Dave Page a écrit : > On Fri, Aug 22, 2008 at 3:06 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >> Dave Page a écrit : >>> - dlgManageMacros - if the size is reduced to minimum, a horizontal >>> scrollbar is show in the list control, due to the width of the name >>> column. >>> >> I don't hav

Re: [pgadmin-hackers] Dialogs Review new patch

2008-08-22 Thread Dave Page
On Fri, Aug 22, 2008 at 3:06 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Dave Page a écrit : >> - dlgManageMacros - if the size is reduced to minimum, a horizontal >> scrollbar is show in the list control, due to the width of the name >> column. >> > > I don't have this issue. Perhaps do you

Re: [pgadmin-hackers] Dialogs Review new patch

2008-08-22 Thread Guillaume Lelarge
Dave Page a écrit : > [...] > On Mon, Aug 18, 2008 at 11:09 PM, Guillaume Lelarge > <[EMAIL PROTECTED]> wrote: >> >> My new patch fixes some issues. Some dialogs seem ready to commit: > > Wow - they look excellent. Just some minor thoughts: > > - dlgManageMacros - if the size is reduced to minimu

Re: [pgadmin-hackers] Dialogs Review new patch

2008-08-21 Thread Dave Page
Hi On Mon, Aug 18, 2008 at 11:09 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Hi, > > My new patch fixes some issues. Some dialogs seem ready to commit: Wow - they look excellent. Just some minor thoughts: - dlgManageMacros - if the size is reduced to minimum, a horizontal scrollbar is sho

[pgadmin-hackers] Dialogs Review new patch

2008-08-18 Thread Guillaume Lelarge
Hi, My new patch fixes some issues. Some dialogs seem ready to commit: * dlgAddFavourite.xrc * dlgAggregate.xrc * dlgCast.xrc * dlgCheck.xrc * dlgColumn.xrc * dlgConversion.xrc * dlgDomain.xrc * dlgForeignKey.xrc * dlgHbaConfig.xrc * dlgIndexConstraint.xrc * dlgIndex.xrc * dlgMainConfi

Re: [pgadmin-hackers] Dialogs review

2008-08-01 Thread Guillaume Lelarge
Dave Page a écrit : On Wed, Jul 23, 2008 at 12:30 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Here is a patch that merges all the others. I don't see another way to do it without completely loosing track of the version of each individual patch. This patch fixes the display issues on Mac OS

Re: [pgadmin-hackers] Dialogs review

2008-07-24 Thread Dave Page
On Wed, Jul 23, 2008 at 12:30 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Here is a patch that merges all the others. I don't see another way to do it > without completely loosing track of the version of each individual patch. > > This patch fixes the display issues on Mac OS X. It adds a fe

Re: [pgadmin-hackers] Dialogs review

2008-07-22 Thread Dave Page
On Tue, Jul 22, 2008 at 2:52 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Yes, it is tiresome. Changing something can bork the entire dialog. Making > it pretty on one platform can bork it on the two others. Not sure I like the > crossplatform capacity anymore :) I feel your pain. > Anyway

Re: [pgadmin-hackers] Dialogs review

2008-07-22 Thread Guillaume Lelarge
Dave Page a écrit : On Mon, Jul 21, 2008 at 6:04 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Reducing the border works here too. To have the blue border on each side of the control, we need to make the control bigger. For example, cbSourceType and cbTargetType have 12 for width. With 14, th

Re: [pgadmin-hackers] Dialogs review

2008-07-21 Thread Guillaume Lelarge
Dave Page a écrit : On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Okay... the wxListCtrl resize problem seems to be a wxMac confirmed bug. See http://trac.wxwidgets.org/ticket/4814 bug report for more details. Not sure about what we should do with this... debug th

Re: [pgadmin-hackers] Dialogs review

2008-07-21 Thread Guillaume Lelarge
Dave Page a écrit : On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Anyways, I attach the new dlgCast.xrc patch file. That looks pretty sweet, and works well :-). The only thing I note, is that even with a bigger gap between controls, the bottom highlight on the

Re: [pgadmin-hackers] Dialogs review

2008-07-21 Thread Dave Page
On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Anyways, I attach the new dlgCast.xrc patch file. That looks pretty sweet, and works well :-). The only thing I note, is that even with a bigger gap between controls, the bottom highlight on the active control (the bl

Re: [pgadmin-hackers] Dialogs review

2008-07-21 Thread Dave Page
On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Okay... the wxListCtrl resize problem seems to be a wxMac confirmed bug. See > http://trac.wxwidgets.org/ticket/4814 bug report for more details. Not sure > about what we should do with this... debug the stuff on wxMac

Re: [pgadmin-hackers] Dialogs review

2008-07-19 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : Dave Page a écrit : On Mon, Jul 14, 2008 at 8:17 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: H, I see... that I can't do anything till I get my Mac. I will work on it but I don't know now how to fix it. Understood. I'm really busy right now (yeah, I know

Re: [pgadmin-hackers] Dialogs review

2008-07-19 Thread Guillaume Lelarge
Dave Page a écrit : On Mon, Jul 14, 2008 at 8:17 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: H, I see... that I can't do anything till I get my Mac. I will work on it but I don't know now how to fix it. Understood. I'm really busy right now (yeah, I know I'm starting to sound like a

Re: [pgadmin-hackers] Dialogs review

2008-07-15 Thread Dave Page
On Mon, Jul 14, 2008 at 8:17 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > H, I see... that I can't do anything till I get my Mac. I will work on > it but I don't know now how to fix it. Understood. I'm really busy right now (yeah, I know I'm starting to sound like a broken record with t

Re: [pgadmin-hackers] Dialogs review

2008-07-14 Thread Guillaume Lelarge
Dave Page a écrit : [Screenshots at http://developer.pgadmin.org/~dpage/Screenshots.zip] On Thu, Jul 10, 2008 at 1:45 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: Dave Page a écrit : - There needs to be more of a border around the panes and between the contorls. The controls are very tight

Re: [pgadmin-hackers] Dialogs review

2008-07-10 Thread Dave Page
[Screenshots at http://developer.pgadmin.org/~dpage/Screenshots.zip] On Thu, Jul 10, 2008 at 1:45 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Dave Page a écrit : >> >> - There needs to be more of a border around the panes and between the >> contorls. The controls are very tight to the top,

Re: [pgadmin-hackers] Dialogs review

2008-07-10 Thread Dave Page
On Wed, Jul 9, 2008 at 10:51 PM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Guillaume Lelarge a écrit : >> >> [...] >> I tend to prefer the "one patch for each dialog" approach, but I would >> like to know your thoughts on this. >> > > Here is the first one, dlgAggregate.xrc. Cool. Testing on

Re: [pgadmin-hackers] Dialogs review

2008-07-09 Thread Guillaume Lelarge
Guillaume Lelarge a écrit : [...] I tend to prefer the "one patch for each dialog" approach, but I would like to know your thoughts on this. Here is the first one, dlgAggregate.xrc. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com Index: pgadmin/ui/dlgAggregate.xrc ===

Re: [pgadmin-hackers] Dialogs review

2008-06-16 Thread Dave Page
On Mon, Jun 16, 2008 at 8:52 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: >> Oh, and just so you know, some of the tools out there are not Open >> Source. pgAdmin is not a political project, and I wouldn't want us to >> discount something that may be a great tool purely because it's not >> OSS.

Re: [pgadmin-hackers] Dialogs review

2008-06-16 Thread Guillaume Lelarge
Dave Page a écrit : On Sun, Jun 15, 2008 at 8:21 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: I'm thinking about doing a complete review of our dialogs. During my work on the comment tab, I found many dialogs not using spacers and sizers. So, I would like to add them and, if at all possible

Re: [pgadmin-hackers] Dialogs review

2008-06-16 Thread Dave Page
On Sun, Jun 15, 2008 at 8:21 AM, Guillaume Lelarge <[EMAIL PROTECTED]> wrote: > Hi all, > > I'm thinking about doing a complete review of our dialogs. During my work on > the comment tab, I found many dialogs not using spacers and sizers. So, I > would like to add them and, if at all possible, make

Re: [pgadmin-hackers] Dialogs review

2008-06-15 Thread Magnus Hagander
Guillaume Lelarge wrote: > Hi all, > > I'm thinking about doing a complete review of our dialogs. During my > work on the comment tab, I found many dialogs not using spacers and > sizers. So, I would like to add them and, if at all possible, make > dialogs growable. Of course, I'll wait the commen

[pgadmin-hackers] Dialogs review

2008-06-15 Thread Guillaume Lelarge
Hi all, I'm thinking about doing a complete review of our dialogs. During my work on the comment tab, I found many dialogs not using spacers and sizers. So, I would like to add them and, if at all possible, make dialogs growable. Of course, I'll wait the comment patch is applied before workin