Re: [pgadmin-hackers] Feature test regression failures

> > > Maybe - I'd need to see a viable patch with minimal impact first though. Sure, makes sense. That'll only work to a point. What happens if the user installs a > plugin to get some additional functionality? We still need the ability > to ensure code can be added to an existing installation.

Re: [pgadmin-hackers] Feature test regression failures

On Mon, Mar 27, 2017 at 12:05 PM, Atira Odhner wrote: >> A change as large as moving to React will be for v2.x, not v1.x, so we >> cannot really wait unless we want to write off the feature tests as >> unusable for the forseeable future. > > > I don't think we should wait on moving the entire code

Re: [pgadmin-hackers] Feature test regression failures

> > A change as large as moving to React will be for v2.x, not v1.x, so we > cannot really wait unless we want to write off the feature tests as > unusable for the forseeable future. I don't think we should wait on moving the entire codebase to react before releasing features that use it. React a

Re: [pgadmin-hackers] Feature test regression failures

On Mon, Mar 27, 2017 at 11:47 AM, Atira Odhner wrote: >> >> Tira's various patches all seem to be flakey :-(: > > > Yes, that's because the way it was working before was to arbitrarily wait a > full second. My intent with the patches was not to apply them to the code, > but to demonstrate that the

Re: [pgadmin-hackers] Feature test regression failures

> > > Tira's various patches all seem to be flakey :-(: Yes, that's because the way it was working before was to arbitrarily wait a full second. My intent with the patches was not to apply them to the code, but to demonstrate that the issue was not related to time spent loading js files through r

[pgadmin-hackers] Feature test regression failures

So I had a play with all of these patches. As a sidenote, I'm travelling at the moment, so am using my regular MacBook which is far slower than my normal MacBook Pro. The following is a late-night brain-dump of thoughts... Tira's various patches all seem to be flakey :-(: - The spinner is disable

Re: [pgadmin-hackers] Feature test regression failures

Hi Ashesh, > First - let me try to explain the problem with the failure in the >>> feature test. >>> We do not load all the javascript libraries, when starting the pgAdmin 4 >>> (i.e. the loading the browser/index.html). >>> But - load them only when first tree-item of certain type is added. >>>

Re: [pgadmin-hackers] Feature test regression failures

On Wed, Mar 22, 2017 at 7:23 PM, Atira Odhner wrote: > First - let me try to explain the problem with the failure in the >> feature test. >> We do not load all the javascript libraries, when starting the pgAdmin 4 >> (i.e. the loading the browser/index.html). >> But - load them only when first t

Re: [pgadmin-hackers] Feature test regression failures

> > First - let me try to explain the problem with the failure in the > feature test. > We do not load all the javascript libraries, when starting the pgAdmin 4 > (i.e. the loading the browser/index.html). > But - load them only when first tree-item of certain type is added. > e.g. We load the jav

Re: [pgadmin-hackers] Feature test regression failures

-- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Mar 21, 2017 at 9:20 PM, Atira Odhner wrote: > Here is a new patchset that instead hides

Re: [pgadmin-hackers] Feature test regression failures

Here is a new patchset that instead hides the spinner when the acitree has been initialized. On average, the spinner seems to disappear about 2 seconds sooner, and I haven't seen flakiness with these changes yet. Tira & Joao On Mon, Mar 20, 2017 at 4:17 PM, Atira Odhner wrote: > Note that this

Re: [pgadmin-hackers] Feature test regression failures

Note that this patch makes the problem of the tree not having loaded worse, because it only waits for js modules to load rather than arbitrarily waiting 900ms. On Mon, Mar 20, 2017 at 3:17 PM, Atira Odhner wrote: > Hi Ashesh, > > *Regarding your second patch:* > > It looks like your second patch

Re: [pgadmin-hackers] Feature test regression failures

Hi Ashesh, *Regarding your second patch:* It looks like your second patch addresses module loading. This is an improvement over the previous hard timeout, but won’t do anything for the tree issues. The module loading code can also be simplified; we’ve attached a patchset that is tidier, tests the

Re: [pgadmin-hackers] Feature test regression failures

On Mon, Mar 20, 2017 at 10:24 AM, Ashesh Vashi wrote: > On Fri, Mar 17, 2017 at 8:35 PM, Sarah McAlear wrote: >> >> Hello, >> >> We agree that we should keep an eye on this and the failing feature tests. >> Our current story touches part of this code, but we won't go into changing >> the library

Re: [pgadmin-hackers] Feature test regression failures

On Fri, Mar 17, 2017 at 8:35 PM, Sarah McAlear wrote: > Hello, > > We agree that we should keep an eye on this and the failing feature tests. > Our current story touches part of this code, but we won't go into changing > the library for now. > > The patch Tira sent fixes a global variable problem

Re: [pgadmin-hackers] Feature test regression failures

Hello, We agree that we should keep an eye on this and the failing feature tests. Our current story touches part of this code, but we won't go into changing the library for now. The patch Tira sent fixes a global variable problem that we found while looking into the code that generates the Tree,

Re: [pgadmin-hackers] Feature test regression failures

> > We're relying on the third party library jquery.acitree for tree > operations. Yes, what I was suggesting is to probably move away from that. AciTree is one of the libraries my team identified as questionable (not in major repositories, not actively maintained) and there are lots of alternati

Re: [pgadmin-hackers] Feature test regression failures

On Mar 16, 2017 22:32, "Atira Odhner" wrote: I have seen this issue as well. Ashesh, this issue is related to the loading of the tree node data, not loading of code, correct? Theoritically - Each node may contain code to represent the node url. For all current nodes follow the function (present

Re: [pgadmin-hackers] Feature test regression failures

I have seen this issue as well. Ashesh, this issue is related to the loading of the tree node data, not loading of code, correct? Each time the user expands a node triggers an ajax request to fetch the child nodes. There are probably some performance tradeoffs to loading that tree up front. But,

Re: [pgadmin-hackers] Feature test regression failures

On Thu, Mar 16, 2017 at 10:39 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Thu, Mar 16, 2017 at 3:55 PM, Dave Page wrote: > >> Hi Ashesh, >> >> A common theme is emerging from some of the feature test regression >> failures on the Jenkins server. Please see: >> >> https://jenkins

Re: [pgadmin-hackers] Feature test regression failures

On Thu, Mar 16, 2017 at 3:55 PM, Dave Page wrote: > Hi Ashesh, > > A common theme is emerging from some of the feature test regression > failures on the Jenkins server. Please see: > > https://jenkins.pgadmin.org/job/pgadmin4-master-python27/ > ws/web/regression/screenshots/EDB_Postgres_AS_9.3/ >

[pgadmin-hackers] Feature test regression failures

Hi Ashesh, A common theme is emerging from some of the feature test regression failures on the Jenkins server. Please see: https://jenkins.pgadmin.org/job/pgadmin4-master-python27/ws/web/regression/screenshots/EDB_Postgres_AS_9.3/ConnectsToServerFeatureTest-2017.03.16_10.09.18-Python-2.7.13.png