Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Thanks, applied. On Thu, Jun 8, 2017 at 1:59 PM, Harshal Dhumal wrote: > Please find attached rebased patch. > > -- > Harshal Dhumal > Sr. Software Engineer > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jun 7, 2017 at 6:59 PM, Dave Page wrote

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Please find attached rebased patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 7, 2017 at 6:59 PM, Dave Page wrote: > Can you rebase this please? I think Ashesh broke it :-p > > On Tue, Jun 6, 2017

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Can you rebase this please? I think Ashesh broke it :-p On Tue, Jun 6, 2017 at 7:42 AM, Harshal Dhumal wrote: > Hi, > > On Mon, Jun 5, 2017 at 9:25 PM, Dave Page wrote: >> >> Hi >> >> With this patch applied, it uses the field names instead of the labels >> in error messages - e.g. >> >> 'dirty_

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, On Mon, Jun 5, 2017 at 9:25 PM, Dave Page wrote: > Hi > > With this patch applied, it uses the field names instead of the labels > in error messages - e.g. > > 'dirty_rate_limit' must be numeric > > instead of: > > 'Dirty Rate Limit (KB)' must be numeric. > Fixed. Please find attached update

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi With this patch applied, it uses the field names instead of the labels in error messages - e.g. 'dirty_rate_limit' must be numeric instead of: 'Dirty Rate Limit (KB)' must be numeric. Thanks. On Tue, May 30, 2017 at 8:28 AM, Harshal Dhumal wrote: > Hi, > > Please find updated patch. > > -

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, Please find updated patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 30, 2017 at 12:30 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please ignore this patch as I forgo

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, Please ignore this patch as I forgot to include few changes. I'll send updated one. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 29, 2017 at 3:18 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.co

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, Here is updated patch for RM2421. Now I have moved all Numeric control level validations to datamodel. As existing implementation was causing issues with error messages in create/edit dialog when schema contains two or more Numeric controls. This is generic issue and not related to resource

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, On Thu, May 18, 2017 at 7:57 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Harshal, > > We review the patch and have some questions: > 1) Is there any particular reason to initialize variables and functions in > the same place? We believe that it would be mo

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hello Harshal, We review the patch and have some questions: 1) Is there any particular reason to initialize variables and functions in the same place? We believe that it would be more readable there were no chaining of variable creation, specially if those variables are functions. Check line: +++

[pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, Please find attached patch for RM2421 Issue fixed: 1. Integer/numeric Validation is not working properly. 2. Wrong CPU rate unit -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/ser