Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-08-11 Thread Guillaume Lelarge
On Thu, 2011-08-11 at 21:16 +0200, Guillaume Lelarge wrote: > On Thu, 2011-08-11 at 08:52 +0100, Dave Page wrote: > > On Wed, Aug 10, 2011 at 11:06 PM, Guillaume Lelarge > > wrote: > > > On Tue, 2011-08-09 at 00:30 +0200, Guillaume Lelarge wrote: > > >> On Sun, 2011-07-24 at 15:09 +0100, Dave Page

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-08-11 Thread Guillaume Lelarge
On Thu, 2011-08-11 at 08:52 +0100, Dave Page wrote: > On Wed, Aug 10, 2011 at 11:06 PM, Guillaume Lelarge > wrote: > > On Tue, 2011-08-09 at 00:30 +0200, Guillaume Lelarge wrote: > >> On Sun, 2011-07-24 at 15:09 +0100, Dave Page wrote: > >> > On Sun, Jul 24, 2011 at 2:23 PM, Guillaume Lelarge > >>

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-08-11 Thread Dave Page
On Wed, Aug 10, 2011 at 11:06 PM, Guillaume Lelarge wrote: > On Tue, 2011-08-09 at 00:30 +0200, Guillaume Lelarge wrote: >> On Sun, 2011-07-24 at 15:09 +0100, Dave Page wrote: >> > On Sun, Jul 24, 2011 at 2:23 PM, Guillaume Lelarge >> > wrote: >> > > On Sun, 2011-07-24 at 14:11 +0200, Guillaume L

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-08-10 Thread Guillaume Lelarge
On Tue, 2011-08-09 at 00:30 +0200, Guillaume Lelarge wrote: > On Sun, 2011-07-24 at 15:09 +0100, Dave Page wrote: > > On Sun, Jul 24, 2011 at 2:23 PM, Guillaume Lelarge > > wrote: > > > On Sun, 2011-07-24 at 14:11 +0200, Guillaume Lelarge wrote: > > >> On Sun, 2011-07-24 at 12:58 +0100, Dave Page

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-08-08 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 15:09 +0100, Dave Page wrote: > On Sun, Jul 24, 2011 at 2:23 PM, Guillaume Lelarge > wrote: > > On Sun, 2011-07-24 at 14:11 +0200, Guillaume Lelarge wrote: > >> On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: > >> > The former fix seems more appropriate. Operations in frm

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Dave Page
On Sun, Jul 24, 2011 at 2:23 PM, Guillaume Lelarge wrote: > On Sun, 2011-07-24 at 14:11 +0200, Guillaume Lelarge wrote: >> On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: >> > The former fix seems more appropriate. Operations in frmMain shouldn't >> > cause dialogues to close. >> > >> >> Fine

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Dave Page
On Sun, Jul 24, 2011 at 1:11 PM, Guillaume Lelarge wrote: > On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: >> The former fix seems more appropriate. Operations in frmMain shouldn't >> cause dialogues to close. >> > > Fine with me. That should be simpler to do. > >> Simple fix seems to be to s

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 14:11 +0200, Guillaume Lelarge wrote: > On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: > > The former fix seems more appropriate. Operations in frmMain shouldn't > > cause dialogues to close. > > > > Fine with me. That should be simpler to do. > > > Simple fix seems to

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Guillaume Lelarge
On Sun, 2011-07-24 at 12:58 +0100, Dave Page wrote: > The former fix seems more appropriate. Operations in frmMain shouldn't > cause dialogues to close. > Fine with me. That should be simpler to do. > Simple fix seems to be to store a pointer to the dialog in pgObject; > if not null, disallow dr

Re: [pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Dave Page
The former fix seems more appropriate. Operations in frmMain shouldn't cause dialogues to close. Simple fix seems to be to store a pointer to the dialog in pgObject; if not null, disallow drop, or if trying to view properties, use the pointer to raise the existing dialogue. Clear the pointer when

[pgadmin-hackers] Fixing issues between objects and properties dialogs

2011-07-24 Thread Guillaume Lelarge
Hi, There is at least one bug that I know since I started to use pgAdmin, and I've seen no work on it. When someone connects to a database, the treeview is built from informations gathered in the database. Not only do we fill the treeview, but we also create a lot of pgObject objects (pgTable, pg